Fighter::championship() - Code Metrics - Inspection of "refactor" - xoco70/laravel-tournaments - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 2162ae...e07b4a )

by Julien

created 2017-05-22 06:22 UTC

Fighter::championship() A

↳ Parent: Fighter

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	0

<?php

namespace Xoco70\KendoTournaments\Models;

use Illuminate\Database\Eloquent\Model;

class Fighter extends Model
{
    /**
     * Get the Competitor's Championship.
     *
     * @return \Illuminate\Database\Eloquent\Relations\BelongsTo
     */
    function championship()

    {
        return $this->belongsTo(Championship::class);
    }

    /**
     * @return \Illuminate\Database\Eloquent\Relations\HasManyThrough
     */
    function category()
    {
        return $this->hasManyThrough(Category::class, Championship::class);
    }

    /**
     * @return Competitor|Team
     */
    function fighter()

    {
        if ($this->championship->category->isTeam()) {
            return new Team();
        }
        return new Competitor();

    }
}


1			<?php
2
3			namespace Xoco70\KendoTournaments\Models;
4
5			use Illuminate\Database\Eloquent\Model;
6
7			class Fighter extends Model
8			{
9			/**
10			* Get the Competitor's Championship.
11			*
12			* @return \Illuminate\Database\Eloquent\Relations\BelongsTo
13			*/
14			function championship()
			0 ignored issues – show Best Practice introduced 2017-05-22 06:53 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
15			{
16			return $this->belongsTo(Championship::class);
17			}
18
19			/**
20			* @return \Illuminate\Database\Eloquent\Relations\HasManyThrough
21			*/
22			function category()
23			{
24			return $this->hasManyThrough(Category::class, Championship::class);
25			}
26
27			/**
28			* @return Competitor\|Team
29			*/
30			function fighter()
			0 ignored issues – show Coding Style Best Practice introduced 2017-05-22 06:53 UTC by Report Bug Copy Issue Report Please use `__construct()` instead of a PHP4-style constructor that is named after the class. Loading history...
31			{
32			if ($this->championship->category->isTeam()) {
33			return new Team();
34			}
35			return new Competitor();
36
37			}
38			}
39

xoco70 / laravel-tournaments

Push — master ( 2162ae...e07b4a )

Fighter::championship() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like