Passed
Push — master ( 2162ae...e07b4a )
by Julien
30:30
created
src/TreeGen/TreeGen.php 1 patch
Doc Comments   +9 added lines, -10 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
 
49 49
     /**
50 50
      * Get the biggest entity group
51
-     * @param $userGroups
51
+     * @param Collection $userGroups
52 52
      *
53 53
      * @return int
54 54
      */
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
 
108 108
     /**
109 109
      * Repart BYE in the tree,
110
-     * @param $fighterGroups
110
+     * @param Collection $fighterGroups
111 111
      * @param int $max
112 112
      *
113 113
      * @return Collection
@@ -153,7 +153,6 @@  discard block
 block discarded – undo
153 153
      * @param Collection $usersByArea
154 154
      * @param integer $area
155 155
      * @param integer $round
156
-     * @param integer $shuffle
157 156
      *
158 157
      */
159 158
     public function generateGroupsForRound($usersByArea, $area, $round)
@@ -176,9 +175,9 @@  discard block
 block discarded – undo
176 175
     }
177 176
 
178 177
     /**
179
-     * @param $area
180
-     * @param $order
181
-     * @param $round
178
+     * @param integer $area
179
+     * @param integer $order
180
+     * @param integer $round
182 181
      * @param $parent
183 182
      * @return FightersGroup
184 183
      */
@@ -339,8 +338,8 @@  discard block
 block discarded – undo
339 338
 
340 339
     /**
341 340
      * @param Collection $fighters
342
-     * @param $frequency
343
-     * @param $sizeGroupBy
341
+     * @param integer $frequency
342
+     * @param integer $sizeGroupBy
344 343
      * @param $bye
345 344
      * @return Collection
346 345
      */
@@ -363,8 +362,8 @@  discard block
 block discarded – undo
363 362
     /**
364 363
      * @param $frequency
365 364
      * @param $sizeGroupBy
366
-     * @param $count
367
-     * @param $byeCount
365
+     * @param integer $count
366
+     * @param integer $byeCount
368 367
      * @return bool
369 368
      */
370 369
     private function shouldInsertBye($frequency, $sizeGroupBy, $count, $byeCount): bool
Please login to merge, or discard this patch.
src/models/FightersGroup.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -201,7 +201,9 @@
 block discarded – undo
201 201
             $fightsByRound = $championship->fightsByRound($numRound)->with('group.parent', 'group.children')->get();
202 202
             foreach ($fightsByRound as $fight) {
203 203
                 $parentGroup = $fight->group->parent;
204
-                if ($parentGroup == null) break;
204
+                if ($parentGroup == null) {
205
+                    break;
206
+                }
205 207
                 $parentFight = $parentGroup->fights->get(0); //TODO This Might change when extending to Preliminary
206 208
 
207 209
                 // IN this $fight, is c1 or c2 has the info?
Please login to merge, or discard this patch.