Xoco70\KendoTournaments\Models\Fighter

Complexity

Total Complexity

4

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes	1
Bugs	0	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	championship()	0	4	1
A	category()	0	4	1
A	fighter()	0	8	2

<?php

namespace Xoco70\KendoTournaments\Models;

use Illuminate\Database\Eloquent\Model;

class Fighter extends Model
{
    /**
     * Get the Competitor's Championship.
     *
     * @return \Illuminate\Database\Eloquent\Relations\BelongsTo
     */
    function championship()

It is generally recommended to explicitly declare the visibility for methods.

    {
        return $this->belongsTo(Championship::class);
    }

    /**
     * @return \Illuminate\Database\Eloquent\Relations\HasManyThrough
     */
    function category()
    {
        return $this->hasManyThrough(Category::class, Championship::class);
    }

    /**
     * @return Competitor|Team
     */
    function fighter()

Please use __construct() instead of a PHP4-style constructor that is named after the class.

    {
        if ($this->championship->category->isTeam()) {
            return new Team();
        }
        return new Competitor();

    }
}