Completed
Pull Request — 1.0 (#8)
by David
06:24
created
src/ServiceProvider/ServiceProviderLoader.php 3 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -64,7 +64,6 @@  discard block
 block discarded – undo
64 64
 
65 65
     /**
66 66
      * @param string $serviceName
67
-     * @param ServiceProvider $serviceProvider
68 67
      * @param int $serviceProviderKey
69 68
      * @param callable $callable
70 69
      * @throws \TheCodingMachine\Yaco\CompilerException
@@ -122,11 +121,12 @@  discard block
 block discarded – undo
122 121
     }
123 122
 
124 123
     /**
125
-     * @param $serviceName
124
+     * @param string $serviceName
126 125
      * @param int $serviceProviderKey
127 126
      * @param callable $callable
128 127
      * @param ContainerDefinition $containerDefinition
129 128
      * @param CallbackWrapperDefinition|null $callbackWrapperDefinition
129
+     * @param string $decoratedServiceName
130 130
      * @return DumpableInterface
131 131
      */
132 132
     private function getServiceDefinitionFromCallable($decoratedServiceName, $serviceName, $serviceProviderKey, callable $callable, ContainerDefinition $containerDefinition, CallbackWrapperDefinition $callbackWrapperDefinition = null) {
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -6,8 +6,6 @@  discard block
 block discarded – undo
6 6
 
7 7
 use Interop\Container\Definition\DefinitionInterface;
8 8
 use Interop\Container\ServiceProvider;
9
-use Puli\Discovery\Api\Discovery;
10
-use Puli\Discovery\Binding\ClassBinding;
11 9
 use TheCodingMachine\ServiceProvider\Registry;
12 10
 use TheCodingMachine\Yaco\Compiler;
13 11
 use TheCodingMachine\Yaco\CompilerException;
@@ -15,7 +13,6 @@  discard block
 block discarded – undo
15 13
 use TheCodingMachine\Yaco\Definition\DumpableInterface;
16 14
 use TheCodingMachine\Yaco\Definition\FactoryCallDefinition;
17 15
 use TheCodingMachine\Yaco\Definition\Reference;
18
-use TheCodingMachine\Yaco\DefinitionConverter;
19 16
 use TheCodingMachine\Yaco\DefinitionConverterInterface;
20 17
 
21 18
 class ServiceProviderLoader
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-declare(strict_types=1);
2
+declare(strict_types = 1);
3 3
 
4 4
 namespace TheCodingMachine\Yaco\ServiceProvider;
5 5
 
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
             return $this->converter->convert($decoratedServiceName, $callable);
135 135
         }
136 136
         if (is_array($callable) && is_string($callable[0])) {
137
-            $params = [ $containerDefinition ];
137
+            $params = [$containerDefinition];
138 138
             if ($callbackWrapperDefinition) {
139 139
                 $params[] = $callbackWrapperDefinition;
140 140
             }
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
             $pos = strpos($callable, '::');
144 144
             $className = substr($callable, 0, $pos);
145 145
             $methodName = substr($callable, $pos+2);
146
-            $params = [ $containerDefinition ];
146
+            $params = [$containerDefinition];
147 147
             if ($callbackWrapperDefinition) {
148 148
                 $params[] = $callbackWrapperDefinition;
149 149
             }
Please login to merge, or discard this patch.