thecodingmachine / yaco

src/Definition/ValueUtils.php

Doc Comments +9 added lines

@@ -25,6 +25,9 @@ 
         }
     }
 
+    /**
+     * @param string $containerVariable
+     */
     public static function dumpArguments($argumentsValues, $containerVariable, array $usedVariables) {
         $arguments = [];
         $prependedCode = [];
@@ -41,6 +44,9 @@ 
         return new InlineEntry($argumentsCode, $prependedCodeString, $usedVariables);
     }
 
+    /**
+     * @param string $containerVariable
+     */
     private static function dumpArray(array $value, $containerVariable, array $usedVariables) {
         $code = array();
         $prependCode = array();
@@ -58,6 +64,9 @@ 
         return new InlineEntry(sprintf('array(%s)', implode(', ', $code)), implode("\n", $prependCode), $usedVariables);
     }
 
+    /**
+     * @param string $containerVariable
+     */
     private static function dumpDefinition(DumpableInterface $definition, $containerVariable, array $usedVariables) {
         // If the identifier is null, we must inline the definition.
         if ($definition->getIdentifier() === null) {

src/Compiler.php

Spacing +2 added lines, -2 removed lines

@@ -94,7 +94,7 @@ 
 
         // Let's merge dumpable definitions with standard definitions.
         $convertedDefinitions = array_map([$this->converter, 'convert'], $this->definitions);
-        $allDefinitions = $convertedDefinitions + $this->dumpableDefinitions;
+        $allDefinitions = $convertedDefinitions+$this->dumpableDefinitions;
 
         foreach ($allDefinitions as $identifier => $definition) {
             $inlineEntry = $definition->toPhpCode('$container', ['$container']);
@@ -113,7 +113,7 @@ 
     {
         $pos = strrpos($className, '\\');
         if ($pos !== false) {
-            $shortClassName = substr($className, $pos + 1);
+            $shortClassName = substr($className, $pos+1);
             $namespaceLine = 'namespace '.substr($className, 0, $pos).';';
         } else {
             $shortClassName = $className;

src/Definition/VariableUtils.php

Spacing +2 added lines, -2 removed lines

@@ -23,10 +23,10 @@
 
             $numbers = '';
             while (true) {
-                $lastCharacter = substr($variable, strlen($variable) - 1);
+                $lastCharacter = substr($variable, strlen($variable)-1);
                 if ($lastCharacter >= '0' && $lastCharacter <= '9') {
                     $numbers = $lastCharacter.$numbers;
-                    $variable = substr($variable, 0, strlen($variable) - 1);
+                    $variable = substr($variable, 0, strlen($variable)-1);
                 } else {
                     break;
                 }

src/DefinitionConverter.php

Doc Comments +1 added lines, -1 removed lines

@@ -22,7 +22,7 @@
 {
     /**
      * @param string $identifier
-     * @param DefinitionInterface|mixed $definition
+     * @param DefinitionInterface $definition
      * @return AliasDefinition|FactoryCallDefinition|ObjectDefinition|ParameterDefinition
      */
     public function convert($identifier, $definition)

src/ServiceProvider/ServiceProviderLoader.php

Doc Comments +2 added lines, -2 removed lines

@@ -64,7 +64,6 @@ 
 
     /**
      * @param string $serviceName
-     * @param ServiceProvider $serviceProvider
      * @param int $serviceProviderKey
      * @param callable $callable
      * @throws \TheCodingMachine\Yaco\CompilerException
@@ -122,11 +121,12 @@ 
     }
 
     /**
-     * @param $serviceName
+     * @param string $serviceName
      * @param int $serviceProviderKey
      * @param callable $callable
      * @param ContainerDefinition $containerDefinition
      * @param CallbackWrapperDefinition|null $callbackWrapperDefinition
+     * @param string $decoratedServiceName
      * @return DumpableInterface
      */
     private function getServiceDefinitionFromCallable($decoratedServiceName, $serviceName, $serviceProviderKey, callable $callable, ContainerDefinition $containerDefinition, CallbackWrapperDefinition $callbackWrapperDefinition = null) {

Unused Use Statements -3 removed lines

@@ -6,8 +6,6 @@ 
 
 use Interop\Container\Definition\DefinitionInterface;
 use Interop\Container\ServiceProvider;
-use Puli\Discovery\Api\Discovery;
-use Puli\Discovery\Binding\ClassBinding;
 use TheCodingMachine\ServiceProvider\Registry;
 use TheCodingMachine\Yaco\Compiler;
 use TheCodingMachine\Yaco\CompilerException;
@@ -15,7 +13,6 @@ 
 use TheCodingMachine\Yaco\Definition\DumpableInterface;
 use TheCodingMachine\Yaco\Definition\FactoryCallDefinition;
 use TheCodingMachine\Yaco\Definition\Reference;
-use TheCodingMachine\Yaco\DefinitionConverter;
 use TheCodingMachine\Yaco\DefinitionConverterInterface;
 
 class ServiceProviderLoader

Spacing +3 added lines, -3 removed lines

@@ -1,5 +1,5 @@ 
 <?php
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace TheCodingMachine\Yaco\ServiceProvider;
 
@@ -134,7 +134,7 @@ 
             return $this->converter->convert($decoratedServiceName, $callable);
         }
         if (is_array($callable) && is_string($callable[0])) {
-            $params = [ $containerDefinition ];
+            $params = [$containerDefinition];
             if ($callbackWrapperDefinition) {
                 $params[] = $callbackWrapperDefinition;
             }
@@ -143,7 +143,7 @@ 
             $pos = strpos($callable, '::');
             $className = substr($callable, 0, $pos);
             $methodName = substr($callable, $pos+2);
-            $params = [ $containerDefinition ];
+            $params = [$containerDefinition];
             if ($callbackWrapperDefinition) {
                 $params[] = $callbackWrapperDefinition;
             }