sminnee / silverstripe-framework

src/Forms/HTMLEditor/HTMLEditorSanitiser.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use DOMAttr;
 use DOMElement;
-use DOMNode;
 use SilverStripe\Core\Injector\Injectable;
 use SilverStripe\View\Parsers\HTMLValue;
 use stdClass;

Doc Comments +1 added lines, -1 removed lines

@@ -52,7 +52,7 @@
     /**
      * Given a TinyMCE pattern (close to unix glob style), create a regex that does the match
      *
-     * @param $str - The TinyMCE pattern
+     * @param string|null $str - The TinyMCE pattern
      * @return string - The equivalent regex
      */
     protected function patternToRegex($str)

src/ORM/FieldType/DBText.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use SilverStripe\Core\Config\Config;
 use SilverStripe\Core\Convert;
-use SilverStripe\Core\Injector\Injector;
 use SilverStripe\Forms\TextareaField;
 use SilverStripe\Forms\NullableField;
 use SilverStripe\Forms\TextField;

src/ORM/Queries/SQLSelect.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace SilverStripe\ORM\Queries;
 
 use SilverStripe\Core\Injector\Injector;
-use SilverStripe\Dev\Deprecation;
 use SilverStripe\ORM\DB;
 use InvalidArgumentException;
 

Doc Comments +1 added lines, -3 removed lines

@@ -380,7 +380,7 @@ 
      *
      * @param string $value
      * @param string $defaultDirection
-     * @return array A two element array: array($column, $direction)
+     * @return string[] A two element array: array($column, $direction)
      */
     private function getDirectionFromString($value, $defaultDirection = null)
     {
@@ -482,7 +482,6 @@ 
      * @see SQLSelect::addWhere() for syntax examples
      *
      * @param mixed $having Predicate(s) to set, as escaped SQL statements or paramaterised queries
-     * @param mixed $having,... Unlimited additional predicates
      * @return $this Self reference
      */
     public function setHaving($having)
@@ -498,7 +497,6 @@ 
      * @see SQLSelect::addWhere() for syntax examples
      *
      * @param mixed $having Predicate(s) to set, as escaped SQL statements or paramaterised queries
-     * @param mixed $having,... Unlimited additional predicates
      * @return $this Self reference
      */
     public function addHaving($having)

src/Security/PermissionCheckboxSetField.php

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use SilverStripe\ORM\SS_List;
 use SilverStripe\ORM\ArrayList;
 use SilverStripe\ORM\DataObjectInterface;
-use SilverStripe\View\Requirements;
 use InvalidArgumentException;
 
 /**

src/Control/Controller.php

Doc Comments +3 added lines, -3 removed lines

@@ -147,6 +147,7 @@ 
      * {@inheritdoc}
      *
      * Also set the URLParams
+     * @param HTTPRequest $request
      */
     public function setRequest($request)
     {
@@ -523,7 +524,7 @@ 
      *
      * @param array $params
      *
-     * @return string
+     * @return DBHTMLText
      */
     public function render($params = null)
     {
@@ -702,7 +703,7 @@ 
      * Tests whether a redirection has been requested. If redirect() has been called, it will return
      * the URL redirected to. Otherwise, it will return null.
      *
-     * @return null|string
+     * @return boolean
      */
     public function redirectedTo()
     {
@@ -736,7 +737,6 @@ 
      *
      * Caution: All parameters are expected to be URI-encoded already.
      *
-     * @param string|array $arg,.. One or more link segments, or list of link segments as an array
      * @return string
      */
     public static function join_links($arg = null)

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace SilverStripe\Control;
 
-use SilverStripe\Core\ClassInfo;
 use SilverStripe\Core\Object;
 use SilverStripe\Core\Injector\Injector;
 use SilverStripe\Dev\Debug;

src/Control/CookieJar.php

Doc Comments +1 added lines, -1 removed lines

@@ -151,7 +151,7 @@
      * @see http://uk3.php.net/manual/en/function.setcookie.php
      *
      * @param string $name The name of the cookie
-     * @param string|array $value The value for the cookie to hold
+     * @param false|string $value The value for the cookie to hold
      * @param int $expiry The number of days until expiry
      * @param string $path The path to save the cookie on (falls back to site base)
      * @param string $domain The domain to make the cookie available on

src/Control/RequestHandler.php

Doc Comments +1 added lines, -1 removed lines

@@ -296,7 +296,7 @@
      *
      * Must not raise HTTPResponse_Exceptions - instead it should return
      *
-     * @param $request
+     * @param HTTPRequest $request
      * @param $action
      * @return HTTPResponse
      */

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace SilverStripe\Control;
 
 use InvalidArgumentException;
-use SilverStripe\Core\ClassInfo;
 use SilverStripe\Core\Config\Config;
 use SilverStripe\Core\Object;
 use SilverStripe\Dev\Debug;

src/Control/RSS/RSSFeed.php

Doc Comments +1 added lines

@@ -248,6 +248,7 @@
      * via the standard template inclusion process.
      *
      * @param string
+     * @param string|null $template
      */
     public function setTemplate($template)
     {

src/Core/ClassInfo.php

Doc Comments +5 added lines

@@ -297,6 +297,9 @@ 
 
     private static $method_from_cache = array();
 
+    /**
+     * @param string $method
+     */
     public static function has_method_from($class, $method, $compclass)
     {
         $lClass = strtolower($class);
@@ -322,6 +325,8 @@ 
 
     /**
      * @deprecated 4.0..5.0
+     * @param string $candidateClass
+     * @param string $fieldName
      */
     public static function table_for_object_field($candidateClass, $fieldName)
     {