sminnee / silverstripe-framework

src/Control/HTTPResponse.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace SilverStripe\Control;
 
 use InvalidArgumentException;
-use Monolog\Formatter\FormatterInterface;
 use Monolog\Handler\HandlerInterface;
 use SilverStripe\Core\Convert;
 use SilverStripe\Core\Injector\Injectable;

src/Core/Injector/Injector.php

Doc Comments +4 added lines, -3 removed lines

@@ -371,7 +371,7 @@ 
      *
      * @param string $property
      *                the name of the property
-     * @param object $object
+     * @param string $object
      *                the object to be set
      * @return $this
      */
@@ -466,7 +466,7 @@ 
      *              The name of the service to update the definition for
      * @param string $property
      *              The name of the property to update.
-     * @param mixed $value
+     * @param string $value
      *              The value to set
      * @param boolean $append
      *              Whether to append (the default) when the property is an array
@@ -788,7 +788,7 @@ 
     /**
      * @deprecated 4.0.0:5.0.0 Use Injector::has() instead
      * @param $name
-     * @return string
+     * @return boolean
      */
     public function hasService($name)
     {
@@ -993,6 +993,7 @@ 
      *
      * @param string $name
      * @param mixed $argument,... arguments to pass to the constructor
+     * @param string $argument
      * @return mixed A new instance of the specified object
      */
     public function create($name, $argument = null)

tests/php/Forms/ValidatorTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -19,7 +19,7 @@
     /**
      * Common method for setting up form, since that will always be a dependency for the validator.
      *
-     * @param    array $fieldNames
+     * @param    string[] $fieldNames
      * @return    Form
      */
     protected function getForm(array $fieldNames = array())

tests/php/Logging/HTTPOutputHandlerTest.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace SilverStripe\Logging\Tests;
 
 use Monolog\Handler\HandlerInterface;
-use PhpParser\Node\Scalar\MagicConst\Dir;
 use SilverStripe\Control\Director;
 use SilverStripe\Core\Injector\Injector;
 use SilverStripe\Dev\SapphireTest;

tests/php/Core/Manifest/ManifestFileFinderTest.php

Doc Comments +5 added lines

@@ -19,6 +19,11 @@
         parent::__construct();
     }
 
+    /**
+     * @param ManifestFileFinder $finder
+     * @param null|string $base
+     * @param string[] $expect
+     */
     public function assertFinderFinds($finder, $base, $expect, $message = null)
     {
         if (!$base) {