sminnee / silverstripe-framework

src/Control/Controller.php

Doc Comments +3 added lines, -3 removed lines

@@ -147,6 +147,7 @@ 
      * {@inheritdoc}
      *
      * Also set the URLParams
+     * @param HTTPRequest $request
      */
     public function setRequest($request)
     {
@@ -523,7 +524,7 @@ 
      *
      * @param array $params
      *
-     * @return string
+     * @return DBHTMLText
      */
     public function render($params = null)
     {
@@ -702,7 +703,7 @@ 
      * Tests whether a redirection has been requested. If redirect() has been called, it will return
      * the URL redirected to. Otherwise, it will return null.
      *
-     * @return null|string
+     * @return boolean
      */
     public function redirectedTo()
     {
@@ -736,7 +737,6 @@ 
      *
      * Caution: All parameters are expected to be URI-encoded already.
      *
-     * @param string|array $arg,.. One or more link segments, or list of link segments as an array
      * @return string
      */
     public static function join_links($arg = null)

src/Control/CookieJar.php

Doc Comments +1 added lines, -1 removed lines

@@ -151,7 +151,7 @@
      * @see http://uk3.php.net/manual/en/function.setcookie.php
      *
      * @param string $name The name of the cookie
-     * @param string|array $value The value for the cookie to hold
+     * @param false|string $value The value for the cookie to hold
      * @param int $expiry The number of days until expiry
      * @param string $path The path to save the cookie on (falls back to site base)
      * @param string $domain The domain to make the cookie available on

src/Control/RequestHandler.php

Doc Comments +1 added lines, -1 removed lines

@@ -296,7 +296,7 @@
      *
      * Must not raise HTTPResponse_Exceptions - instead it should return
      *
-     * @param $request
+     * @param HTTPRequest $request
      * @param $action
      * @return HTTPResponse
      */

src/Control/RSS/RSSFeed.php

Doc Comments +1 added lines

@@ -248,6 +248,7 @@
      * via the standard template inclusion process.
      *
      * @param string
+     * @param string|null $template
      */
     public function setTemplate($template)
     {

src/Core/ClassInfo.php

Doc Comments +5 added lines

@@ -297,6 +297,9 @@ 
 
     private static $method_from_cache = array();
 
+    /**
+     * @param string $method
+     */
     public static function has_method_from($class, $method, $compclass)
     {
         $lClass = strtolower($class);
@@ -322,6 +325,8 @@ 
 
     /**
      * @deprecated 4.0..5.0
+     * @param string $candidateClass
+     * @param string $fieldName
      */
     public static function table_for_object_field($candidateClass, $fieldName)
     {

src/Core/CustomMethods.php

Doc Comments +1 added lines, -1 removed lines

@@ -152,7 +152,7 @@
     /**
      * Get meta-data details on a named method
      *
-     * @param array $method
+     * @param string $method
      * @return array List of custom method details, if defined for this method
      */
     protected function getExtraMethodConfig($method)

src/Core/Startup/ErrorControlChain.php

Doc Comments +2 added lines, -2 removed lines

@@ -106,7 +106,7 @@ 
     /**
      * Get value of display_errors ini value
      *
-     * @return mixed
+     * @return string
      */
     protected function getDisplayErrors()
     {
@@ -117,7 +117,7 @@ 
      * Add this callback to the chain of callbacks to call along with the state
      * that $error must be in this point in the chain for the callback to be called
      *
-     * @param $callback - The callback to call
+     * @param callable $callback - The callback to call
      * @param $onErrorState - false if only call if no errors yet, true if only call if already errors, null for either
      * @return $this
      */

src/Core/Startup/ParameterConfirmationToken.php

Doc Comments +4 added lines, -1 removed lines

@@ -38,6 +38,9 @@ 
      */
     protected $token = null;
 
+    /**
+     * @param string $token
+     */
     protected function pathForToken($token)
     {
         return TEMP_FOLDER.'/token_'.preg_replace('/[^a-z0-9]+/', '', $token);
@@ -247,7 +250,7 @@ 
      * Given a list of token names, suppress all tokens that have not been validated, and
      * return the non-validated token with the highest priority
      *
-     * @param array $keys List of token keys in ascending priority (low to high)
+     * @param string[] $keys List of token keys in ascending priority (low to high)
      * @return ParameterConfirmationToken The token container for the unvalidated $key given with the highest priority
      */
     public static function prepare_tokens($keys)

src/Dev/Backtrace.php

Doc Comments +1 added lines, -1 removed lines

@@ -132,7 +132,7 @@
      * @param mixed $returnVal
      * @param bool $ignoreAjax
      * @param array $ignoredFunctions
-     * @return mixed
+     * @return string|null
      */
     public static function backtrace($returnVal = false, $ignoreAjax = false, $ignoredFunctions = null)
     {