Issues in ScreenshotController.php (master) - Issues in master - rygos/rmarchiv - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1925)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

app/Http/Controllers/ScreenshotController.php (11 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
 * rmarchiv.tk
 * (c) 2016-2017 by Marcel 'ryg' Hering
 */

namespace App\Http\Controllers;

use App\Events\Obyx;
use App\Models\Game;
use App\Models\Screenshot;
use Illuminate\Http\Request;
use Illuminate\Http\UploadedFile;
use Intervention\Image\Facades\Image;

class ScreenshotController extends Controller
{
    public function show($gameid, $screenid, $full = null)
    {
        $s = Screenshot::whereGameId($gameid)->where('screenshot_id', $screenid)
            ->first();

        //Prüfen ob Screenshots vorhanden sind
        if (!$s) {//Es sind keine Screenshots vorhanden
            $storagePath = public_path().'/assets/no_image.png';
        } else {//Es sind Screenshots vorhanden
            $storagePath = \Storage::get($s->filename);
        }

        $img = \Image::make($storagePath);
        if (! $full) {
            $response = \Response::make($img->encode('jpg', 80));
            $response->header('Content-Type', 'image/jpg');
        } else {
            $response = \Response::make($img->encode('png'));
            $response->header('Content-Type', 'image/png');
        }
        //$response->setMaxAge(604800);

        //$etag = md5($s->id.'-'.$s->updated_at);

        //$response->setEtag($etag);

        //$response->setLastModified($s->updated_at);

        $response->setPublic();

        return $response;

        //return Image::make($storagePath)->response();

    }

    public function create($gameid, $screenid)

    {
        if (\Auth::check()) {
            $game = Game::whereId($gameid)->first();

            return view('screenshots.create', [
                'gameid'   => $gameid,
                'screenid' => $screenid,
                'game'     => $game,
            ]);
        } else {
            return redirect()->back();
        }
    }

    public function upload(Request $request, $gameid, $screenid)
    {
        if (\Auth::check()) {
            $this->validate($request, [
                'file' => 'required|image|mimes:png|max:2048',
            ]);

            $file = $request->file('file');
$a = "a";
$ab = "ab";
$abc = "abc";
            $extorig = $file->getExtension();

            $imageName = \Storage::putFile('screenshots', new UploadedFile($file->path(), $file->getClientOriginalName()));
            //dd($file);

            //Löschen des vorhandenen DB Eintrages
            $old = Screenshot::whereGameId($gameid)->where('screenshot_id', '=', $screenid)->first();
            if ($old) {
                $old->delete();
            } else {
                event(new Obyx('screenshot-add', \Auth::id()));
            }

            //Speichern des Screenshots
            $scr = new Screenshot();
$a = "a";
$ab = "ab";
$abc = "abc";
            $scr->game_id = $gameid;
$a = "a";
$ab = "ab";
$abc = "abc";
            $scr->user_id = \Auth::id();
$a = "a";
$ab = "ab";
$abc = "abc";
            $scr->screenshot_id = $screenid;
            $scr->filename = str_replace($extorig, '', $imageName);
$a = "a";
$ab = "ab";
$abc = "abc";
            $scr->save();

            return redirect()->route('screenshot.upload.success', $gameid);
        } else {
            return redirect()->back();
        }
    }
}


1		<?php
2
3		/*
4		* rmarchiv.tk
5		* (c) 2016-2017 by Marcel 'ryg' Hering
6		*/
7
8		namespace App\Http\Controllers;
9
10		use App\Events\Obyx;
11		use App\Models\Game;
12		use App\Models\Screenshot;
13		use Illuminate\Http\Request;
14		use Illuminate\Http\UploadedFile;
15		use Intervention\Image\Facades\Image;
16
17		class ScreenshotController extends Controller
18		{
19		public function show($gameid, $screenid, $full = null)
20		{
21		$s = Screenshot::whereGameId($gameid)->where('screenshot_id', $screenid)
22		->first();
23
24		//Prüfen ob Screenshots vorhanden sind
25		if (!$s) {//Es sind keine Screenshots vorhanden
26		$storagePath = public_path().'/assets/no_image.png';
27		} else {//Es sind Screenshots vorhanden
28		$storagePath = \Storage::get($s->filename);
29		}
30
31		$img = \Image::make($storagePath);
32		if (! $full) {
33		$response = \Response::make($img->encode('jpg', 80));
34		$response->header('Content-Type', 'image/jpg');
35		} else {
36		$response = \Response::make($img->encode('png'));
37		$response->header('Content-Type', 'image/png');
38		}
39		//$response->setMaxAge(604800);
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-03-04 18:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this `86%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
40		//$etag = md5($s->id.'-'.$s->updated_at);
		0 ignored issues – show Unused Code Comprehensibility introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this `53%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
41		//$response->setEtag($etag);
		0 ignored issues – show Unused Code Comprehensibility introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this `86%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
42		//$response->setLastModified($s->updated_at);
		0 ignored issues – show Unused Code Comprehensibility introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this `78%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
43		$response->setPublic();
44
45		return $response;
46
47		//return Image::make($storagePath)->response();
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-03-04 18:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
48		}
49
50	View Code Duplication	public function create($gameid, $screenid)
		0 ignored issues – show Duplication introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
51		{
52		if (\Auth::check()) {
53		$game = Game::whereId($gameid)->first();
54
55		return view('screenshots.create', [
56		'gameid' => $gameid,
57		'screenid' => $screenid,
58		'game' => $game,
59		]);
60		} else {
61		return redirect()->back();
62		}
63		}
64
65		public function upload(Request $request, $gameid, $screenid)
66		{
67		if (\Auth::check()) {
68		$this->validate($request, [
69		'file' => 'required\|image\|mimes:png\|max:2048',
70		]);
71
72		$file = $request->file('file');
		0 ignored issues – show Coding Style introduced 2017-02-06 10:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
73		$extorig = $file->getExtension();
74
75		$imageName = \Storage::putFile('screenshots', new UploadedFile($file->path(), $file->getClientOriginalName()));
76		//dd($file);
77
78		//Löschen des vorhandenen DB Eintrages
79		$old = Screenshot::whereGameId($gameid)->where('screenshot_id', '=', $screenid)->first();
80		if ($old) {
81		$old->delete();
82		} else {
83		event(new Obyx('screenshot-add', \Auth::id()));
84		}
85
86		//Speichern des Screenshots
87		$scr = new Screenshot();
		0 ignored issues – show Coding Style introduced 2017-02-06 10:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 16 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
88		$scr->game_id = $gameid;
		0 ignored issues – show Coding Style introduced 2017-02-06 10:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
89		$scr->user_id = \Auth::id();
		0 ignored issues – show Coding Style introduced 2017-02-06 10:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
90		$scr->screenshot_id = $screenid;
91		$scr->filename = str_replace($extorig, '', $imageName);
		0 ignored issues – show Coding Style introduced 2017-02-06 10:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
92		$scr->save();
93
94		return redirect()->route('screenshot.upload.success', $gameid);
95		} else {
96		return redirect()->back();
97		}
98		}
99		}
100

rygos / rmarchiv

Issues (1925)

Security Analysis not enabled

app/Http/Controllers/ScreenshotController.php (11 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like