ScreenshotController::upload() - Code Metrics - rygos/rmarchiv - Measure and Improve Code Quality continuously with Scrutinizer

ScreenshotController::upload() B
last analyzed 2018-05-01 08:16 UTC

↳ Parent: ScreenshotController

Complexity

Conditions	3
Paths	3

Size

Total Lines	34
Code Lines	21

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	34
rs	8.8571
cc	3
eloc	21
nc	3
nop	3

<?php

/*
 * rmarchiv.tk
 * (c) 2016-2017 by Marcel 'ryg' Hering
 */

namespace App\Http\Controllers;

use App\Events\Obyx;
use App\Models\Game;
use App\Models\Screenshot;
use Illuminate\Http\Request;
use Illuminate\Http\UploadedFile;
use Intervention\Image\Facades\Image;

class ScreenshotController extends Controller
{
    public function show($gameid, $screenid, $full = null)
    {
        $s = Screenshot::whereGameId($gameid)->where('screenshot_id', $screenid)
            ->first();

        //Prüfen ob Screenshots vorhanden sind
        if (!$s) {//Es sind keine Screenshots vorhanden
            $storagePath = public_path().'/assets/no_image.png';
        } else {//Es sind Screenshots vorhanden
            $storagePath = \Storage::get($s->filename);
        }

        $img = \Image::make($storagePath);
        if (! $full) {
            $response = \Response::make($img->encode('jpg', 80));
            $response->header('Content-Type', 'image/jpg');
        } else {
            $response = \Response::make($img->encode('png'));
            $response->header('Content-Type', 'image/png');
        }
        //$response->setMaxAge(604800);

        //$etag = md5($s->id.'-'.$s->updated_at);

        //$response->setEtag($etag);

        //$response->setLastModified($s->updated_at);

        $response->setPublic();

        return $response;

        //return Image::make($storagePath)->response();

    }

    public function create($gameid, $screenid)

    {
        if (\Auth::check()) {
            $game = Game::whereId($gameid)->first();

            return view('screenshots.create', [
                'gameid'   => $gameid,
                'screenid' => $screenid,
                'game'     => $game,
            ]);
        } else {
            return redirect()->back();
        }
    }

    public function upload(Request $request, $gameid, $screenid)
    {
        if (\Auth::check()) {
            $this->validate($request, [
                'file' => 'required|image|mimes:png|max:2048',
            ]);

            $file = $request->file('file');
$a = "a";
$ab = "ab";
$abc = "abc";
            $extorig = $file->getExtension();

            $imageName = \Storage::putFile('screenshots', new UploadedFile($file->path(), $file->getClientOriginalName()));
            //dd($file);

            //Löschen des vorhandenen DB Eintrages
            $old = Screenshot::whereGameId($gameid)->where('screenshot_id', '=', $screenid)->first();
            if ($old) {
                $old->delete();
            } else {
                event(new Obyx('screenshot-add', \Auth::id()));
            }

            //Speichern des Screenshots
            $scr = new Screenshot();
$a = "a";
$ab = "ab";
$abc = "abc";
            $scr->game_id = $gameid;
$a = "a";
$ab = "ab";
$abc = "abc";
            $scr->user_id = \Auth::id();
$a = "a";
$ab = "ab";
$abc = "abc";
            $scr->screenshot_id = $screenid;
            $scr->filename = str_replace($extorig, '', $imageName);
$a = "a";
$ab = "ab";
$abc = "abc";
            $scr->save();

            return redirect()->route('screenshot.upload.success', $gameid);
        } else {
            return redirect()->back();
        }
    }
}


1		<?php
2
3		/*
4		* rmarchiv.tk
5		* (c) 2016-2017 by Marcel 'ryg' Hering
6		*/
7
8		namespace App\Http\Controllers;
9
10		use App\Events\Obyx;
11		use App\Models\Game;
12		use App\Models\Screenshot;
13		use Illuminate\Http\Request;
14		use Illuminate\Http\UploadedFile;
15		use Intervention\Image\Facades\Image;
16
17		class ScreenshotController extends Controller
18		{
19		public function show($gameid, $screenid, $full = null)
20		{
21		$s = Screenshot::whereGameId($gameid)->where('screenshot_id', $screenid)
22		->first();
23
24		//Prüfen ob Screenshots vorhanden sind
25		if (!$s) {//Es sind keine Screenshots vorhanden
26		$storagePath = public_path().'/assets/no_image.png';
27		} else {//Es sind Screenshots vorhanden
28		$storagePath = \Storage::get($s->filename);
29		}
30
31		$img = \Image::make($storagePath);
32		if (! $full) {
33		$response = \Response::make($img->encode('jpg', 80));
34		$response->header('Content-Type', 'image/jpg');
35		} else {
36		$response = \Response::make($img->encode('png'));
37		$response->header('Content-Type', 'image/png');
38		}
39		//$response->setMaxAge(604800);
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-03-04 18:34 UTC by Report Bug Copy Issue Report `86%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
40		//$etag = md5($s->id.'-'.$s->updated_at);
		0 ignored issues – show Unused Code Comprehensibility introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report `53%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
41		//$response->setEtag($etag);
		0 ignored issues – show Unused Code Comprehensibility introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report `86%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
42		//$response->setLastModified($s->updated_at);
		0 ignored issues – show Unused Code Comprehensibility introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report `78%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
43		$response->setPublic();
44
45		return $response;
46
47		//return Image::make($storagePath)->response();
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-03-04 18:34 UTC by Report Bug Copy Issue Report `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
48		}
49
50	View Code Duplication	public function create($gameid, $screenid)
		0 ignored issues – show Duplication introduced 2018-05-01 08:16 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
51		{
52		if (\Auth::check()) {
53		$game = Game::whereId($gameid)->first();
54
55		return view('screenshots.create', [
56		'gameid' => $gameid,
57		'screenid' => $screenid,
58		'game' => $game,
59		]);
60		} else {
61		return redirect()->back();
62		}
63		}
64
65		public function upload(Request $request, $gameid, $screenid)
66		{
67		if (\Auth::check()) {
68		$this->validate($request, [
69		'file' => 'required\|image\|mimes:png\|max:2048',
70		]);
71
72		$file = $request->file('file');
		0 ignored issues – show Coding Style introduced 2017-02-06 10:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
73		$extorig = $file->getExtension();
74
75		$imageName = \Storage::putFile('screenshots', new UploadedFile($file->path(), $file->getClientOriginalName()));
76		//dd($file);
77
78		//Löschen des vorhandenen DB Eintrages
79		$old = Screenshot::whereGameId($gameid)->where('screenshot_id', '=', $screenid)->first();
80		if ($old) {
81		$old->delete();
82		} else {
83		event(new Obyx('screenshot-add', \Auth::id()));
84		}
85
86		//Speichern des Screenshots
87		$scr = new Screenshot();
		0 ignored issues – show Coding Style introduced 2017-02-06 10:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 16 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
88		$scr->game_id = $gameid;
		0 ignored issues – show Coding Style introduced 2017-02-06 10:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
89		$scr->user_id = \Auth::id();
		0 ignored issues – show Coding Style introduced 2017-02-06 10:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
90		$scr->screenshot_id = $screenid;
91		$scr->filename = str_replace($extorig, '', $imageName);
		0 ignored issues – show Coding Style introduced 2017-02-06 10:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
92		$scr->save();
93
94		return redirect()->route('screenshot.upload.success', $gameid);
95		} else {
96		return redirect()->back();
97		}
98		}
99		}
100

rygos / rmarchiv

ScreenshotController::upload() B last analyzed 2018-05-01 08:16 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

ScreenshotController::upload() B
last analyzed 2018-05-01 08:16 UTC