App\Http\Controllers\ScreenshotController

Complexity

Total Complexity

8

Size/Duplication

Total Lines	83
Duplicated Lines	16.87 %

Coupling/Cohesion

Components	0
Dependencies	9

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
B	show()	0	30	3
A	create()	14	14	2
B	upload()	0	34	3

<?php

/*
 * rmarchiv.tk
 * (c) 2016-2017 by Marcel 'ryg' Hering
 */

namespace App\Http\Controllers;

use App\Events\Obyx;
use App\Models\Game;
use App\Models\Screenshot;
use Illuminate\Http\Request;
use Illuminate\Http\UploadedFile;
use Intervention\Image\Facades\Image;

class ScreenshotController extends Controller
{
    public function show($gameid, $screenid, $full = null)
    {
        $s = Screenshot::whereGameId($gameid)->where('screenshot_id', $screenid)
            ->first();

        //Prüfen ob Screenshots vorhanden sind
        if (!$s) {//Es sind keine Screenshots vorhanden
            $storagePath = public_path().'/assets/no_image.png';
        } else {//Es sind Screenshots vorhanden
            $storagePath = \Storage::get($s->filename);
        }

        $img = \Image::make($storagePath);
        if (! $full) {
            $response = \Response::make($img->encode('jpg', 80));
            $response->header('Content-Type', 'image/jpg');
        } else {
            $response = \Response::make($img->encode('png'));
            $response->header('Content-Type', 'image/png');
        }
        //$response->setMaxAge(604800);

86% of this comment could be valid code. Did you maybe forget this after debugging?

        //$etag = md5($s->id.'-'.$s->updated_at);

53% of this comment could be valid code. Did you maybe forget this after debugging?

        //$response->setEtag($etag);

86% of this comment could be valid code. Did you maybe forget this after debugging?

        //$response->setLastModified($s->updated_at);

78% of this comment could be valid code. Did you maybe forget this after debugging?

        $response->setPublic();

        return $response;

        //return Image::make($storagePath)->response();

70% of this comment could be valid code. Did you maybe forget this after debugging?

    }

    public function create($gameid, $screenid)

This method seems to be duplicated in your project.

    {
        if (\Auth::check()) {
            $game = Game::whereId($gameid)->first();

            return view('screenshots.create', [
                'gameid'   => $gameid,
                'screenid' => $screenid,
                'game'     => $game,
            ]);
        } else {
            return redirect()->back();
        }
    }

    public function upload(Request $request, $gameid, $screenid)
    {
        if (\Auth::check()) {
            $this->validate($request, [
                'file' => 'required|image|mimes:png|max:2048',
            ]);

            $file = $request->file('file');

Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space

            $extorig = $file->getExtension();

            $imageName = \Storage::putFile('screenshots', new UploadedFile($file->path(), $file->getClientOriginalName()));
            //dd($file);

            //Löschen des vorhandenen DB Eintrages
            $old = Screenshot::whereGameId($gameid)->where('screenshot_id', '=', $screenid)->first();
            if ($old) {
                $old->delete();
            } else {
                event(new Obyx('screenshot-add', \Auth::id()));
            }

            //Speichern des Screenshots
            $scr = new Screenshot();

Equals sign not aligned with surrounding assignments; expected 16 spaces but found 1 space

            $scr->game_id = $gameid;

Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space

            $scr->user_id = \Auth::id();

Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space

            $scr->screenshot_id = $screenid;
            $scr->filename = str_replace($extorig, '', $imageName);

Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space

            $scr->save();

            return redirect()->route('screenshot.upload.success', $gameid);
        } else {
            return redirect()->back();
        }
    }
}