Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

GitHub Access Token became invalid

It seems like the GitHub access token used for retrieving details about this repository from GitHub became invalid. This might prevent certain types of inspections from being run (in particular, everything related to pull requests).
Please ask an admin of your repository to re-new the access token on this website.
Passed
Pull Request — master (#874)
by Sebastian
07:13 queued 03:58
created
Classes/Controller/ListViewController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@
 block discarded – undo
75 75
         // extract collection(s) from collection parameter
76 76
         $collection = null;
77 77
         if ($this->searchParams['collection']) {
78
-            foreach(explode(',', $this->searchParams['collection']) as $collectionEntry) {
78
+            foreach (explode(',', $this->searchParams['collection']) as $collectionEntry) {
79 79
                 $collection[] = $this->collectionRepository->findByUid($collectionEntry);
80 80
             }
81 81
         }
Please login to merge, or discard this patch.
Classes/Controller/SearchController.php 2 patches
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -258,8 +258,7 @@
 block discarded – undo
258 258
                 // check for virtual collections query string
259 259
                 if($collectionEntry->getIndexSearch()) {
260 260
                     $virtualCollectionsQueryString .= empty($virtualCollectionsQueryString) ? '(' . $collectionEntry->getIndexSearch() . ')' : ' OR ('. $collectionEntry->getIndexSearch() . ')' ;
261
-                }
262
-                else {
261
+                } else {
263 262
                     $collectionsQueryString .= empty($collectionsQueryString) ? '"' . $collectionEntry->getIndexName() . '"' : ' OR "' . $collectionEntry->getIndexName() . '"';
264 263
                 }
265 264
             }
Please login to merge, or discard this patch.
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -108,13 +108,13 @@  discard block
 block discarded – undo
108 108
         }
109 109
 
110 110
         // sanitize date search input
111
-        if(empty($this->searchParams['dateFrom']) && !empty($this->searchParams['dateTo'])) {
111
+        if (empty($this->searchParams['dateFrom']) && !empty($this->searchParams['dateTo'])) {
112 112
             $this->searchParams['dateFrom'] = '*';
113 113
         }
114
-        if(empty($this->searchParams['dateTo']) && !empty($this->searchParams['dateFrom'])) {
114
+        if (empty($this->searchParams['dateTo']) && !empty($this->searchParams['dateFrom'])) {
115 115
             $this->searchParams['dateTo'] = 'NOW';
116 116
         }
117
-        if($this->searchParams['dateFrom'] > $this->searchParams['dateTo']) {
117
+        if ($this->searchParams['dateFrom'] > $this->searchParams['dateTo']) {
118 118
             $tmpDate = $this->searchParams['dateFrom'];
119 119
             $this->searchParams['dateFrom'] = $this->searchParams['dateTo'];
120 120
             $this->searchParams['dateTo'] = $tmpDate;
@@ -259,7 +259,7 @@  discard block
 block discarded – undo
259 259
         // extract collections from collection parameter
260 260
         $collection = null;
261 261
         if ($this->searchParams['collection']) {
262
-            foreach(explode(',', $this->searchParams['collection']) as $collectionEntry) {
262
+            foreach (explode(',', $this->searchParams['collection']) as $collectionEntry) {
263 263
                 $collection[] = $this->collectionRepository->findByUid($collectionEntry);
264 264
             }
265 265
             
@@ -269,8 +269,8 @@  discard block
 block discarded – undo
269 269
             $virtualCollectionsQueryString = '';
270 270
             foreach ($collection as $collectionEntry) {
271 271
                 // check for virtual collections query string
272
-                if($collectionEntry->getIndexSearch()) {
273
-                    $virtualCollectionsQueryString .= empty($virtualCollectionsQueryString) ? '(' . $collectionEntry->getIndexSearch() . ')' : ' OR ('. $collectionEntry->getIndexSearch() . ')' ;
272
+                if ($collectionEntry->getIndexSearch()) {
273
+                    $virtualCollectionsQueryString .= empty($virtualCollectionsQueryString) ? '(' . $collectionEntry->getIndexSearch() . ')' : ' OR (' . $collectionEntry->getIndexSearch() . ')';
274 274
                 }
275 275
                 else {
276 276
                     $collectionsQueryString .= empty($collectionsQueryString) ? '"' . $collectionEntry->getIndexName() . '"' : ' OR "' . $collectionEntry->getIndexName() . '"';
@@ -278,8 +278,8 @@  discard block
 block discarded – undo
278 278
             }
279 279
             
280 280
             // distinguish between simple collection browsing and actual searching within the collection(s)
281
-            if(!empty($collectionsQueryString)) {
282
-                if(empty($searchParams['query'])) {
281
+            if (!empty($collectionsQueryString)) {
282
+                if (empty($searchParams['query'])) {
283 283
                     $collectionsQueryString = '(collection_faceting:(' . $collectionsQueryString . ') AND toplevel:true AND partof:0)';
284 284
                 } else {
285 285
                     $collectionsQueryString = '(collection_faceting:(' . $collectionsQueryString . '))';
@@ -287,7 +287,7 @@  discard block
 block discarded – undo
287 287
             }
288 288
 
289 289
             // virtual collections might query documents that are neither toplevel:true nor partof:0 and need to be searched separatly
290
-            if(!empty($virtualCollectionsQueryString)) {
290
+            if (!empty($virtualCollectionsQueryString)) {
291 291
                 $virtualCollectionsQueryString = '(' . $virtualCollectionsQueryString . ')';
292 292
             }
293 293
 
Please login to merge, or discard this patch.
Classes/Common/SolrSearch.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -212,7 +212,7 @@  discard block
 block discarded – undo
212 212
         // Add filter query for date search
213 213
         if (!empty($this->searchParams['dateFrom']) && !empty($this->searchParams['dateTo'])) {
214 214
             // combine dateFrom and dateTo into range search
215
-            $params['filterquery'][]['query'] = '{!join from=' . $fields['uid'] . ' to=' . $fields['uid'] . '}'. $fields['date'] . ':[' . $this->searchParams['dateFrom'] . ' TO ' . $this->searchParams['dateTo'] . ']';
215
+            $params['filterquery'][]['query'] = '{!join from=' . $fields['uid'] . ' to=' . $fields['uid'] . '}' . $fields['date'] . ':[' . $this->searchParams['dateFrom'] . ' TO ' . $this->searchParams['dateTo'] . ']';
216 216
         }
217 217
 
218 218
         // Add filter query for faceting.
@@ -243,16 +243,16 @@  discard block
 block discarded – undo
243 243
             $virtualCollectionsQueryString = '';
244 244
             foreach ($this->collection as $collectionEntry) {
245 245
                 // check for virtual collections query string
246
-                if($collectionEntry->getIndexSearch()) {
247
-                    $virtualCollectionsQueryString .= empty($virtualCollectionsQueryString) ? '(' . $collectionEntry->getIndexSearch() . ')' : ' OR ('. $collectionEntry->getIndexSearch() . ')' ;
246
+                if ($collectionEntry->getIndexSearch()) {
247
+                    $virtualCollectionsQueryString .= empty($virtualCollectionsQueryString) ? '(' . $collectionEntry->getIndexSearch() . ')' : ' OR (' . $collectionEntry->getIndexSearch() . ')';
248 248
                 } else {
249 249
                     $collectionsQueryString .= empty($collectionsQueryString) ? '"' . $collectionEntry->getIndexName() . '"' : ' OR "' . $collectionEntry->getIndexName() . '"';
250 250
                 }
251 251
             }
252 252
             
253 253
             // distinguish between simple collection browsing and actual searching within the collection(s)
254
-            if(!empty($collectionsQueryString)) {
255
-                if(empty($query)) {
254
+            if (!empty($collectionsQueryString)) {
255
+                if (empty($query)) {
256 256
                     $collectionsQueryString = '(collection_faceting:(' . $collectionsQueryString . ') AND toplevel:true AND partof:0)';
257 257
                 } else {
258 258
                     $collectionsQueryString = '(collection_faceting:(' . $collectionsQueryString . '))';
@@ -260,7 +260,7 @@  discard block
 block discarded – undo
260 260
             }
261 261
 
262 262
             // virtual collections might query documents that are neither toplevel:true nor partof:0 and need to be searched separatly
263
-            if(!empty($virtualCollectionsQueryString)) {
263
+            if (!empty($virtualCollectionsQueryString)) {
264 264
                 $virtualCollectionsQueryString = '(' . $virtualCollectionsQueryString . ')';
265 265
             }
266 266
 
@@ -337,8 +337,8 @@  discard block
 block discarded – undo
337 337
                 }
338 338
                 if ($documents[$doc['uid']]) {
339 339
                     // translate language code if applicable
340
-                    if($doc['metadata']['language']) {
341
-                        foreach($doc['metadata']['language'] as $indexName => $language) {
340
+                    if ($doc['metadata']['language']) {
341
+                        foreach ($doc['metadata']['language'] as $indexName => $language) {
342 342
                             $doc['metadata']['language'][$indexName] = Helper::getLanguageName($doc['metadata']['language'][$indexName]);
343 343
                         }
344 344
                     }
@@ -438,8 +438,8 @@  discard block
 block discarded – undo
438 438
 
439 439
         foreach ($result['documents'] as $doc) {
440 440
             // translate language code if applicable
441
-            if($doc['metadata']['language']) {
442
-                foreach($doc['metadata']['language'] as $indexName => $language) {
441
+            if ($doc['metadata']['language']) {
442
+                foreach ($doc['metadata']['language'] as $indexName => $language) {
443 443
                     $doc['metadata']['language'][$indexName] = Helper::getLanguageName($doc['metadata']['language'][$indexName]);
444 444
                 }
445 445
             }
Please login to merge, or discard this patch.