We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
@@ -73,7 +73,8 @@ |
||
73 | 73 | /** |
74 | 74 | * @param string $endpoint the shortname of the endpoint |
75 | 75 | */ |
76 | - public function setEndpoint($endpoint) { |
|
76 | + public function setEndpoint($endpoint) |
|
77 | + { |
|
77 | 78 | $this->endpoint = $endpoint; |
78 | 79 | } |
79 | 80 |
@@ -71,7 +71,8 @@ discard block |
||
71 | 71 | * |
72 | 72 | * @return void |
73 | 73 | */ |
74 | - private function getAuthors() { |
|
74 | + private function getAuthors() |
|
75 | + { |
|
75 | 76 | $authors = $this->xml->xpath('./mods:name[./mods:role/mods:roleTerm[@type="code" and @authority="marcrelator"]="aut"]'); |
76 | 77 | |
77 | 78 | // Get "author" and "author_sorting" again if that was too sophisticated. |
@@ -93,7 +94,8 @@ discard block |
||
93 | 94 | } |
94 | 95 | } |
95 | 96 | |
96 | - private function getAuthorFromOrcidApi($orcidId, $authors, $i) { |
|
97 | + private function getAuthorFromOrcidApi($orcidId, $authors, $i) |
|
98 | + { |
|
97 | 99 | $profile = new OrcidProfile($orcidId); |
98 | 100 | $name = $profile->getFullName(); |
99 | 101 | if (!empty($name)) { |
@@ -107,7 +109,8 @@ discard block |
||
107 | 109 | } |
108 | 110 | } |
109 | 111 | |
110 | - private function getAuthorFromXml($authors, $i) { |
|
112 | + private function getAuthorFromXml($authors, $i) |
|
113 | + { |
|
111 | 114 | $this->getAuthorFromXmlDisplayForm($authors, $i); |
112 | 115 | |
113 | 116 | $nameParts = $authors[$i]->xpath('./mods:namePart'); |
@@ -150,7 +153,8 @@ discard block |
||
150 | 153 | } |
151 | 154 | } |
152 | 155 | |
153 | - private function getAuthorFromXmlDisplayForm($authors, $i) { |
|
156 | + private function getAuthorFromXmlDisplayForm($authors, $i) |
|
157 | + { |
|
154 | 158 | $displayForm = $authors[$i]->xpath('./mods:displayForm'); |
155 | 159 | if ($displayForm) { |
156 | 160 | $this->metadata['author'][$i] = (string) $displayForm[0]; |
@@ -164,7 +168,8 @@ discard block |
||
164 | 168 | * |
165 | 169 | * @return void |
166 | 170 | */ |
167 | - private function getHolders() { |
|
171 | + private function getHolders() |
|
172 | + { |
|
168 | 173 | $holders = $this->xml->xpath('./mods:name[./mods:role/mods:roleTerm[@type="code" and @authority="marcrelator"]="prv"]'); |
169 | 174 | |
170 | 175 | if (!empty($holders)) { |
@@ -181,7 +186,8 @@ discard block |
||
181 | 186 | } |
182 | 187 | } |
183 | 188 | |
184 | - private function getHolderFromViafApi($viafId, $holders, $i) { |
|
189 | + private function getHolderFromViafApi($viafId, $holders, $i) |
|
190 | + { |
|
185 | 191 | $profile = new ViafProfile($viafId); |
186 | 192 | $name = $profile->getFullName(); |
187 | 193 | if (!empty($name)) { |
@@ -195,7 +201,8 @@ discard block |
||
195 | 201 | } |
196 | 202 | } |
197 | 203 | |
198 | - private function getHolderFromXml($holders, $i) { |
|
204 | + private function getHolderFromXml($holders, $i) |
|
205 | + { |
|
199 | 206 | $this->getHolderFromXmlDisplayForm($holders, $i); |
200 | 207 | // Append "valueURI" to name using Unicode unit separator. |
201 | 208 | if (isset($holders[$i]['valueURI'])) { |
@@ -203,7 +210,8 @@ discard block |
||
203 | 210 | } |
204 | 211 | } |
205 | 212 | |
206 | - private function getHolderFromXmlDisplayForm($holders, $i) { |
|
213 | + private function getHolderFromXmlDisplayForm($holders, $i) |
|
214 | + { |
|
207 | 215 | // Check if there is a display form. |
208 | 216 | $displayForm = $holders[$i]->xpath('./mods:displayForm'); |
209 | 217 | if ($displayForm) { |
@@ -218,7 +226,8 @@ discard block |
||
218 | 226 | * |
219 | 227 | * @return void |
220 | 228 | */ |
221 | - private function getPlaces() { |
|
229 | + private function getPlaces() |
|
230 | + { |
|
222 | 231 | $places = $this->xml->xpath('./mods:originInfo[not(./mods:edition="[Electronic ed.]")]/mods:place/mods:placeTerm'); |
223 | 232 | // Get "place" and "place_sorting" again if that was to sophisticated. |
224 | 233 | if (empty($places)) { |
@@ -242,7 +251,8 @@ discard block |
||
242 | 251 | * |
243 | 252 | * @return void |
244 | 253 | */ |
245 | - private function getYears() { |
|
254 | + private function getYears() |
|
255 | + { |
|
246 | 256 | // Get "year_sorting". |
247 | 257 | if (($years_sorting = $this->xml->xpath('./mods:originInfo[not(./mods:edition="[Electronic ed.]")]/mods:dateOther[@type="order" and @encoding="w3cdtf"]'))) { |
248 | 258 | foreach ($years_sorting as $year_sorting) { |