Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

GitHub Access Token became invalid

It seems like the GitHub access token used for retrieving details about this repository from GitHub became invalid. This might prevent certain types of inspections from being run (in particular, everything related to pull requests).
Please ask an admin of your repository to re-new the access token on this website.
Passed
Pull Request — master (#376)
by Sebastian
03:43
created
Classes/Plugin/Metadata.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
                 $iiifwrap['value.']['required'] = 1;
168 168
                 $iiifwrap['value.']['wrap'] = '<dd>|</dd>';
169 169
             }
170
-            $iiifLink=[];
170
+            $iiifLink = [];
171 171
             $iiifLink['key.']['wrap'] = '<dt>|</dt>';
172 172
             $iiifLink['value.']['required'] = 1;
173 173
             $iiifLink['value.']['setContentToCurrent'] = 1;
@@ -234,7 +234,7 @@  discard block
 block discarded – undo
234 234
                 ->where(
235 235
                     $queryBuilder->expr()->andX(
236 236
                         $queryBuilder->expr()->orX(
237
-                            $queryBuilder->expr()->in('tx_dlf_metadata.sys_language_uid', array(-1, 0)),
237
+                            $queryBuilder->expr()->in('tx_dlf_metadata.sys_language_uid', array (-1, 0)),
238 238
                             $queryBuilder->expr()->eq('tx_dlf_metadata.sys_language_uid', $GLOBALS['TSFE']->sys_language_uid)
239 239
                         ),
240 240
                         $queryBuilder->expr()->eq('tx_dlf_metadata.l18n_parent', 0)
Please login to merge, or discard this patch.
Classes/Plugin/Search.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -558,7 +558,7 @@
 block discarded – undo
558 558
         $results = $solr->service->select($selectQuery);
559 559
         $facet = $results->getFacetSet();
560 560
 
561
-        $facetCollectionArray = array();
561
+        $facetCollectionArray = array ();
562 562
 
563 563
         // replace everything expect numbers and comma
564 564
         $facetCollections = preg_replace('/[^0-9,]/', '', $this->conf['facetCollections']);
Please login to merge, or discard this patch.
Classes/Plugin/OaiPmh.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -741,7 +741,7 @@
 block discarded – undo
741 741
             )
742 742
             ->from('tx_dlf_collections')
743 743
             ->where(
744
-                $queryBuilder->expr()->in('tx_dlf_collections.sys_language_uid', array(-1, 0)),
744
+                $queryBuilder->expr()->in('tx_dlf_collections.sys_language_uid', array (-1, 0)),
745 745
                 $queryBuilder->expr()->eq('tx_dlf_collections.pid', intval($this->conf['pages'])),
746 746
                 $queryBuilder->expr()->neq('tx_dlf_collections.oai_name', ''),
747 747
                 $where,
Please login to merge, or discard this patch.
Classes/Module/NewTenant.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -268,7 +268,7 @@
 block discarded – undo
268 268
                 )
269 269
                 ->from('tx_dlf_solrcores')
270 270
                 ->where(
271
-                    $queryBuilder->expr()->in('tx_dlf_solrcores.pid', array(intval($this->id), 0)),
271
+                    $queryBuilder->expr()->in('tx_dlf_solrcores.pid', array (intval($this->id), 0)),
272 272
                     Helper::whereExpression('tx_dlf_solrcores')
273 273
                 )
274 274
                 ->execute();
Please login to merge, or discard this patch.
Classes/Common/Solr.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
                 ->where(
143 143
                     $queryBuilder->expr()->eq('tx_dlf_metadata.index_indexed', 1),
144 144
                     $queryBuilder->expr()->orX(
145
-                        $queryBuilder->expr()->in('tx_dlf_metadata.sys_language_uid', array(-1, 0)),
145
+                        $queryBuilder->expr()->in('tx_dlf_metadata.sys_language_uid', array (-1, 0)),
146 146
                         $queryBuilder->expr()->eq('tx_dlf_metadata.l18n_parent', 0)
147 147
                     ),
148 148
                     Helper::whereExpression('tx_dlf_metadata')
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
                 ->execute();
151 151
 
152 152
             while ($resArray = $result->fetch()) {
153
-                $fields[] = $resArray[0] . '_' . ($resArray[1] ? 't' : 'u') . ($resArray[2] ? 's' : 'u') . 'i';
153
+                $fields[] = $resArray[0].'_'.($resArray[1] ? 't' : 'u').($resArray[2] ? 's' : 'u').'i';
154 154
             }
155 155
 
156 156
             // Check if queried field is valid.
Please login to merge, or discard this patch.
Classes/Common/Helper.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -789,11 +789,11 @@  discard block
 block discarded – undo
789 789
         if (empty($labels[$table][$pid][$GLOBALS['TSFE']->sys_language_content][$index_name])) {
790 790
             // Check if this table is allowed for translation.
791 791
             if (in_array($table, ['tx_dlf_collections', 'tx_dlf_libraries', 'tx_dlf_metadata', 'tx_dlf_structures'])) {
792
-                $additionalWhere = $queryBuilder->expr()->in($table.'.sys_language_uid', array(-1, 0));
792
+                $additionalWhere = $queryBuilder->expr()->in($table.'.sys_language_uid', array (-1, 0));
793 793
                 if ($GLOBALS['TSFE']->sys_language_content > 0) {
794 794
                     $additionalWhere = $queryBuilder->expr()->andX(
795 795
                         $queryBuilder->expr()->orX(
796
-                            $queryBuilder->expr()->in($table.'.sys_language_uid', array(-1, 0)),
796
+                            $queryBuilder->expr()->in($table.'.sys_language_uid', array (-1, 0)),
797 797
                             $queryBuilder->expr()->eq($table.'.sys_language_uid', intval($GLOBALS['TSFE']->sys_language_content))
798 798
                         ),
799 799
                         $queryBuilder->expr()->eq($table.'.l18n_parent', 0)
@@ -892,7 +892,7 @@  discard block
 block discarded – undo
892 892
         if (TYPO3_MODE === 'FE') {
893 893
             // Table "tx_dlf_formats" always has PID 0.
894 894
             if ($table == 'tx_dlf_formats') {
895
-                return $expressionBuilder->eq($table . '.' . $GLOBALS['TCA'][$table]['ctrl']['delete'], 0);
895
+                return $expressionBuilder->eq($table.'.'.$GLOBALS['TCA'][$table]['ctrl']['delete'], 0);
896 896
             }
897 897
 
898 898
             // Should we ignore the record's hidden flag?
@@ -914,7 +914,7 @@  discard block
 block discarded – undo
914 914
             }
915 915
             return $expression;
916 916
         } elseif (TYPO3_MODE === 'BE') {
917
-            return $expressionBuilder->eq($table . '.' . $GLOBALS['TCA'][$table]['ctrl']['delete'], 0);
917
+            return $expressionBuilder->eq($table.'.'.$GLOBALS['TCA'][$table]['ctrl']['delete'], 0);
918 918
         } else {
919 919
             self::devLog('Unexpected TYPO3_MODE "'.TYPO3_MODE.'"', DEVLOG_SEVERITY_ERROR);
920 920
             return '1=-1';
Please login to merge, or discard this patch.
Classes/Common/Document.php 2 patches
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -482,7 +482,7 @@  discard block
 block discarded – undo
482 482
                     /* @var $xml \SimpleXMLElement */
483 483
                     $xml->registerXPathNamespace('mets', 'http://www.loc.gov/METS/');
484 484
                     $xpathResult = $xml->xpath('//mets:mets');
485
-                    $documentFormat = ($xpathResult !== false && count($xpathResult)>0) ? 'METS' : null;
485
+                    $documentFormat = ($xpathResult !== false && count($xpathResult) > 0) ? 'METS' : null;
486 486
                 } else {
487 487
                     // Try to load file as IIIF resource instead.
488 488
                     $contentAsJsonArray = json_decode($content, true);
@@ -749,7 +749,7 @@  discard block
 block discarded – undo
749 749
                 return $depth;
750 750
             } elseif (array_key_exists('children', $element)) {
751 751
                 $foundInChildren = $this->getTreeDepth($element['children'], $depth + 1, $logId);
752
-                if ($foundInChildren!==false) {
752
+                if ($foundInChildren !== false) {
753 753
                     return $foundInChildren;
754 754
                 }
755 755
             }
@@ -986,7 +986,7 @@  discard block
 block discarded – undo
986 986
             ->from('tx_dlf_collections')
987 987
             ->where(
988 988
                 $queryBuilder->expr()->eq('tx_dlf_collections.pid', intval($pid)),
989
-                $queryBuilder->expr()->in('tx_dlf_collections.sys_language_uid', array(-1, 0)),
989
+                $queryBuilder->expr()->in('tx_dlf_collections.sys_language_uid', array (-1, 0)),
990 990
                 Helper::whereExpression('tx_dlf_collections')
991 991
             )
992 992
             ->execute();
Please login to merge, or discard this patch.
Upper-Lower-Casing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -415,9 +415,9 @@  discard block
 block discarded – undo
415 415
             }
416 416
         }
417 417
         // Create new instance depending on format (METS or IIIF) ...
418
-        $documentFormat = null;
419
-        $xml = null;
420
-        $iiif = null;
418
+        $documentFormat = NULL;
419
+        $xml = NULL;
420
+        $iiif = NULL;
421 421
         // Try to get document format from database
422 422
         if (MathUtility::canBeInterpretedAsInteger($uid)) {
423 423
             /** @var QueryBuilder $queryBuilder */
@@ -480,15 +480,15 @@  discard block
 block discarded – undo
480 480
                 libxml_disable_entity_loader($previousValueOfEntityLoader);
481 481
                 // Reset libxml's error logging.
482 482
                 libxml_use_internal_errors($libxmlErrors);
483
-                if ($xml !== false) {
483
+                if ($xml !== FALSE) {
484 484
                     /* @var $xml \SimpleXMLElement */
485 485
                     $xml->registerXPathNamespace('mets', 'http://www.loc.gov/METS/');
486 486
                     $xpathResult = $xml->xpath('//mets:mets');
487
-                    $documentFormat = ($xpathResult !== false && count($xpathResult)>0) ? 'METS' : null;
487
+                    $documentFormat = ($xpathResult !== FALSE && count($xpathResult)>0) ? 'METS' : NULL;
488 488
                 } else {
489 489
                     // Try to load file as IIIF resource instead.
490
-                    $contentAsJsonArray = json_decode($content, true);
491
-                    if ($contentAsJsonArray !== null) {
490
+                    $contentAsJsonArray = json_decode($content, TRUE);
491
+                    if ($contentAsJsonArray !== NULL) {
492 492
                         // Load plugin configuration.
493 493
                         $conf = unserialize($GLOBALS['TYPO3_CONF_VARS']['EXT']['extConf'][self::$extKey]);
494 494
                         IiifHelper::setUrlReader(IiifUrlReader::getInstance());
@@ -752,12 +752,12 @@  discard block
 block discarded – undo
752 752
                 return $depth;
753 753
             } elseif (array_key_exists('children', $element)) {
754 754
                 $foundInChildren = $this->getTreeDepth($element['children'], $depth + 1, $logId);
755
-                if ($foundInChildren!==false) {
755
+                if ($foundInChildren!==FALSE) {
756 756
                     return $foundInChildren;
757 757
                 }
758 758
             }
759 759
         }
760
-        return false;
760
+        return FALSE;
761 761
     }
762 762
 
763 763
     /**
Please login to merge, or discard this patch.
Classes/Plugin/Collection.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -120,7 +120,7 @@
 block discarded – undo
120 120
                 $queryBuilder->expr()->eq('tx_dlf_collections.pid', intval($this->conf['pages'])),
121 121
                 $queryBuilder->expr()->andX(
122 122
                     $queryBuilder->expr()->orX(
123
-                        $queryBuilder->expr()->in('tx_dlf_collections.sys_language_uid', array(-1, 0)),
123
+                        $queryBuilder->expr()->in('tx_dlf_collections.sys_language_uid', array (-1, 0)),
124 124
                         $queryBuilder->expr()->eq('tx_dlf_collections.sys_language_uid', $GLOBALS['TSFE']->sys_language_uid)
125 125
                     ),
126 126
                     $queryBuilder->expr()->eq('tx_dlf_collections.l18n_parent', 0)
Please login to merge, or discard this patch.