Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

GitHub Access Token became invalid

It seems like the GitHub access token used for retrieving details about this repository from GitHub became invalid. This might prevent certain types of inspections from being run (in particular, everything related to pull requests).
Please ask an admin of your repository to re-new the access token on this website.
Passed
Pull Request — master (#829)
by Beatrycze
03:53
created
Tests/Unit/Common/HelperTest.php 1 patch
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@
 block discarded – undo
40 40
 <root>
41 41
     <single />
42 42
 </root>
43
-XML;
43
+xml;
44 44
         $node = Helper::getXmlFileAsString($xml);
45 45
         $this->assertIsObject($node);
46 46
         $this->assertEquals('root', $node->getName());
Please login to merge, or discard this patch.
Build/Documentation/dbdocs/RstSection.php 3 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@
 block discarded – undo
46 46
 
47 47
     public static function paragraphs(array $paragraphs)
48 48
     {
49
-        $paragraphs = array_values(array_filter($paragraphs, function ($entry) {
49
+        $paragraphs = array_values(array_filter($paragraphs, function($entry) {
50 50
             return !empty($entry);
51 51
         }));
52 52
 
Please login to merge, or discard this patch.
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,8 @@
 block discarded – undo
46 46
 
47 47
     public static function paragraphs(array $paragraphs)
48 48
     {
49
-        $paragraphs = array_values(array_filter($paragraphs, function ($entry) {
49
+        $paragraphs = array_values(array_filter($paragraphs, function ($entry)
50
+        {
50 51
             return !empty($entry);
51 52
         }));
52 53
 
Please login to merge, or discard this patch.
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@
 block discarded – undo
64 64
    :header-rows: $numHeaderRows
65 65
 
66 66
 
67
-RST;
67
+rst;
68 68
 
69 69
         // Pattern for a row:
70 70
         //
Please login to merge, or discard this patch.
Classes/Common/Indexer.php 1 patch
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -531,7 +531,8 @@  discard block
 block discarded – undo
531 531
      *
532 532
      * @return \Solarium\Core\Query\DocumentInterface
533 533
      */
534
-    private static function getSolrDocument($updateQuery, $document, $unit, $fullText = '') {
534
+    private static function getSolrDocument($updateQuery, $document, $unit, $fullText = '')
535
+    {
535 536
         $solrDoc = $updateQuery->createDocument();
536 537
         // Create unique identifier from document's UID and unit's XML ID.
537 538
         $solrDoc->setField('id', $document->getUid() . $unit['id']);
@@ -555,7 +556,8 @@  discard block
 block discarded – undo
555 556
      *
556 557
      * @return array|string
557 558
      */
558
-    private static function removeAppendsFromAuthor($authors) {
559
+    private static function removeAppendsFromAuthor($authors)
560
+    {
559 561
         if (is_array($authors)) {
560 562
             foreach ($authors as $i => $author) {
561 563
                 $splitName = explode(chr(31), $author);
Please login to merge, or discard this patch.
Build/Documentation/dbdocs/Generator.php 3 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -204,7 +204,7 @@  discard block
 block discarded – undo
204 204
 RST);
205 205
 
206 206
         // Sort tables alphabetically
207
-        usort($tables, function ($lhs, $rhs) {
207
+        usort($tables, function($lhs, $rhs) {
208 208
             return $lhs->name <=> $rhs->name;
209 209
         });
210 210
 
@@ -231,7 +231,7 @@  discard block
 block discarded – undo
231 231
                 'description' => 'Description',
232 232
             ]];
233 233
 
234
-            $rows = array_map(function ($column) use ($page) {
234
+            $rows = array_map(function($column) use ($page) {
235 235
                 return [
236 236
                     'field' => (
237 237
                         $page->format($column->name, ['bold' => $column->isPrimary])
Please login to merge, or discard this patch.
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -204,7 +204,8 @@  discard block
 block discarded – undo
204 204
 RST);
205 205
 
206 206
         // Sort tables alphabetically
207
-        usort($tables, function ($lhs, $rhs) {
207
+        usort($tables, function ($lhs, $rhs)
208
+        {
208 209
             return $lhs->name <=> $rhs->name;
209 210
         });
210 211
 
@@ -231,7 +232,8 @@  discard block
 block discarded – undo
231 232
                 'description' => 'Description',
232 233
             ]];
233 234
 
234
-            $rows = array_map(function ($column) use ($page) {
235
+            $rows = array_map(function ($column) use ($page)
236
+            {
235 237
                 return [
236 238
                     'field' => (
237 239
                         $page->format($column->name, ['bold' => $column->isPrimary])
Please login to merge, or discard this patch.
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -201,7 +201,7 @@
 block discarded – undo
201 201
 This is a reference of all database tables defined by Kitodo.Presentation.
202 202
 
203 203
 .. tip:: This page is auto-generated. If you would like to edit it, please use doc-comments in the model class, COMMENT fields in ``ext_tables.sql`` if the table does not have one, or TCA labels. Then, you may re-generate the page by running ``composer docs:db`` inside the Kitodo.Presentation base folder.
204
-RST);
204
+rst);
205 205
 
206 206
         // Sort tables alphabetically
207 207
         usort($tables, function ($lhs, $rhs) {
Please login to merge, or discard this patch.
Classes/Controller/Backend/NewTenantController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -277,7 +277,7 @@
 block discarded – undo
277 277
 
278 278
         if ($this->solrCoreRepository->findOneByPid($this->pid) === null) {
279 279
             $newRecord = GeneralUtility::makeInstance(SolrCore::class);
280
-            $newRecord->setLabel($this->getLLL('flexform.solrcore', $this->siteLanguages[0]->getTypo3Language(), $beLabels). ' (PID ' . $this->pid . ')');
280
+            $newRecord->setLabel($this->getLLL('flexform.solrcore', $this->siteLanguages[0]->getTypo3Language(), $beLabels) . ' (PID ' . $this->pid . ')');
281 281
             $indexName = Solr::createCore('');
282 282
             $newRecord->setIndexName($indexName);
283 283
 
Please login to merge, or discard this patch.
Classes/Common/Helper.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -915,7 +915,7 @@
 block discarded – undo
915 915
             self::log('Could not fetch data from URL "' . $url . '". Error: ' . $e->getMessage() . '.', LOG_SEVERITY_WARNING);
916 916
             return false;
917 917
         }
918
-        $content  = $response->getBody()->getContents();
918
+        $content = $response->getBody()->getContents();
919 919
 
920 920
         return $content;
921 921
     }
Please login to merge, or discard this patch.
Classes/Domain/Repository/DocumentRepository.php 1 patch
Indentation   -1 removed lines patch added patch discarded remove patch
@@ -210,7 +210,6 @@
 block discarded – undo
210 210
      * Volumes are documents that are both
211 211
      *  a) "leaf" elements i.e. partof != 0
212 212
      *  b) "root" elements that are not referenced by other documents ("root" elements that have no descendants)
213
-
214 213
      * @param array $settings
215 214
      *
216 215
      * @return array
Please login to merge, or discard this patch.
Tests/Functional/FunctionalTestCase.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
         $this->configurationToUseInTestInstance['EXTENSIONS']['dlf'] = $this->getDlfConfiguration();
72 72
 
73 73
         if ($this->disableJsonWrappedResponse) {
74
-            $this->frameworkExtensionsToLoad = array_filter($this->frameworkExtensionsToLoad, function ($ext) {
74
+            $this->frameworkExtensionsToLoad = array_filter($this->frameworkExtensionsToLoad, function($ext) {
75 75
                 return $ext !== 'Resources/Core/Functional/Extensions/json_response';
76 76
             });
77 77
         }
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
         $jsonDocuments = json_decode(file_get_contents($path), true);
153 153
 
154 154
         $updateQuery = $solr->service->createUpdate();
155
-        $documents = array_map(function ($jsonDoc) use ($updateQuery) {
155
+        $documents = array_map(function($jsonDoc) use ($updateQuery) {
156 156
             $document = $updateQuery->createDocument();
157 157
             foreach ($jsonDoc as $key => $value) {
158 158
                 $document->setField($key, $value);
Please login to merge, or discard this patch.
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -71,7 +71,8 @@  discard block
 block discarded – undo
71 71
         $this->configurationToUseInTestInstance['EXTENSIONS']['dlf'] = $this->getDlfConfiguration();
72 72
 
73 73
         if ($this->disableJsonWrappedResponse) {
74
-            $this->frameworkExtensionsToLoad = array_filter($this->frameworkExtensionsToLoad, function ($ext) {
74
+            $this->frameworkExtensionsToLoad = array_filter($this->frameworkExtensionsToLoad, function ($ext)
75
+            {
75 76
                 return $ext !== 'Resources/Core/Functional/Extensions/json_response';
76 77
             });
77 78
         }
@@ -152,7 +153,8 @@  discard block
 block discarded – undo
152 153
         $jsonDocuments = json_decode(file_get_contents($path), true);
153 154
 
154 155
         $updateQuery = $solr->service->createUpdate();
155
-        $documents = array_map(function ($jsonDoc) use ($updateQuery) {
156
+        $documents = array_map(function ($jsonDoc) use ($updateQuery)
157
+        {
156 158
             $document = $updateQuery->createDocument();
157 159
             foreach ($jsonDoc as $key => $value) {
158 160
                 $document->setField($key, $value);
Please login to merge, or discard this patch.
Classes/Format/Mods.php 1 patch
Braces   +20 added lines, -10 removed lines patch added patch discarded remove patch
@@ -59,7 +59,8 @@  discard block
 block discarded – undo
59 59
      *
60 60
      * @return void
61 61
      */
62
-    private function getAuthors() {
62
+    private function getAuthors()
63
+    {
63 64
         $authors = $this->xml->xpath('./mods:name[./mods:role/mods:roleTerm[@type="code" and @authority="marcrelator"]="aut"]');
64 65
 
65 66
         // Get "author" and "author_sorting" again if that was too sophisticated.
@@ -123,7 +124,8 @@  discard block
 block discarded – undo
123 124
      *
124 125
      * @return void
125 126
      */
126
-    private function getHolders() {
127
+    private function getHolders()
128
+    {
127 129
         $holders = $this->xml->xpath('./mods:name[./mods:role/mods:roleTerm[@type="code" and @authority="marcrelator"]="prv"]');
128 130
 
129 131
         if (!empty($holders)) {
@@ -181,7 +183,8 @@  discard block
 block discarded – undo
181 183
      *
182 184
      * @return void
183 185
      */
184
-    private function getPlaces() {
186
+    private function getPlaces()
187
+    {
185 188
         $places = $this->xml->xpath('./mods:originInfo[not(./mods:edition="[Electronic ed.]")]/mods:place/mods:placeTerm');
186 189
         // Get "place" and "place_sorting" again if that was to sophisticated.
187 190
         if (empty($places)) {
@@ -205,7 +208,8 @@  discard block
 block discarded – undo
205 208
      *
206 209
      * @return void
207 210
      */
208
-    private function getYears() {
211
+    private function getYears()
212
+    {
209 213
         // Get "year_sorting".
210 214
         if (($years_sorting = $this->xml->xpath('./mods:originInfo[not(./mods:edition="[Electronic ed.]")]/mods:dateOther[@type="order" and @encoding="w3cdtf"]'))) {
211 215
             foreach ($years_sorting as $year_sorting) {
@@ -243,7 +247,8 @@  discard block
 block discarded – undo
243 247
      *
244 248
      * @return void
245 249
      */
246
-    private function getDescription() {
250
+    private function getDescription()
251
+    {
247 252
         $this->getSingleMetadata('description', './mods:recordInfo/mods:recordInfoNote/text()');
248 253
     }
249 254
 
@@ -254,7 +259,8 @@  discard block
 block discarded – undo
254 259
      *
255 260
      * @return void
256 261
      */
257
-    private function getIdentifier() {
262
+    private function getIdentifier()
263
+    {
258 264
         $this->getSingleMetadata('identifier', './mods:identifier/text()');
259 265
     }
260 266
 
@@ -265,7 +271,8 @@  discard block
 block discarded – undo
265 271
      *
266 272
      * @return void
267 273
      */
268
-    private function getLicense() {
274
+    private function getLicense()
275
+    {
269 276
         $this->getSingleMetadata('license', './mods:accessCondition/text()');
270 277
     }
271 278
 
@@ -278,7 +285,8 @@  discard block
 block discarded – undo
278 285
      *
279 286
      * @return void
280 287
      */
281
-    private function getObjectNames() {
288
+    private function getObjectNames()
289
+    {
282 290
         $this->getSingleMetadata('object_name', './mods:relatedItem/mods:titleInfo[not(@displayLabel="alternative")]/mods:title/text()');
283 291
         $this->getSingleMetadata('object_alternative_names', './mods:relatedItem/mods:titleInfo[@displayLabel="alternative"]/mods:title/text()');
284 292
     }
@@ -294,7 +302,8 @@  discard block
 block discarded – undo
294 302
      *
295 303
      * @return void
296 304
      */
297
-    private function getObjectLocationMetadata() {
305
+    private function getObjectLocationMetadata()
306
+    {
298 307
         $this->getSingleMetadata('object_location', './mods:relatedItem/mods:location/mods:physicalLocation/text()');
299 308
         $this->getSingleMetadata('geonames', './mods:relatedItem/mods:location/mods:url[@displayLabel="geonames"]/text()');
300 309
         $this->getSingleMetadata('wikidata', './mods:relatedItem/mods:location/mods:url[@displayLabel="wikidata"]/text()');
@@ -311,7 +320,8 @@  discard block
 block discarded – undo
311 320
      *
312 321
      * @return void
313 322
      */
314
-    private function getSingleMetadata($metadataIndex, $xpath) {
323
+    private function getSingleMetadata($metadataIndex, $xpath)
324
+    {
315 325
         $results = $this->xml->xpath($xpath);
316 326
         if (!empty($results)) {
317 327
             foreach ($results as $result) {
Please login to merge, or discard this patch.