We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
| @@ -46,7 +46,7 @@ | ||
| 46 | 46 | |
| 47 | 47 | public static function paragraphs(array $paragraphs) | 
| 48 | 48 |      { | 
| 49 | -        $paragraphs = array_values(array_filter($paragraphs, function ($entry) { | |
| 49 | +        $paragraphs = array_values(array_filter($paragraphs, function($entry) { | |
| 50 | 50 | return !empty($entry); | 
| 51 | 51 | })); | 
| 52 | 52 | |
| @@ -46,7 +46,8 @@ | ||
| 46 | 46 | |
| 47 | 47 | public static function paragraphs(array $paragraphs) | 
| 48 | 48 |      { | 
| 49 | -        $paragraphs = array_values(array_filter($paragraphs, function ($entry) { | |
| 49 | + $paragraphs = array_values(array_filter($paragraphs, function ($entry) | |
| 50 | +        { | |
| 50 | 51 | return !empty($entry); | 
| 51 | 52 | })); | 
| 52 | 53 | |
| @@ -64,7 +64,7 @@ | ||
| 64 | 64 | :header-rows: $numHeaderRows | 
| 65 | 65 | |
| 66 | 66 | |
| 67 | -RST; | |
| 67 | +rst; | |
| 68 | 68 | |
| 69 | 69 | // Pattern for a row: | 
| 70 | 70 | // | 
| @@ -204,7 +204,7 @@ discard block | ||
| 204 | 204 | RST); | 
| 205 | 205 | |
| 206 | 206 | // Sort tables alphabetically | 
| 207 | -        usort($tables, function ($lhs, $rhs) { | |
| 207 | +        usort($tables, function($lhs, $rhs) { | |
| 208 | 208 | return $lhs->name <=> $rhs->name; | 
| 209 | 209 | }); | 
| 210 | 210 | |
| @@ -231,7 +231,7 @@ discard block | ||
| 231 | 231 | 'description' => 'Description', | 
| 232 | 232 | ]]; | 
| 233 | 233 | |
| 234 | -            $rows = array_map(function ($column) use ($page) { | |
| 234 | +            $rows = array_map(function($column) use ($page) { | |
| 235 | 235 | return [ | 
| 236 | 236 | 'field' => ( | 
| 237 | 237 | $page->format($column->name, ['bold' => $column->isPrimary]) | 
| @@ -204,7 +204,8 @@ discard block | ||
| 204 | 204 | RST); | 
| 205 | 205 | |
| 206 | 206 | // Sort tables alphabetically | 
| 207 | -        usort($tables, function ($lhs, $rhs) { | |
| 207 | + usort($tables, function ($lhs, $rhs) | |
| 208 | +        { | |
| 208 | 209 | return $lhs->name <=> $rhs->name; | 
| 209 | 210 | }); | 
| 210 | 211 | |
| @@ -231,7 +232,8 @@ discard block | ||
| 231 | 232 | 'description' => 'Description', | 
| 232 | 233 | ]]; | 
| 233 | 234 | |
| 234 | -            $rows = array_map(function ($column) use ($page) { | |
| 235 | + $rows = array_map(function ($column) use ($page) | |
| 236 | +            { | |
| 235 | 237 | return [ | 
| 236 | 238 | 'field' => ( | 
| 237 | 239 | $page->format($column->name, ['bold' => $column->isPrimary]) | 
| @@ -201,7 +201,7 @@ | ||
| 201 | 201 | This is a reference of all database tables defined by Kitodo.Presentation. | 
| 202 | 202 | |
| 203 | 203 | .. tip:: This page is auto-generated. If you would like to edit it, please use doc-comments in the model class, COMMENT fields in ``ext_tables.sql`` if the table does not have one, or TCA labels. Then, you may re-generate the page by running ``composer docs:db`` inside the Kitodo.Presentation base folder. | 
| 204 | -RST); | |
| 204 | +rst); | |
| 205 | 205 | |
| 206 | 206 | // Sort tables alphabetically | 
| 207 | 207 |          usort($tables, function ($lhs, $rhs) { | 
| @@ -71,7 +71,7 @@ discard block | ||
| 71 | 71 | $this->configurationToUseInTestInstance['EXTENSIONS']['dlf'] = $this->getDlfConfiguration(); | 
| 72 | 72 | |
| 73 | 73 |          if ($this->disableJsonWrappedResponse) { | 
| 74 | -            $this->frameworkExtensionsToLoad = array_filter($this->frameworkExtensionsToLoad, function ($ext) { | |
| 74 | +            $this->frameworkExtensionsToLoad = array_filter($this->frameworkExtensionsToLoad, function($ext) { | |
| 75 | 75 | return $ext !== 'Resources/Core/Functional/Extensions/json_response'; | 
| 76 | 76 | }); | 
| 77 | 77 | } | 
| @@ -152,7 +152,7 @@ discard block | ||
| 152 | 152 | $jsonDocuments = json_decode(file_get_contents($path), true); | 
| 153 | 153 | |
| 154 | 154 | $updateQuery = $solr->service->createUpdate(); | 
| 155 | -        $documents = array_map(function ($jsonDoc) use ($updateQuery) { | |
| 155 | +        $documents = array_map(function($jsonDoc) use ($updateQuery) { | |
| 156 | 156 | $document = $updateQuery->createDocument(); | 
| 157 | 157 |              foreach ($jsonDoc as $key => $value) { | 
| 158 | 158 | $document->setField($key, $value); | 
| @@ -71,7 +71,8 @@ discard block | ||
| 71 | 71 | $this->configurationToUseInTestInstance['EXTENSIONS']['dlf'] = $this->getDlfConfiguration(); | 
| 72 | 72 | |
| 73 | 73 |          if ($this->disableJsonWrappedResponse) { | 
| 74 | -            $this->frameworkExtensionsToLoad = array_filter($this->frameworkExtensionsToLoad, function ($ext) { | |
| 74 | + $this->frameworkExtensionsToLoad = array_filter($this->frameworkExtensionsToLoad, function ($ext) | |
| 75 | +            { | |
| 75 | 76 | return $ext !== 'Resources/Core/Functional/Extensions/json_response'; | 
| 76 | 77 | }); | 
| 77 | 78 | } | 
| @@ -152,7 +153,8 @@ discard block | ||
| 152 | 153 | $jsonDocuments = json_decode(file_get_contents($path), true); | 
| 153 | 154 | |
| 154 | 155 | $updateQuery = $solr->service->createUpdate(); | 
| 155 | -        $documents = array_map(function ($jsonDoc) use ($updateQuery) { | |
| 156 | + $documents = array_map(function ($jsonDoc) use ($updateQuery) | |
| 157 | +        { | |
| 156 | 158 | $document = $updateQuery->createDocument(); | 
| 157 | 159 |              foreach ($jsonDoc as $key => $value) { | 
| 158 | 160 | $document->setField($key, $value); | 
| @@ -400,7 +400,8 @@ | ||
| 400 | 400 | return ''; | 
| 401 | 401 | } | 
| 402 | 402 | |
| 403 | -        $makeCacheKey = function ($pid, $uid) { | |
| 403 | + $makeCacheKey = function ($pid, $uid) | |
| 404 | +        { | |
| 404 | 405 | return $pid . '.' . $uid; | 
| 405 | 406 | }; | 
| 406 | 407 | |
| @@ -438,7 +438,7 @@ | ||
| 438 | 438 | return ''; | 
| 439 | 439 | } | 
| 440 | 440 | |
| 441 | -        $makeCacheKey = function ($pid, $uid) { | |
| 441 | +        $makeCacheKey = function($pid, $uid) { | |
| 442 | 442 | return $pid . '.' . $uid; | 
| 443 | 443 | }; | 
| 444 | 444 | |
| @@ -70,7 +70,7 @@ | ||
| 70 | 70 | $pageGridPagination = new PageGridPagination($pageGridPaginator); | 
| 71 | 71 | |
| 72 | 72 | $pagination = $this->buildSimplePagination($pageGridPagination, $pageGridPaginator); | 
| 73 | - $this->view->assignMultiple([ 'pagination' => $pagination, 'paginator' => $pageGridPaginator ]); | |
| 73 | + $this->view->assignMultiple(['pagination' => $pagination, 'paginator' => $pageGridPaginator]); | |
| 74 | 74 | |
| 75 | 75 |          $this->view->assign('docUid', $this->requestData['id']); | 
| 76 | 76 | } | 
| @@ -278,7 +278,7 @@ | ||
| 278 | 278 | |
| 279 | 279 |          if ($this->solrCoreRepository->findOneByPid($this->pid) === null) { | 
| 280 | 280 | $newRecord = GeneralUtility::makeInstance(SolrCore::class); | 
| 281 | -            $newRecord->setLabel($this->getLLL('flexform.solrcore', $this->siteLanguages[0]->getTypo3Language(), $beLabels). ' (PID ' . $this->pid . ')'); | |
| 281 | +            $newRecord->setLabel($this->getLLL('flexform.solrcore', $this->siteLanguages[0]->getTypo3Language(), $beLabels) . ' (PID ' . $this->pid . ')'); | |
| 282 | 282 |              $indexName = Solr::createCore(''); | 
| 283 | 283 |              if (!empty($indexName)) { | 
| 284 | 284 | $newRecord->setIndexName($indexName); | 
| @@ -365,8 +365,8 @@ | ||
| 365 | 365 | $searchResult['snippet'] = $doc['snippet']; | 
| 366 | 366 | $searchResult['highlight'] = $doc['highlight']; | 
| 367 | 367 |                                  $searchResult['highlight_word'] = preg_replace('/^;|;$/', '',       // remove ; at beginning or end | 
| 368 | -                                                                  preg_replace('/;+/', ';',         // replace any multiple of ; with a single ; | |
| 369 | -                                                                  preg_replace('/[{~\d*}{\s+}{^=*\d+.*\d*}`~!@#$%\^&*()_|+-=?;:\'",.<>\{\}\[\]\\\]/', ';', $this->searchParams['query']))); // replace search operators and special characters with ; | |
| 368 | +                                                                    preg_replace('/;+/', ';',         // replace any multiple of ; with a single ; | |
| 369 | +                                                                    preg_replace('/[{~\d*}{\s+}{^=*\d+.*\d*}`~!@#$%\^&*()_|+-=?;:\'",.<>\{\}\[\]\\\]/', ';', $this->searchParams['query']))); // replace search operators and special characters with ; | |
| 370 | 370 | } | 
| 371 | 371 | $documents[$doc['uid']]['searchResults'][] = $searchResult; | 
| 372 | 372 | } | 
| @@ -776,7 +776,8 @@ | ||
| 776 | 776 | * | 
| 777 | 777 | * @return array The Apache Solr Documents that were fetched | 
| 778 | 778 | */ | 
| 779 | -    private function getDocument(Document $record, array $highlighting, array $fields, $parameters) { | |
| 779 | + private function getDocument(Document $record, array $highlighting, array $fields, $parameters) | |
| 780 | +    { | |
| 780 | 781 | $resultDocument = new ResultDocument($record, $highlighting, $fields); | 
| 781 | 782 | |
| 782 | 783 | $document = [ | 
| @@ -413,7 +413,7 @@ discard block | ||
| 413 | 413 | // Add filter query for date search | 
| 414 | 414 |          if (!empty($this->searchParams['dateFrom']) && !empty($this->searchParams['dateTo'])) { | 
| 415 | 415 | // combine dateFrom and dateTo into range search | 
| 416 | -            $params['filterquery'][]['query'] = '{!join from=' . $fields['uid'] . ' to=' . $fields['uid'] . '}'. $fields['date'] . ':[' . $this->searchParams['dateFrom'] . ' TO ' . $this->searchParams['dateTo'] . ']'; | |
| 416 | +            $params['filterquery'][]['query'] = '{!join from=' . $fields['uid'] . ' to=' . $fields['uid'] . '}' . $fields['date'] . ':[' . $this->searchParams['dateFrom'] . ' TO ' . $this->searchParams['dateTo'] . ']'; | |
| 417 | 417 | } | 
| 418 | 418 | |
| 419 | 419 | // Add filter query for faceting. | 
| @@ -531,8 +531,8 @@ discard block | ||
| 531 | 531 |                              if ($this->searchParams['fulltext'] == '1') { | 
| 532 | 532 | $searchResult['snippet'] = $doc['snippet']; | 
| 533 | 533 | $searchResult['highlight'] = $doc['highlight']; | 
| 534 | -                                $searchResult['highlight_word'] = preg_replace('/^;|;$/', '',       // remove ; at beginning or end | |
| 535 | -                                                                  preg_replace('/;+/', ';',         // replace any multiple of ; with a single ; | |
| 534 | +                                $searchResult['highlight_word'] = preg_replace('/^;|;$/', '', // remove ; at beginning or end | |
| 535 | +                                                                  preg_replace('/;+/', ';', // replace any multiple of ; with a single ; | |
| 536 | 536 |                                                                    preg_replace('/[{~\d*}{\s+}{^=*\d+.*\d*}`~!@#$%\^&*()_|+-=?;:\'",.<>\{\}\[\]\\\]/', ';', $this->searchParams['query']))); // replace search operators and special characters with ; | 
| 537 | 537 | } | 
| 538 | 538 | $documents[$doc['uid']]['searchResults'][] = $searchResult; | 
| @@ -860,7 +860,7 @@ discard block | ||
| 860 | 860 | private function translateLanguageCode(&$doc): void | 
| 861 | 861 |      { | 
| 862 | 862 |          if (array_key_exists('language', $doc['metadata'])) { | 
| 863 | -            foreach($doc['metadata']['language'] as $indexName => $language) { | |
| 863 | +            foreach ($doc['metadata']['language'] as $indexName => $language) { | |
| 864 | 864 | $doc['metadata']['language'][$indexName] = Helper::getLanguageName($language); | 
| 865 | 865 | } | 
| 866 | 866 | } | 
| @@ -38,15 +38,15 @@ | ||
| 38 | 38 | */ | 
| 39 | 39 | private int $offset; | 
| 40 | 40 | |
| 41 | - /** | |
| 42 | - * Constructs SolrSearchQuery instance. | |
| 43 | - * | |
| 44 | - * @access public | |
| 45 | - * | |
| 46 | - * @param SolrSearch $solrSearch | |
| 47 | - * | |
| 48 | - * @return void | |
| 49 | - */ | |
| 41 | + /** | |
| 42 | + * Constructs SolrSearchQuery instance. | |
| 43 | + * | |
| 44 | + * @access public | |
| 45 | + * | |
| 46 | + * @param SolrSearch $solrSearch | |
| 47 | + * | |
| 48 | + * @return void | |
| 49 | + */ | |
| 50 | 50 | public function __construct($solrSearch) | 
| 51 | 51 |      { | 
| 52 | 52 | $this->solrSearch = $solrSearch; | 
| @@ -57,7 +57,9 @@ discard block | ||
| 57 | 57 | |
| 58 | 58 | // this class contains a lot of methods which are inherited but not implemented | 
| 59 | 59 | // @phpstan-ignore-next-line | 
| 60 | -    public function getSource() {} | |
| 60 | + public function getSource() | |
| 61 | +    { | |
| 62 | +} | |
| 61 | 63 | |
| 62 | 64 | /** | 
| 63 | 65 | * Executes SOLR search query. | 
| @@ -84,7 +86,9 @@ discard block | ||
| 84 | 86 | } | 
| 85 | 87 | |
| 86 | 88 | // @phpstan-ignore-next-line | 
| 87 | -    public function setOrderings(array $orderings) {} | |
| 89 | + public function setOrderings(array $orderings) | |
| 90 | +    { | |
| 91 | +} | |
| 88 | 92 | |
| 89 | 93 | /** | 
| 90 | 94 | * Sets limit for SOLR search query. | 
| @@ -117,42 +121,75 @@ discard block | ||
| 117 | 121 | } | 
| 118 | 122 | |
| 119 | 123 | // @phpstan-ignore-next-line | 
| 120 | -    public function matching($constraint) {} | |
| 124 | + public function matching($constraint) | |
| 125 | +    { | |
| 126 | +} | |
| 121 | 127 | // @phpstan-ignore-next-line | 
| 122 | -    public function logicalAnd($constraint1) {} | |
| 128 | + public function logicalAnd($constraint1) | |
| 129 | +    { | |
| 130 | +} | |
| 123 | 131 | // @phpstan-ignore-next-line | 
| 124 | -    public function logicalOr($constraint1) {} | |
| 132 | + public function logicalOr($constraint1) | |
| 133 | +    { | |
| 134 | +} | |
| 125 | 135 | // @phpstan-ignore-next-line | 
| 126 | -    public function logicalNot(ConstraintInterface $constraint) {} | |
| 136 | + public function logicalNot(ConstraintInterface $constraint) | |
| 137 | +    { | |
| 138 | +} | |
| 127 | 139 | // @phpstan-ignore-next-line | 
| 128 | -    public function equals($propertyName, $operand, $caseSensitive = true) {} | |
| 140 | + public function equals($propertyName, $operand, $caseSensitive = true) | |
| 141 | +    { | |
| 142 | +} | |
| 129 | 143 | // @phpstan-ignore-next-line | 
| 130 | -    public function like($propertyName, $operand) {} | |
| 144 | + public function like($propertyName, $operand) | |
| 145 | +    { | |
| 146 | +} | |
| 131 | 147 | // @phpstan-ignore-next-line | 
| 132 | -    public function contains($propertyName, $operand) {} | |
| 148 | + public function contains($propertyName, $operand) | |
| 149 | +    { | |
| 150 | +} | |
| 133 | 151 | // @phpstan-ignore-next-line | 
| 134 | -    public function in($propertyName, $operand) {} | |
| 152 | + public function in($propertyName, $operand) | |
| 153 | +    { | |
| 154 | +} | |
| 135 | 155 | // @phpstan-ignore-next-line | 
| 136 | -    public function lessThan($propertyName, $operand) {} | |
| 156 | + public function lessThan($propertyName, $operand) | |
| 157 | +    { | |
| 158 | +} | |
| 137 | 159 | // @phpstan-ignore-next-line | 
| 138 | -    public function lessThanOrEqual($propertyName, $operand) {} | |
| 160 | + public function lessThanOrEqual($propertyName, $operand) | |
| 161 | +    { | |
| 162 | +} | |
| 139 | 163 | // @phpstan-ignore-next-line | 
| 140 | -    public function greaterThan($propertyName, $operand) {} | |
| 164 | + public function greaterThan($propertyName, $operand) | |
| 165 | +    { | |
| 166 | +} | |
| 141 | 167 | // @phpstan-ignore-next-line | 
| 142 | -    public function greaterThanOrEqual($propertyName, $operand) {} | |
| 168 | + public function greaterThanOrEqual($propertyName, $operand) | |
| 169 | +    { | |
| 170 | +} | |
| 143 | 171 | // @phpstan-ignore-next-line | 
| 144 | -    public function getType() {} | |
| 145 | -    public function setQuerySettings(QuerySettingsInterface $querySettings) {} | |
| 172 | + public function getType() | |
| 173 | +    { | |
| 174 | +} | |
| 175 | + public function setQuerySettings(QuerySettingsInterface $querySettings) | |
| 176 | +    { | |
| 177 | +} | |
| 146 | 178 | // @phpstan-ignore-next-line | 
| 147 | -    public function getQuerySettings() {} | |
| 179 | + public function getQuerySettings() | |
| 180 | +    { | |
| 181 | +} | |
| 148 | 182 | |
| 149 | 183 | public function count() | 
| 150 | -    {// @phpstan-ignore-next-line | |
| 184 | +    { | |
| 185 | +// @phpstan-ignore-next-line | |
| 151 | 186 | // TODO? | 
| 152 | 187 | } | 
| 153 | 188 | |
| 154 | 189 | // @phpstan-ignore-next-line | 
| 155 | -    public function getOrderings() {} | |
| 190 | + public function getOrderings() | |
| 191 | +    { | |
| 192 | +} | |
| 156 | 193 | |
| 157 | 194 | /** | 
| 158 | 195 | * Gets limit for SOLR search query. | 
| @@ -179,9 +216,17 @@ discard block | ||
| 179 | 216 | } | 
| 180 | 217 | |
| 181 | 218 | // @phpstan-ignore-next-line | 
| 182 | -    public function getConstraint() {} | |
| 183 | -    public function isEmpty($propertyName) {} | |
| 184 | -    public function setSource(SourceInterface $source) {} | |
| 219 | + public function getConstraint() | |
| 220 | +    { | |
| 221 | +} | |
| 222 | + public function isEmpty($propertyName) | |
| 223 | +    { | |
| 224 | +} | |
| 225 | + public function setSource(SourceInterface $source) | |
| 226 | +    { | |
| 227 | +} | |
| 185 | 228 | // @phpstan-ignore-next-line | 
| 186 | -    public function getStatement() {} | |
| 229 | + public function getStatement() | |
| 230 | +    { | |
| 231 | +} | |
| 187 | 232 | } | 
| @@ -33,7 +33,7 @@ | ||
| 33 | 33 | * | 
| 34 | 34 | * @return void | 
| 35 | 35 | */ | 
| 36 | - public function pageSelectAction(PageSelectForm $pageSelectForm = NULL): void | |
| 36 | + public function pageSelectAction(PageSelectForm $pageSelectForm = null): void | |
| 37 | 37 |      { | 
| 38 | 38 |          if ($pageSelectForm) { | 
| 39 | 39 | $uri = $this->uriBuilder->reset() |