Issues in EvernoteAdminController.php (master) - Issues in master - ishannz/silverstripe-evernote - Measure and Improve Code Quality continuously with Scrutinizer

Issues (31)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

code/controller/EvernoteAdminController.php (13 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * @package EvernoteSettings
 */
class EvernoteAdminController extends LeftAndMain
namespace YourVendor;

class YourClass { }
{

    /**
     * @var string
     */
    private static $url_segment = 'evernote-settings';

    /**
     * @var string
     */
    private static $url_rule = '/$Action/$ID/$OtherID';


    /**
     * @var string
     */
    private static $menu_title = 'Evernote';

    /**
     * @var string
     */
    private static $menu_icon = '/silverstripe-evernote/images/evernote.png';



    /**
     * @param null $id Not used.
     * @param null $fields Not used.
     *
     * @return Form
     */
    public function getEditForm($id = null, $fields = null)
    {

        $evernoteSettings = EvernoteSettings::current_Evernote_settings();
        $fields = $evernoteSettings->getCMSFields();

        // Retrieve validator, if one has been setup
        if ($evernoteSettings->hasMethod("getCMSValidator")) {
            $validator = $evernoteSettings->getCMSValidator();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        } else {
            $validator = null;
        }

        $actions = $evernoteSettings->getCMSActions();

        $form = CMSForm::create(
            $this, 'EditForm', $fields, $actions, $validator
        )->setHTMLID('Form_EditForm');

        $form->setResponseNegotiator($this->getResponseNegotiator());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $form->addExtraClass('cms-content center cms-edit-form');
        $form->setTemplate($this->getTemplatesWithSuffix('_EditForm'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        if ($form->Fields()->hasTabset()) $form->Fields()->findOrMakeTab('Root')->setTemplate('CMSTabSet');

        $form->addExtraClass('center ss-tabset cms-tabset ' . $this->BaseCSSClasses());
        $form->setAttribute('data-pjax-fragment', 'CurrentForm');

        $this->extend('updateEditForm', $form);

        return $form;

    }

    /**
     * Save the current sites {@link SiteConfig} into the database.
     *
     * @param array $data
     * @param Form $form
     * @return String
     */
    public function save_evernotesettings($data, $form)

    {
        $evernoteSettings = EvernoteSettings::current_Evernote_settings();
        $form->saveInto($evernoteSettings);

        try {
            $evernoteSettings->write();
        } catch (ValidationException $ex) {
            $form->sessionMessage($ex->getResult()->message(), 'bad');
            return $this->getResponseNegotiator()->respond($this->request);
        }

        $this->response->addHeader('X-Status', rawurlencode(_t('LeftAndMain.SAVEDUP', 'Saved.')));

        return $form->forTemplate();
    }

}


1			<?php
2
3			/**
4			* @package EvernoteSettings
5			*/
6			class EvernoteAdminController extends LeftAndMain
			0 ignored issues – show Coding Style Compatibility introduced 2016-08-28 03:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
7			{
8
9			/**
10			* @var string
11			*/
12			private static $url_segment = 'evernote-settings';
			0 ignored issues – show Comprehensibility introduced 2016-08-28 03:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2016-08-28 03:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$url_segment` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
13			/**
14			* @var string
15			*/
16			private static $url_rule = '/$Action/$ID/$OtherID';
			0 ignored issues – show Comprehensibility introduced 2016-08-28 03:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2016-08-28 03:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$url_rule` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
17
18			/**
19			* @var string
20			*/
21			private static $menu_title = 'Evernote';
			0 ignored issues – show Comprehensibility introduced 2016-08-28 03:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2016-08-28 03:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$menu_title` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
22			/**
23			* @var string
24			*/
25			private static $menu_icon = '/silverstripe-evernote/images/evernote.png';
			0 ignored issues – show Comprehensibility introduced 2016-08-28 03:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2016-08-28 03:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$menu_icon` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
26
27
28			/**
29			* @param null $id Not used.
30			* @param null $fields Not used.
31			*
32			* @return Form
33			*/
34			public function getEditForm($id = null, $fields = null)
35			{
36
37			$evernoteSettings = EvernoteSettings::current_Evernote_settings();
38			$fields = $evernoteSettings->getCMSFields();
39
40			// Retrieve validator, if one has been setup
41			if ($evernoteSettings->hasMethod("getCMSValidator")) {
42			$validator = $evernoteSettings->getCMSValidator();
			0 ignored issues – show Documentation Bug introduced 2016-08-28 03:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `getCMSValidator` does not exist on `object<EvernoteSettings>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
43			} else {
44			$validator = null;
45			}
46
47			$actions = $evernoteSettings->getCMSActions();
48
49			$form = CMSForm::create(
50			$this, 'EditForm', $fields, $actions, $validator
51			)->setHTMLID('Form_EditForm');
52
53			$form->setResponseNegotiator($this->getResponseNegotiator());
			0 ignored issues – show Documentation introduced 2016-08-28 03:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$this->getResponseNegotiator()` is of type `object<PjaxResponseNegotiator>`, but the function expects a `object<ResponseNegotiator>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
54			$form->addExtraClass('cms-content center cms-edit-form');
55			$form->setTemplate($this->getTemplatesWithSuffix('_EditForm'));
			0 ignored issues – show Documentation introduced 2016-08-28 03:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$this->getTemplatesWithSuffix('_EditForm')` is of type `array`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
56
57			if ($form->Fields()->hasTabset()) $form->Fields()->findOrMakeTab('Root')->setTemplate('CMSTabSet');
58
59			$form->addExtraClass('center ss-tabset cms-tabset ' . $this->BaseCSSClasses());
60			$form->setAttribute('data-pjax-fragment', 'CurrentForm');
61
62			$this->extend('updateEditForm', $form);
63
64			return $form;
65
66			}
67
68			/**
69			* Save the current sites {@link SiteConfig} into the database.
70			*
71			* @param array $data
72			* @param Form $form
73			* @return String
74			*/
75			public function save_evernotesettings($data, $form)
			0 ignored issues – show Unused Code introduced 2016-08-28 03:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$data` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
76			{
77			$evernoteSettings = EvernoteSettings::current_Evernote_settings();
78			$form->saveInto($evernoteSettings);
79
80			try {
81			$evernoteSettings->write();
82			} catch (ValidationException $ex) {
83			$form->sessionMessage($ex->getResult()->message(), 'bad');
84			return $this->getResponseNegotiator()->respond($this->request);
85			}
86
87			$this->response->addHeader('X-Status', rawurlencode(_t('LeftAndMain.SAVEDUP', 'Saved.')));
88
89			return $form->forTemplate();
90			}
91
92			}
93

ishannz / silverstripe-evernote

Issues (31)

Security Analysis not enabled

code/controller/EvernoteAdminController.php (13 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like