EvernoteAdminController

Complexity

Total Complexity

5

Size/Duplication

Total Lines	87
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	getEditForm()	0	33	3
A	save_evernotesettings()	0	16	2

<?php

/**
 * @package EvernoteSettings
 */
class EvernoteAdminController extends LeftAndMain

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    /**
     * @var string
     */
    private static $url_segment = 'evernote-settings';

Consider using a different property name as you override a private property of the parent class.

The property $url_segment is not used and could be removed.

    /**
     * @var string
     */
    private static $url_rule = '/$Action/$ID/$OtherID';

Consider using a different property name as you override a private property of the parent class.

The property $url_rule is not used and could be removed.

    /**
     * @var string
     */
    private static $menu_title = 'Evernote';

Consider using a different property name as you override a private property of the parent class.

The property $menu_title is not used and could be removed.

    /**
     * @var string
     */
    private static $menu_icon = '/silverstripe-evernote/images/evernote.png';

Consider using a different property name as you override a private property of the parent class.

The property $menu_icon is not used and could be removed.

    /**
     * @param null $id Not used.
     * @param null $fields Not used.
     *
     * @return Form
     */
    public function getEditForm($id = null, $fields = null)
    {

        $evernoteSettings = EvernoteSettings::current_Evernote_settings();
        $fields = $evernoteSettings->getCMSFields();

        // Retrieve validator, if one has been setup
        if ($evernoteSettings->hasMethod("getCMSValidator")) {
            $validator = $evernoteSettings->getCMSValidator();

The method getCMSValidator does not exist on object<EvernoteSettings>? Since you implemented __call, maybe consider adding a @method annotation.

        } else {
            $validator = null;
        }

        $actions = $evernoteSettings->getCMSActions();

        $form = CMSForm::create(
            $this, 'EditForm', $fields, $actions, $validator
        )->setHTMLID('Form_EditForm');

        $form->setResponseNegotiator($this->getResponseNegotiator());

$this->getResponseNegotiator() is of type object<PjaxResponseNegotiator>, but the function expects a object<ResponseNegotiator>.

        $form->addExtraClass('cms-content center cms-edit-form');
        $form->setTemplate($this->getTemplatesWithSuffix('_EditForm'));

$this->getTemplatesWithSuffix('_EditForm') is of type array, but the function expects a string.

        if ($form->Fields()->hasTabset()) $form->Fields()->findOrMakeTab('Root')->setTemplate('CMSTabSet');

        $form->addExtraClass('center ss-tabset cms-tabset ' . $this->BaseCSSClasses());
        $form->setAttribute('data-pjax-fragment', 'CurrentForm');

        $this->extend('updateEditForm', $form);

        return $form;

    }

    /**
     * Save the current sites {@link SiteConfig} into the database.
     *
     * @param array $data
     * @param Form $form
     * @return String
     */
    public function save_evernotesettings($data, $form)

The parameter $data is not used and could be removed.

    {
        $evernoteSettings = EvernoteSettings::current_Evernote_settings();
        $form->saveInto($evernoteSettings);

        try {
            $evernoteSettings->write();
        } catch (ValidationException $ex) {
            $form->sessionMessage($ex->getResult()->message(), 'bad');
            return $this->getResponseNegotiator()->respond($this->request);
        }

        $this->response->addHeader('X-Status', rawurlencode(_t('LeftAndMain.SAVEDUP', 'Saved.')));

        return $form->forTemplate();
    }

}