EvernoteAdminController::save_evernotesettings() - Code Metrics - ishannz/silverstripe-evernote - Measure and Improve Code Quality continuously with Scrutinizer

EvernoteAdminController::save_evernotesettings() A
last analyzed 2016-08-28 03:50 UTC

↳ Parent: EvernoteAdminController

Complexity

Conditions	2
Paths	2

Size

Total Lines	16
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	16
rs	9.4285
cc	2
eloc	10
nc	2
nop	2

<?php

/**
 * @package EvernoteSettings
 */
class EvernoteAdminController extends LeftAndMain
namespace YourVendor;

class YourClass { }
{

    /**
     * @var string
     */
    private static $url_segment = 'evernote-settings';

    /**
     * @var string
     */
    private static $url_rule = '/$Action/$ID/$OtherID';


    /**
     * @var string
     */
    private static $menu_title = 'Evernote';

    /**
     * @var string
     */
    private static $menu_icon = '/silverstripe-evernote/images/evernote.png';



    /**
     * @param null $id Not used.
     * @param null $fields Not used.
     *
     * @return Form
     */
    public function getEditForm($id = null, $fields = null)
    {

        $evernoteSettings = EvernoteSettings::current_Evernote_settings();
        $fields = $evernoteSettings->getCMSFields();

        // Retrieve validator, if one has been setup
        if ($evernoteSettings->hasMethod("getCMSValidator")) {
            $validator = $evernoteSettings->getCMSValidator();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        } else {
            $validator = null;
        }

        $actions = $evernoteSettings->getCMSActions();

        $form = CMSForm::create(
            $this, 'EditForm', $fields, $actions, $validator
        )->setHTMLID('Form_EditForm');

        $form->setResponseNegotiator($this->getResponseNegotiator());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $form->addExtraClass('cms-content center cms-edit-form');
        $form->setTemplate($this->getTemplatesWithSuffix('_EditForm'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        if ($form->Fields()->hasTabset()) $form->Fields()->findOrMakeTab('Root')->setTemplate('CMSTabSet');

        $form->addExtraClass('center ss-tabset cms-tabset ' . $this->BaseCSSClasses());
        $form->setAttribute('data-pjax-fragment', 'CurrentForm');

        $this->extend('updateEditForm', $form);

        return $form;

    }

    /**
     * Save the current sites {@link SiteConfig} into the database.
     *
     * @param array $data
     * @param Form $form
     * @return String
     */
    public function save_evernotesettings($data, $form)

    {
        $evernoteSettings = EvernoteSettings::current_Evernote_settings();
        $form->saveInto($evernoteSettings);

        try {
            $evernoteSettings->write();
        } catch (ValidationException $ex) {
            $form->sessionMessage($ex->getResult()->message(), 'bad');
            return $this->getResponseNegotiator()->respond($this->request);
        }

        $this->response->addHeader('X-Status', rawurlencode(_t('LeftAndMain.SAVEDUP', 'Saved.')));

        return $form->forTemplate();
    }

}


1			<?php
2
3			/**
4			* @package EvernoteSettings
5			*/
6			class EvernoteAdminController extends LeftAndMain
			0 ignored issues – show Coding Style Compatibility introduced 2016-08-28 03:41 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
7			{
8
9			/**
10			* @var string
11			*/
12			private static $url_segment = 'evernote-settings';
			0 ignored issues – show Comprehensibility introduced 2016-08-28 03:41 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2016-08-28 03:41 UTC by Report Bug Copy Issue Report The property `$url_segment` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
13			/**
14			* @var string
15			*/
16			private static $url_rule = '/$Action/$ID/$OtherID';
			0 ignored issues – show Comprehensibility introduced 2016-08-28 03:41 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2016-08-28 03:41 UTC by Report Bug Copy Issue Report The property `$url_rule` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
17
18			/**
19			* @var string
20			*/
21			private static $menu_title = 'Evernote';
			0 ignored issues – show Comprehensibility introduced 2016-08-28 03:41 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2016-08-28 03:41 UTC by Report Bug Copy Issue Report The property `$menu_title` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
22			/**
23			* @var string
24			*/
25			private static $menu_icon = '/silverstripe-evernote/images/evernote.png';
			0 ignored issues – show Comprehensibility introduced 2016-08-28 03:41 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2016-08-28 03:41 UTC by Report Bug Copy Issue Report The property `$menu_icon` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
26
27
28			/**
29			* @param null $id Not used.
30			* @param null $fields Not used.
31			*
32			* @return Form
33			*/
34			public function getEditForm($id = null, $fields = null)
35			{
36
37			$evernoteSettings = EvernoteSettings::current_Evernote_settings();
38			$fields = $evernoteSettings->getCMSFields();
39
40			// Retrieve validator, if one has been setup
41			if ($evernoteSettings->hasMethod("getCMSValidator")) {
42			$validator = $evernoteSettings->getCMSValidator();
			0 ignored issues – show Documentation Bug introduced 2016-08-28 03:41 UTC by Report Bug Copy Issue Report The method `getCMSValidator` does not exist on `object<EvernoteSettings>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
43			} else {
44			$validator = null;
45			}
46
47			$actions = $evernoteSettings->getCMSActions();
48
49			$form = CMSForm::create(
50			$this, 'EditForm', $fields, $actions, $validator
51			)->setHTMLID('Form_EditForm');
52
53			$form->setResponseNegotiator($this->getResponseNegotiator());
			0 ignored issues – show Documentation introduced 2016-08-28 03:41 UTC by Report Bug Copy Issue Report `$this->getResponseNegotiator()` is of type `object<PjaxResponseNegotiator>`, but the function expects a `object<ResponseNegotiator>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
54			$form->addExtraClass('cms-content center cms-edit-form');
55			$form->setTemplate($this->getTemplatesWithSuffix('_EditForm'));
			0 ignored issues – show Documentation introduced 2016-08-28 03:41 UTC by Report Bug Copy Issue Report `$this->getTemplatesWithSuffix('_EditForm')` is of type `array`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
56
57			if ($form->Fields()->hasTabset()) $form->Fields()->findOrMakeTab('Root')->setTemplate('CMSTabSet');
58
59			$form->addExtraClass('center ss-tabset cms-tabset ' . $this->BaseCSSClasses());
60			$form->setAttribute('data-pjax-fragment', 'CurrentForm');
61
62			$this->extend('updateEditForm', $form);
63
64			return $form;
65
66			}
67
68			/**
69			* Save the current sites {@link SiteConfig} into the database.
70			*
71			* @param array $data
72			* @param Form $form
73			* @return String
74			*/
75			public function save_evernotesettings($data, $form)
			0 ignored issues – show Unused Code introduced 2016-08-28 03:41 UTC by Report Bug Copy Issue Report The parameter `$data` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
76			{
77			$evernoteSettings = EvernoteSettings::current_Evernote_settings();
78			$form->saveInto($evernoteSettings);
79
80			try {
81			$evernoteSettings->write();
82			} catch (ValidationException $ex) {
83			$form->sessionMessage($ex->getResult()->message(), 'bad');
84			return $this->getResponseNegotiator()->respond($this->request);
85			}
86
87			$this->response->addHeader('X-Status', rawurlencode(_t('LeftAndMain.SAVEDUP', 'Saved.')));
88
89			return $form->forTemplate();
90			}
91
92			}
93

ishannz / silverstripe-evernote

EvernoteAdminController::save_evernotesettings() A last analyzed 2016-08-28 03:50 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

EvernoteAdminController::save_evernotesettings() A
last analyzed 2016-08-28 03:50 UTC