EvernoteAuthController

Complexity

Total Complexity

5

Size/Duplication

Total Lines	49
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	5

Importance

Changes	2
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	login()	0	11	2
A	callback()	0	20	3

<?php

class EvernoteAuthController extends Controller {

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

    /**
     * @var array
     */
    private static $allowed_actions = array(

Consider using a different property name as you override a private property of the parent class.

The property $allowed_actions is not used and could be removed.

        'login','callback',
    );

    /**
     * authenticate with Evernote
     */
    public function login() {

        if( $member = Member::currentUser() ) {

$member is not used, you could remove the assignment.

            $Evernote = new Evernote();
            $Evernote->Authorize();

        } else {

            $this->redirect('Security/login/?back=evernote-auth/login');
        }
    }

    /**
     * store token from Evernote and redirect to given url or redirect to home page
     */
    public function callback() {

        if( $member = Member::currentUser() ) {
            $Evernote = new Evernote();
            $Token = $Evernote->Authorize();

            $member->EvernoteToken = $Token;
            $member->write();

            $EvernoteSettings = EvernoteSettings::current_Evernote_settings();

            $url = (!empty($EvernoteSettings->CallbackURL)) ?: '/';

            $this->redirect($url);

        } else {

            $this->redirect('Security/login/?back=evernote-auth/login');
        }
    }

}