for testing and deploying your application
for finding and fixing issues
for empowering human code reviews
<?php
class EvernoteAuthController extends Controller {
You can fix this by adding a namespace to your class:
namespace YourVendor; class YourClass { }
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.
/**
* @var array
*/
private static $allowed_actions = array(
$allowed_actions
This check marks private properties in classes that are never used. Those properties can be removed.
'login','callback',
);
* authenticate with Evernote
public function login() {
if( $member = Member::currentUser() ) {
$member
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
$myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; }
Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.
$myVar
$higher
$Evernote = new Evernote();
$Evernote->Authorize();
} else {
$this->redirect('Security/login/?back=evernote-auth/login');
}
* store token from Evernote and redirect to given url or redirect to home page
public function callback() {
$Token = $Evernote->Authorize();
$member->EvernoteToken = $Token;
$member->write();
$EvernoteSettings = EvernoteSettings::current_Evernote_settings();
$url = (!empty($EvernoteSettings->CallbackURL)) ?: '/';
$this->redirect($url);
ishannz /
silverstripe-evernote
Loading history...
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.