EvernoteAuthController::callback() - Code Metrics - ishannz/silverstripe-evernote - Measure and Improve Code Quality continuously with Scrutinizer

EvernoteAuthController::callback() A
last analyzed 2016-08-28 03:50 UTC

↳ Parent: EvernoteAuthController

Complexity

Conditions	3
Paths	3

Size

Total Lines	20
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	20
rs	9.4285
cc	3
eloc	11
nc	3
nop	0

<?php

class EvernoteAuthController extends Controller {
namespace YourVendor;

class YourClass { }

    /**
     * @var array
     */
    private static $allowed_actions = array(

        'login','callback',
    );

    /**
     * authenticate with Evernote
     */
    public function login() {

        if( $member = Member::currentUser() ) {
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $Evernote = new Evernote();
            $Evernote->Authorize();

        } else {

            $this->redirect('Security/login/?back=evernote-auth/login');
        }
    }

    /**
     * store token from Evernote and redirect to given url or redirect to home page
     */
    public function callback() {

        if( $member = Member::currentUser() ) {
            $Evernote = new Evernote();
            $Token = $Evernote->Authorize();

            $member->EvernoteToken = $Token;
            $member->write();

            $EvernoteSettings = EvernoteSettings::current_Evernote_settings();

            $url = (!empty($EvernoteSettings->CallbackURL)) ?: '/';

            $this->redirect($url);

        } else {

            $this->redirect('Security/login/?back=evernote-auth/login');
        }
    }

}

1			<?php
2
3			class EvernoteAuthController extends Controller {
			0 ignored issues – show Coding Style Compatibility introduced 2016-08-28 03:41 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4
5			/**
6			* @var array
7			*/
8			private static $allowed_actions = array(
			0 ignored issues – show Comprehensibility introduced 2016-08-28 03:41 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2016-08-28 03:41 UTC by Report Bug Copy Issue Report The property `$allowed_actions` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
9			'login','callback',
10			);
11
12			/**
13			* authenticate with Evernote
14			*/
15			public function login() {
16
17			if( $member = Member::currentUser() ) {
			0 ignored issues – show Unused Code introduced 2016-08-28 03:41 UTC by Report Bug Copy Issue Report `$member` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
18			$Evernote = new Evernote();
19			$Evernote->Authorize();
20
21			} else {
22
23			$this->redirect('Security/login/?back=evernote-auth/login');
24			}
25			}
26
27			/**
28			* store token from Evernote and redirect to given url or redirect to home page
29			*/
30			public function callback() {
31
32			if( $member = Member::currentUser() ) {
33			$Evernote = new Evernote();
34			$Token = $Evernote->Authorize();
35
36			$member->EvernoteToken = $Token;
37			$member->write();
38
39			$EvernoteSettings = EvernoteSettings::current_Evernote_settings();
40
41			$url = (!empty($EvernoteSettings->CallbackURL)) ?: '/';
42
43			$this->redirect($url);
44
45			} else {
46
47			$this->redirect('Security/login/?back=evernote-auth/login');
48			}
49			}
50
51			}

ishannz / silverstripe-evernote

EvernoteAuthController::callback() A last analyzed 2016-08-28 03:50 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

EvernoteAuthController::callback() A
last analyzed 2016-08-28 03:50 UTC