Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 9 | class Mission extends Game |
||
| 10 | { |
||
| 11 | |||
| 12 | /** |
||
| 13 | * @var MissionMapperInterface |
||
| 14 | */ |
||
| 15 | protected $missionMapper; |
||
| 16 | |||
| 17 | /** |
||
| 18 | * @var MissionGameMapperInterface |
||
| 19 | */ |
||
| 20 | protected $missionGameMapper; |
||
| 21 | |||
| 22 | protected $options; |
||
| 23 | |||
| 24 | /** |
||
| 25 | * Find games associated to a mission and add the last entry of the user if it exists |
||
| 26 | * @param unknown $mission |
||
| 27 | * @return multitype:NULL |
||
|
|
|||
| 28 | */ |
||
| 29 | public function getMissionGames($mission, $user) |
||
| 41 | |||
| 42 | /** |
||
| 43 | * findMissionGameByMission : find associated games to a mission |
||
| 44 | * @param Mission $mission |
||
| 45 | * |
||
| 46 | * @return Collection de MissionGame $missionGames |
||
| 47 | */ |
||
| 48 | public function findGamesByMission($mission) |
||
| 52 | |||
| 53 | View Code Duplication | public function checkMissionCondition($game, $winner, $prediction, $entry) |
|
| 121 | |||
| 122 | public function getGameEntity() |
||
| 126 | |||
| 127 | /** |
||
| 128 | * getMissionMapper |
||
| 129 | * |
||
| 130 | * @return MissionMapperInterface |
||
| 131 | */ |
||
| 132 | public function getMissionMapper() |
||
| 140 | |||
| 141 | /** |
||
| 142 | * setMissionMapper |
||
| 143 | * |
||
| 144 | * @param MissionMapperInterface $missionMapper |
||
| 145 | * @return Mission |
||
| 146 | */ |
||
| 147 | public function setMissionMapper($missionMapper) |
||
| 153 | |||
| 154 | /** |
||
| 155 | * getMissionGameMapper |
||
| 156 | * |
||
| 157 | * @return MissionGameMapperInterface |
||
| 158 | */ |
||
| 159 | View Code Duplication | public function getMissionGameMapper() |
|
| 167 | |||
| 168 | /** |
||
| 169 | * setMissionMapper |
||
| 170 | * |
||
| 171 | * @param MissionMapperInterface $missionGameMapper |
||
| 172 | * @return Mission |
||
| 173 | */ |
||
| 174 | public function setMissionGameMapper($missionGameMapper) |
||
| 180 | } |
||
| 181 |
This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types.