chillerlan\Traits\Crypto\SealedBox

Complexity

Total Complexity

3

Size/Duplication

Total Lines	26
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	open()	0	14	2
A	create()	0	8	1

<?php
/**
 * Class SealedBox
 *
 * @filesource   SealedBox.php
 * @created      25.01.2018
 * @package      chillerlan\Traits\Crypto
 * @author       Smiley <smiley@chillerlan.net>
 * @copyright    2018 Smiley
 * @license      MIT
 */

namespace chillerlan\Traits\Crypto;

class SealedBox extends CryptoBox{

	public function create(string $message):CryptoBoxInterface{
		$this->checkKeypair(null, SODIUM_CRYPTO_BOX_PUBLICKEYBYTES);

		$this->box = sodium_crypto_box_seal($this->checkMessage($message), $this->keypair->public);

Accessing public on the interface chillerlan\Traits\Crypto\CryptoKeyInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

		sodium_memzero($message);

		return $this;
	}

	public function open(string $box_bin):CryptoBoxInterface{
		$this->checkKeypair(SODIUM_CRYPTO_BOX_SECRETKEYBYTES, SODIUM_CRYPTO_BOX_PUBLICKEYBYTES);

		$keypair       = sodium_crypto_box_keypair_from_secretkey_and_publickey($this->keypair->secret, $this->keypair->public);

Accessing public on the interface chillerlan\Traits\Crypto\CryptoKeyInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

Accessing secret on the interface chillerlan\Traits\Crypto\CryptoKeyInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

		$this->message = sodium_crypto_box_seal_open($box_bin, $keypair);

		sodium_memzero($keypair);
		sodium_memzero($box_bin);

		if($this->message === false){

The condition $this->message === false can never be true.

			throw new CryptoException('invalid box');
		}

		return $this;
	}

}