chillerlan\Traits\Crypto\SealedBox::open()

Complexity

Conditions	2
Paths	2

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
	public function open(string $box_bin):CryptoBoxInterface{
		$this->checkKeypair(SODIUM_CRYPTO_BOX_SECRETKEYBYTES, SODIUM_CRYPTO_BOX_PUBLICKEYBYTES);

		$keypair       = sodium_crypto_box_keypair_from_secretkey_and_publickey($this->keypair->secret, $this->keypair->public);

Accessing public on the interface chillerlan\Traits\Crypto\CryptoKeyInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

Accessing secret on the interface chillerlan\Traits\Crypto\CryptoKeyInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

		$this->message = sodium_crypto_box_seal_open($box_bin, $keypair);

		sodium_memzero($keypair);
		sodium_memzero($box_bin);

		if($this->message === false){

The condition $this->message === false can never be true.

			throw new CryptoException('invalid box');
		}

		return $this;
	}