SealedBox::create() - Code Metrics - Inspection of ":sparkles:" - chillerlan/php-traits - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d732f2...827150 )

by smiley

created 2018-01-25 05:30 UTC

SealedBox::create() A

↳ Parent: SealedBox

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	4
nc	1
nop	1

<?php
/**
 * Class SealedBox
 *
 * @filesource   SealedBox.php
 * @created      25.01.2018
 * @package      chillerlan\Traits\Crypto
 * @author       Smiley <[email protected]>
 * @copyright    2018 Smiley
 * @license      MIT
 */

namespace chillerlan\Traits\Crypto;

class SealedBox extends CryptoBox{

	public function create(string $message):CryptoBoxInterface{
		$this->checkKeypair(null, SODIUM_CRYPTO_BOX_PUBLICKEYBYTES);

		$this->box = sodium_crypto_box_seal($this->checkMessage($message), $this->keypair->public);


		sodium_memzero($message);

		return $this;
	}

	public function open(string $box_bin):CryptoBoxInterface{
		$this->checkKeypair(SODIUM_CRYPTO_BOX_SECRETKEYBYTES, SODIUM_CRYPTO_BOX_PUBLICKEYBYTES);

		$keypair       = sodium_crypto_box_keypair_from_secretkey_and_publickey($this->keypair->secret, $this->keypair->public);

		$this->message = sodium_crypto_box_seal_open($box_bin, $keypair);

		sodium_memzero($keypair);
		sodium_memzero($box_bin);

		if($this->message === false){

			throw new CryptoException('invalid box');
		}

		return $this;
	}

}


1			<?php
2			/**
3			* Class SealedBox
4			*
5			* @filesource SealedBox.php
6			* @created 25.01.2018
7			* @package chillerlan\Traits\Crypto
8			* @author Smiley <[email protected]>
9			* @copyright 2018 Smiley
10			* @license MIT
11			*/
12
13			namespace chillerlan\Traits\Crypto;
14
15			class SealedBox extends CryptoBox{
16
17			public function create(string $message):CryptoBoxInterface{
18			$this->checkKeypair(null, SODIUM_CRYPTO_BOX_PUBLICKEYBYTES);
19
20			$this->box = sodium_crypto_box_seal($this->checkMessage($message), $this->keypair->public);
			0 ignored issues – show Bug introduced 2018-01-25 05:32 UTC by Report Bug Copy Issue Report Accessing `public` on the interface `chillerlan\Traits\Crypto\CryptoKeyInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
21
22			sodium_memzero($message);
23
24			return $this;
25			}
26
27			public function open(string $box_bin):CryptoBoxInterface{
28			$this->checkKeypair(SODIUM_CRYPTO_BOX_SECRETKEYBYTES, SODIUM_CRYPTO_BOX_PUBLICKEYBYTES);
29
30			$keypair = sodium_crypto_box_keypair_from_secretkey_and_publickey($this->keypair->secret, $this->keypair->public);
			0 ignored issues – show Bug introduced 2018-01-25 05:32 UTC by Report Bug Copy Issue Report Accessing `public` on the interface `chillerlan\Traits\Crypto\CryptoKeyInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history... Bug introduced 2018-01-25 05:32 UTC by Report Bug Copy Issue Report Accessing `secret` on the interface `chillerlan\Traits\Crypto\CryptoKeyInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
31			$this->message = sodium_crypto_box_seal_open($box_bin, $keypair);
32
33			sodium_memzero($keypair);
34			sodium_memzero($box_bin);
35
36			if($this->message === false){
			0 ignored issues – show introduced 2018-01-25 05:32 UTC by Report Bug Copy Issue Report The condition `$this->message === false` can never be `true`. Loading history...
37			throw new CryptoException('invalid box');
38			}
39
40			return $this;
41			}
42
43			}
44

chillerlan / php-traits

Push — master ( d732f2...827150 )

SealedBox::create() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like