bmitch / Codor

src/Codor/Sniffs/Classes/ExtendsSniff.php

Spacing +3 added lines, -3 removed lines

@@ -19,7 +19,7 @@ 
      */
     public function register(): array
     {
-        return [T_CLASS];
+        return [ T_CLASS ];
     }
 
     /**
@@ -46,10 +46,10 @@ 
      */
     protected function handleToken($token)
     {
-        if ($token['type'] !== 'T_EXTENDS') {
+        if ($token[ 'type' ] !== 'T_EXTENDS') {
             return;
         }
         $warning = "Class extends another class - consider composition over inheritance.";
-        $this->phpcsFile->addWarning($warning, $token['line'], __CLASS__);
+        $this->phpcsFile->addWarning($warning, $token[ 'line' ], __CLASS__);
     }
 }

src/Codor/Sniffs/Classes/FinalPrivateSniff.php

Spacing +14 added lines, -14 removed lines

@@ -16,7 +16,7 @@ 
      */
     public function register(): array
     {
-        return [T_CLASS];
+        return [ T_CLASS ];
     }
 
     /**
@@ -29,13 +29,13 @@ 
      * List of protected methods found.
      * @var array
      */
-    protected $protectedMethodTokens = [];
+    protected $protectedMethodTokens = [ ];
 
     /**
      * List of protected variables found.
      * @var array
      */
-    protected $protectedVariableTokens = [];
+    protected $protectedVariableTokens = [ ];
 
     /**
      * Processes the tokens that this sniff is interested in.
@@ -49,8 +49,8 @@ 
     public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
     {
         $this->classIsMarkedFinal = false;
-        $this->protectedMethodTokens = [];
-        $this->protectedVariableTokens = [];
+        $this->protectedMethodTokens = [ ];
+        $this->protectedVariableTokens = [ ];
 
         $tokens = $phpcsFile->getTokens();
 
@@ -69,14 +69,14 @@ 
      */
     protected function handleToken($tokens, $index)
     {
-        $tokenType = $tokens[$index]['type'];
+        $tokenType = $tokens[ $index ][ 'type' ];
 
         if ($tokenType === 'T_FINAL') {
             $this->classIsMarkedFinal = true;
             return;
         }
 
-        if (! $this->classIsMarkedFinal) {
+        if (!$this->classIsMarkedFinal) {
             return;
         }
 
@@ -96,14 +96,14 @@ 
      */
     protected function handleFoundProtectedElement($tokens, $index)
     {
-        $type = $tokens[$index+2]['type'];
+        $type = $tokens[ $index + 2 ][ 'type' ];
 
         if ($type === 'T_VARIABLE') {
-            $this->protectedVariableTokens[] = $tokens[$index+2];
+            $this->protectedVariableTokens[ ] = $tokens[ $index + 2 ];
             return;
         }
 
-        $this->protectedMethodTokens[] = $tokens[$index+4];
+        $this->protectedMethodTokens[ ] = $tokens[ $index + 4 ];
     }
 
     /**
@@ -131,8 +131,8 @@ 
      */
     protected function handleProtectedMethodToken($token, $phpcsFile)
     {
-        $methodName = $token['content'];
-        $line = $token['line'];
+        $methodName = $token[ 'content' ];
+        $line = $token[ 'line' ];
         $phpcsFile->addError("Final Class contains a protected method {$methodName} - should be private.", $line, __CLASS__);
     }
 
@@ -144,8 +144,8 @@ 
      */
     protected function handleProtectedVariableToken($token, $phpcsFile)
     {
-        $variableName = $token['content'];
-        $line = $token['line'];
+        $variableName = $token[ 'content' ];
+        $line = $token[ 'line' ];
         $phpcsFile->addError("Final Class contains a protected variable {$variableName} - should be private.", $line, __CLASS__);
     }
 }

src/Codor/Sniffs/Classes/ConstructorLoopSniff.php

Spacing +8 added lines, -8 removed lines

@@ -12,7 +12,7 @@ 
      * The loop tokens we're lookin for.
      * @var array
      */
-    protected $loops = ['T_FOR', 'T_FOREACH', 'T_WHILE'];
+    protected $loops = [ 'T_FOR', 'T_FOREACH', 'T_WHILE' ];
 
     /**
      * Returns the token types that this sniff is interested in.
@@ -20,7 +20,7 @@ 
      */
     public function register(): array
     {
-        return [T_FUNCTION];
+        return [ T_FUNCTION ];
     }
 
     /**
@@ -34,20 +34,20 @@ 
     public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
     {
         $tokens            = $phpcsFile->getTokens();
-        $token             = $tokens[$stackPtr];
-        $functionNameToken = $tokens[$stackPtr + 2];
-        $functionName      = $functionNameToken['content'];
+        $token             = $tokens[ $stackPtr ];
+        $functionNameToken = $tokens[ $stackPtr + 2 ];
+        $functionName      = $functionNameToken[ 'content' ];
 
         if ($functionName !== '__construct') {
             return;
         }
         // If this is an interface we don't check it.
-        if (! isset($token['scope_opener'])) {
+        if (!isset($token[ 'scope_opener' ])) {
             return;
         }
 
-        for ($index=$token['scope_opener']; $index <= $token['scope_closer']; $index++) {
-            if (in_array($tokens[$index]['type'], $this->loops)) {
+        for ($index = $token[ 'scope_opener' ]; $index <= $token[ 'scope_closer' ]; $index++) {
+            if (in_array($tokens[ $index ][ 'type' ], $this->loops)) {
                 $phpcsFile->addError("Class constructor cannot contain a loop.", $stackPtr, __CLASS__);
                 continue;
             }

src/Codor/Sniffs/Classes/ClassLengthSniff.php

Spacing +5 added lines, -5 removed lines

@@ -21,7 +21,7 @@ 
      */
     public function register(): array
     {
-        return [T_CLASS];
+        return [ T_CLASS ];
     }
 
     /**
@@ -35,12 +35,12 @@ 
     public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
     {
         $tokens = $phpcsFile->getTokens();
-        $token = $tokens[$stackPtr];
+        $token = $tokens[ $stackPtr ];
         
-        $openParenthesis = $tokens[$token['scope_opener']];
-        $closedParenthesis = $tokens[$token['scope_closer']];
+        $openParenthesis = $tokens[ $token[ 'scope_opener' ] ];
+        $closedParenthesis = $tokens[ $token[ 'scope_closer' ] ];
 
-        $length = $closedParenthesis['line'] - $openParenthesis['line'];
+        $length = $closedParenthesis[ 'line' ] - $openParenthesis[ 'line' ];
 
         if ($length > $this->maxLength) {
             $phpcsFile->addError("Class is {$length} lines. Must be {$this->maxLength} lines or fewer.", $stackPtr, __CLASS__);

src/Codor/Sniffs/ControlStructures/NoElseSniff.php

Spacing +2 added lines, -2 removed lines

@@ -17,7 +17,7 @@ 
      */
     public function register(): array
     {
-        return [T_ELSE, T_ELSEIF];
+        return [ T_ELSE, T_ELSEIF ];
     }
 
     /**
@@ -30,6 +30,6 @@ 
      */
     public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
     {
-        $phpcsFile->addError('Do not use "else" or "elseif"', $stackPtr,  __CLASS__);
+        $phpcsFile->addError('Do not use "else" or "elseif"', $stackPtr, __CLASS__);
     }
 }

src/Codor/Sniffs/ControlStructures/NestedIfSniff.php

Spacing +10 added lines, -10 removed lines

@@ -14,7 +14,7 @@ 
      */
     public function register(): array
     {
-        return [T_IF];
+        return [ T_IF ];
     }
 
     /**
@@ -41,13 +41,13 @@ 
     {
         $this->phpcsFile = $phpcsFile;
         $tokens          = $phpcsFile->getTokens();
-        $token           = $tokens[$stackPtr];
-        $start           = $token['scope_opener'];
-        $end             = $token['scope_closer'];
+        $token           = $tokens[ $stackPtr ];
+        $start           = $token[ 'scope_opener' ];
+        $end             = $token[ 'scope_closer' ];
 
-        $this->errorStack = [];
-        for ($index=$start; $index <= $end; $index++) {
-            $this->checkForNestedIf($tokens[$index], $stackPtr);
+        $this->errorStack = [ ];
+        for ($index = $start; $index <= $end; $index++) {
+            $this->checkForNestedIf($tokens[ $index ], $stackPtr);
         }
     }
 
@@ -59,7 +59,7 @@ 
      */
     protected function checkForNestedIf(array $token, int $stackPtr)
     {
-        if (! $this->isIfStatement($token)) {
+        if (!$this->isIfStatement($token)) {
             return;
         }
 
@@ -68,7 +68,7 @@ 
         }
 
         $this->phpcsFile->addError('Nested if statement found.', $stackPtr, __CLASS__);
-        $this->errorStack[] = $stackPtr;
+        $this->errorStack[ ] = $stackPtr;
     }
 
     /**
@@ -93,7 +93,7 @@ 
      */
     protected function isIfStatement(array $token): bool
     {
-        if ($token['type'] === 'T_IF') {
+        if ($token[ 'type' ] === 'T_IF') {
             return true;
         }
 

src/Codor/Sniffs/Files/ReturnNullSniff.php

Spacing +4 added lines, -4 removed lines

@@ -14,7 +14,7 @@ 
      */
     public function register(): array
     {
-        return [T_RETURN];
+        return [ T_RETURN ];
     }
 
     /**
@@ -30,13 +30,13 @@ 
         $returnTokenIndex = $stackPtr;
 
         $scope = array_slice($tokens, $returnTokenIndex, null, true);
-        $semicolons = array_filter($scope, function ($token) {
-            return $token['type'] === 'T_SEMICOLON';
+        $semicolons = array_filter($scope, function($token) {
+            return $token[ 'type' ] === 'T_SEMICOLON';
         });
 
         $returnValueIndex = key($semicolons) - 1;
 
-        if ($scope[$returnValueIndex]['type'] === 'T_NULL') {
+        if ($scope[ $returnValueIndex ][ 'type' ] === 'T_NULL') {
             $error = "Return null value found.";
             $phpcsFile->addError($error, $returnValueIndex, __CLASS__);
         }

src/Codor/Sniffs/Files/FunctionParameterSniff.php

Spacing +8 added lines, -8 removed lines

@@ -20,7 +20,7 @@ 
      */
     public function register(): array
     {
-        return [T_FUNCTION];
+        return [ T_FUNCTION ];
     }
 
     /**
@@ -34,21 +34,21 @@ 
     public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
     {
         $tokens           = $phpcsFile->getTokens();
-        $token            = $tokens[$stackPtr];
-        $openParenIndex   = $token['parenthesis_opener'];
-        $closedParenIndex = $token['parenthesis_closer'];
+        $token            = $tokens[ $stackPtr ];
+        $openParenIndex   = $token[ 'parenthesis_opener' ];
+        $closedParenIndex = $token[ 'parenthesis_closer' ];
 
         $numberOfParameters = 0;
-        for ($index=$openParenIndex+1; $index <= $closedParenIndex; $index++) {
-            $tokens[$index]['type'] == 'T_VARIABLE' ? $numberOfParameters++ : null;
+        for ($index = $openParenIndex + 1; $index <= $closedParenIndex; $index++) {
+            $tokens[ $index ][ 'type' ] == 'T_VARIABLE' ? $numberOfParameters++ : null;
         }
 
         if ($numberOfParameters > $this->maxParameters) {
-            $phpcsFile->addError("Function has more than {$this->maxParameters} parameters. Please reduce.", $stackPtr, __CLASS__ . 'MoreThan');
+            $phpcsFile->addError("Function has more than {$this->maxParameters} parameters. Please reduce.", $stackPtr, __CLASS__.'MoreThan');
         }
 
         if ($numberOfParameters == $this->maxParameters) {
-            $phpcsFile->addWarning("Function has {$this->maxParameters} parameters.", $stackPtr, __CLASS__ . 'hasMax');
+            $phpcsFile->addWarning("Function has {$this->maxParameters} parameters.", $stackPtr, __CLASS__.'hasMax');
         }
     }
 }

src/Codor/Sniffs/Files/MethodFlagParameterSniff.php

Spacing +7 added lines, -7 removed lines

@@ -12,7 +12,7 @@ 
      * The two token types we're looking for.
      * @var array
      */
-    protected $booleans = ['T_FALSE', 'T_TRUE'];
+    protected $booleans = [ 'T_FALSE', 'T_TRUE' ];
 
     /**
      * Returns the token types that this sniff is interested in.
@@ -20,7 +20,7 @@ 
      */
     public function register(): array
     {
-        return [T_FUNCTION];
+        return [ T_FUNCTION ];
     }
 
     /**
@@ -35,12 +35,12 @@ 
     {
         $tokens           = $phpcsFile->getTokens();
 
-        $token            = $tokens[$stackPtr];
-        $openParenIndex   = $token['parenthesis_opener'];
-        $closedParenIndex = $token['parenthesis_closer'];
+        $token            = $tokens[ $stackPtr ];
+        $openParenIndex   = $token[ 'parenthesis_opener' ];
+        $closedParenIndex = $token[ 'parenthesis_closer' ];
 
-        for ($index=$openParenIndex+1; $index <= $closedParenIndex; $index++) {
-            if (in_array($tokens[$index]['type'], $this->booleans)) {
+        for ($index = $openParenIndex + 1; $index <= $closedParenIndex; $index++) {
+            if (in_array($tokens[ $index ][ 'type' ], $this->booleans)) {
                 $phpcsFile->addError("Function/method contains a flag parameter.", $stackPtr, __CLASS__);
                 continue;
             }