bmitch / Codor

src/Codor/Sniffs/Files/FunctionLengthSniff.php

Spacing +7 added lines, -7 removed lines

@@ -21,7 +21,7 @@ 
      */
     public function register(): array
     {
-        return [T_FUNCTION];
+        return [ T_FUNCTION ];
     }
 
     /**
@@ -35,19 +35,19 @@ 
     public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
     {
         $tokens = $phpcsFile->getTokens();
-        $token = $tokens[$stackPtr];
+        $token = $tokens[ $stackPtr ];
 
         // Skip function without body.
-        if (isset($token['scope_opener']) === false) {
+        if (isset($token[ 'scope_opener' ]) === false) {
             return;
         }
 
-        $firstToken = $tokens[$token['scope_opener']];
-        $lastToken = $tokens[$token['scope_closer']];
-        $length = $lastToken['line'] - $firstToken['line'];
+        $firstToken = $tokens[ $token[ 'scope_opener' ] ];
+        $lastToken = $tokens[ $token[ 'scope_closer' ] ];
+        $length = $lastToken[ 'line' ] - $firstToken[ 'line' ];
 
         if ($length > $this->maxLength) {
-            $tokenType = strtolower(substr($token['type'], 2));
+            $tokenType = strtolower(substr($token[ 'type' ], 2));
             $error = "Function is {$length} lines. Must be {$this->maxLength} lines or fewer.";
             $phpcsFile->addError($error, $stackPtr, sprintf('%sTooBig', ucfirst($tokenType)));
         }

src/Codor/Sniffs/Files/IndentationLevelSniff.php

Spacing +16 added lines, -16 removed lines

@@ -24,7 +24,7 @@ 
      * It is increased inside try-catch blocks.
      * @var array
      */
-    protected $relativeScopeLevels = [];
+    protected $relativeScopeLevels = [ ];
 
     /**
      * Returns the token types that this sniff is interested in.
@@ -32,7 +32,7 @@ 
      */
     public function register(): array
     {
-        return [T_FUNCTION, T_CLOSURE, T_SWITCH];
+        return [ T_FUNCTION, T_CLOSURE, T_SWITCH ];
     }
 
     /**
@@ -46,11 +46,11 @@ 
     public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
     {
         $tokens = $phpcsFile->getTokens();
-        $token = $tokens[$stackPtr];
+        $token = $tokens[ $stackPtr ];
         $this->maxIndentFound = 0;
 
         // Ignore functions with no body
-        if (isset($token['scope_opener']) === false) {
+        if (isset($token[ 'scope_opener' ]) === false) {
             return;
         }
 
@@ -71,16 +71,16 @@ 
      */
     protected function inspectScope(array $token, array $tokens)
     {
-        $start = $token['scope_opener'];
-        $length = $token['scope_closer'] - $start + 1;
+        $start = $token[ 'scope_opener' ];
+        $length = $token[ 'scope_closer' ] - $start + 1;
 
         $scope = array_slice($tokens, $start, $length, true);
         $scope = $this->removeTokenScopes($scope, 'T_SWITCH');
 
-        $this->setRelativeScopeLevels($scope, $scope[$start]['level']);
+        $this->setRelativeScopeLevels($scope, $scope[ $start ][ 'level' ]);
 
         foreach ($scope as $i => $token) {
-            $this->maxIndentFound = max($this->maxIndentFound, $token['level'] - $this->relativeScopeLevels[$i]);
+            $this->maxIndentFound = max($this->maxIndentFound, $token[ 'level' ] - $this->relativeScopeLevels[ $i ]);
         }
     }
 
@@ -95,16 +95,16 @@ 
     {
         // first set the base level for all tokens
         foreach (array_keys($scope) as $i) {
-            $this->relativeScopeLevels[$i] = $level;
+            $this->relativeScopeLevels[ $i ] = $level;
         }
 
         // then increase the base level by one for all the tokens in a try-catch block
         foreach (array_keys($this->findNestedTokens($scope, 'T_TRY')) as $i) {
-            $this->relativeScopeLevels[$i] += 1;
+            $this->relativeScopeLevels[ $i ] += 1;
         }
 
         foreach (array_keys($this->findNestedTokens($scope, 'T_CATCH')) as $i) {
-            $this->relativeScopeLevels[$i] += 1;
+            $this->relativeScopeLevels[ $i ] += 1;
         }
     }
 
@@ -127,13 +127,13 @@ 
      */
     protected function findNestedTokens(array $scope, string $type): array
     {
-        $typeTokens = array_filter($scope, function ($token) use ($type) {
-            return $token['type'] == $type;
+        $typeTokens = array_filter($scope, function($token) use ($type) {
+            return $token[ 'type' ] == $type;
         });
 
-        $nestedTokens = [];
+        $nestedTokens = [ ];
         foreach ($typeTokens as $token) {
-            $range = array_flip(range($token['scope_opener'], $token['scope_closer']));
+            $range = array_flip(range($token[ 'scope_opener' ], $token[ 'scope_closer' ]));
             $nestedTokens += array_intersect_key($scope, $range);
         }
 
@@ -151,7 +151,7 @@ 
         // indentation limit.
         $indentationFound = $this->maxIndentFound - 1;
         $indentationLimit = $this->indentationLimit - 1;
-        return "{$indentationFound} indentation levels found. " .
+        return "{$indentationFound} indentation levels found. ".
         "Maximum of {$indentationLimit} indentation levels allowed.";
     }
 }

src/Codor/Sniffs/Files/FunctionNameContainsAndOrSniff.php

Spacing +7 added lines, -7 removed lines

@@ -12,7 +12,7 @@ 
      * The forbidden strings this sniff looks for.
      * @var array
      */
-    protected $keywords = ['And', '_and', 'Or', '_or'];
+    protected $keywords = [ 'And', '_and', 'Or', '_or' ];
 
     /**
      * Returns the token types that this sniff is interested in.
@@ -20,7 +20,7 @@ 
      */
     public function register(): array
     {
-        return [T_FUNCTION];
+        return [ T_FUNCTION ];
     }
 
     /**
@@ -34,14 +34,14 @@ 
     public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
     {
         $tokens = $phpcsFile->getTokens();
-        $functionNameToken = $tokens[$stackPtr + 2];
-        $functionName = $functionNameToken['content'];
+        $functionNameToken = $tokens[ $stackPtr + 2 ];
+        $functionName = $functionNameToken[ 'content' ];
 
-        if (! $this->containsKeywords($functionName)) {
+        if (!$this->containsKeywords($functionName)) {
             return;
         }
 
-        if (! $this->ensuingDelimiter($functionName)) {
+        if (!$this->ensuingDelimiter($functionName)) {
             return;
         }
 
@@ -73,7 +73,7 @@ 
     protected function ensuingDelimiter(string $string): bool
     {
         foreach ($this->keywords as $keyword) {
-            if (! $this->contains($keyword, $string)) {
+            if (!$this->contains($keyword, $string)) {
                 continue;
             }
 

src/Codor/Sniffs/Syntax/NullCoalescingSniff.php

Spacing +4 added lines, -4 removed lines

@@ -14,7 +14,7 @@ 
      */
     public function register(): array
     {
-        return [T_ISSET];
+        return [ T_ISSET ];
     }
 
     /**
@@ -49,15 +49,15 @@ 
         $semiColinFound = false;
 
         while (true) {
-            if ($tokens[$index]['type'] == 'T_SEMICOLON') {
+            if ($tokens[ $index ][ 'type' ] == 'T_SEMICOLON') {
                 break;
             }
 
-            if ($tokens[$index]['type'] == 'T_INLINE_THEN') {
+            if ($tokens[ $index ][ 'type' ] == 'T_INLINE_THEN') {
                 $questionMarkFound = true;
             }
 
-            if ($tokens[$index]['type'] == 'T_INLINE_ELSE') {
+            if ($tokens[ $index ][ 'type' ] == 'T_INLINE_ELSE') {
                 $semiColinFound = true;
             }
             $index++;

src/Codor/Sniffs/Classes/PropertyDeclarationSniff.php

Spacing +19 added lines, -19 removed lines

@@ -12,19 +12,19 @@ 
      * The decalred member variables in the class.
      * @var array
      */
-    protected $memberVars = [];
+    protected $memberVars = [ ];
 
     /**
      * The referenced member variables in the class.
      * @var array
      */
-    protected $referencedMemberVars = [];
+    protected $referencedMemberVars = [ ];
 
     /**
      * Visibility Tokens.
      * @var array
      */
-    protected $visibilityTokens = ['T_PRIVATE', 'T_PUBLIC', 'T_PROTECTED'];
+    protected $visibilityTokens = [ 'T_PRIVATE', 'T_PUBLIC', 'T_PROTECTED' ];
 
     /**
      * Holds the value if the class is extended or not.
@@ -38,7 +38,7 @@ 
      */
     public function register(): array
     {
-        return [T_CLASS];
+        return [ T_CLASS ];
     }
 
     /**
@@ -52,8 +52,8 @@ 
      */
     public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
     {
-        $this->memberVars = [];
-        $this->referencedMemberVars = [];
+        $this->memberVars = [ ];
+        $this->referencedMemberVars = [ ];
         $tokens = $phpcsFile->getTokens();
         foreach ($tokens as $index => $token) {
             $this->handleToken($tokens, $index);
@@ -74,9 +74,9 @@ 
      */
     protected function handleToken($tokens, $index)
     {
-        $token = $tokens[$index];
+        $token = $tokens[ $index ];
 
-        if ($token['type'] === 'T_EXTENDS') {
+        if ($token[ 'type' ] === 'T_EXTENDS') {
             $this->isExtendedClass = true;
             return;
         }
@@ -87,7 +87,7 @@ 
         }
 
 
-        if ($token['type'] === 'T_OBJECT_OPERATOR') {
+        if ($token[ 'type' ] === 'T_OBJECT_OPERATOR') {
             $this->handleObjectOperatorToken($tokens, $index);
             return;
         }
@@ -100,7 +100,7 @@ 
      */
     protected function isVisibilityToken($token): bool
     {
-        return in_array($token['type'], $this->visibilityTokens);
+        return in_array($token[ 'type' ], $this->visibilityTokens);
     }
 
     /**
@@ -111,11 +111,11 @@ 
      */
     protected function handleVisibilityToken($tokens, $index)
     {
-        $possibleVariable = $tokens[$index + 2];
-        if ($possibleVariable['type'] !== 'T_VARIABLE') {
+        $possibleVariable = $tokens[ $index + 2 ];
+        if ($possibleVariable[ 'type' ] !== 'T_VARIABLE') {
             return;
         }
-        $this->memberVars[] = str_replace('$', '', $possibleVariable['content']);
+        $this->memberVars[ ] = str_replace('$', '', $possibleVariable[ 'content' ]);
     }
 
     /**
@@ -126,19 +126,19 @@ 
      */
     protected function handleObjectOperatorToken($tokens, $index)
     {
-        $previousToken = $tokens[$index-1];
-        $nextToken = $tokens[$index+1];
-        $tokenAfterNext = $tokens[$index+2];
+        $previousToken = $tokens[ $index - 1 ];
+        $nextToken = $tokens[ $index + 1 ];
+        $tokenAfterNext = $tokens[ $index + 2 ];
 
-        if ($previousToken['content'] !== '$this') {
+        if ($previousToken[ 'content' ] !== '$this') {
             return;
         }
 
-        if (($tokenAfterNext['type'] !== 'T_WHITESPACE') && ($tokenAfterNext['type'] !== 'T_EQUAL')) {
+        if (($tokenAfterNext[ 'type' ] !== 'T_WHITESPACE') && ($tokenAfterNext[ 'type' ] !== 'T_EQUAL')) {
             return;
         }
 
-        $this->referencedMemberVars[] = $nextToken['content'];
+        $this->referencedMemberVars[ ] = $nextToken[ 'content' ];
     }
 
     /**

src/Codor/Sniffs/TypeHints/MixedReturnTypeSniff.php

Spacing +10 added lines, -10 removed lines

@@ -18,7 +18,7 @@ 
      */
     public function register(): array
     {
-        return [T_FUNCTION];
+        return [ T_FUNCTION ];
     }
 
     /**
@@ -36,11 +36,11 @@ 
 
         $commentEnd = $this->findCommentEnd($phpcsFile, $stackPtr, $tokens);
 
-        if (empty($tokens[$commentEnd]['comment_opener'])) {
+        if (empty($tokens[ $commentEnd ][ 'comment_opener' ])) {
             return;
         }
 
-        $commentStart = $tokens[$commentEnd]['comment_opener'];
+        $commentStart = $tokens[ $commentEnd ][ 'comment_opener' ];
 
         $this->processReturn($phpcsFile, $commentStart);
     }
@@ -86,8 +86,8 @@ 
      */
     private function findReturnTag(array $tokens, int $commentStart)
     {
-        return array_reduce($tokens[$commentStart]['comment_tags'], function ($carry, $tag) use ($tokens) {
-            return $carry || ($tokens[$tag]['content'] === self::RETURN_TAG_NAME) ? $tag : false;
+        return array_reduce($tokens[ $commentStart ][ 'comment_tags' ], function($carry, $tag) use ($tokens) {
+            return $carry || ($tokens[ $tag ][ 'content' ] === self::RETURN_TAG_NAME) ? $tag : false;
         }, false);
     }
 
@@ -99,11 +99,11 @@ 
      */
     private function parseTagForReturnType(array $tokens, int $returnPosition)
     {
-        $content = $tokens[$returnPosition + 2]['content'];
+        $content = $tokens[ $returnPosition + 2 ][ 'content' ];
         // Support both a return type and a description.
         preg_match('`^((?:\|?(?:array\([^\)]*\)|[\\\\a-z0-9\[\]]+))*)( .*)?`i', $content, $returnParts);
 
-        return $returnParts[1] ?? false;
+        return $returnParts[ 1 ] ?? false;
     }
 
     /**
@@ -116,10 +116,10 @@ 
      */
     private function findCommentEnd(PHP_CodeSniffer_File $phpcsFile, $stackPtr, array $tokens)
     {
-        $find = PHP_CodeSniffer_Tokens::$methodPrefixes + [T_WHITESPACE];
+        $find = PHP_CodeSniffer_Tokens::$methodPrefixes + [ T_WHITESPACE ];
 
         $commentEnd = $phpcsFile->findPrevious($find, $stackPtr - 1, null, true);
-        if ($tokens[$commentEnd]['code'] !== T_COMMENT) {
+        if ($tokens[ $commentEnd ][ 'code' ] !== T_COMMENT) {
             return $commentEnd;
         }
 
@@ -128,7 +128,7 @@ 
         // using the wrong comment type. If there is other code on the line,
         // assume they relate to that code.
         $prev = $phpcsFile->findPrevious($find, $commentEnd - 1, null, true);
-        if ($prev !== false && $tokens[$prev]['line'] === $tokens[$commentEnd]['line']) {
+        if ($prev !== false && $tokens[ $prev ][ 'line' ] === $tokens[ $commentEnd ][ 'line' ]) {
             $commentEnd = $prev;
         }
 

src/Codor/Sniffs/Classes/ExtendsSniff.php

Spacing +3 added lines, -3 removed lines

@@ -19,7 +19,7 @@ 
      */
     public function register(): array
     {
-        return [T_CLASS];
+        return [ T_CLASS ];
     }
 
     /**
@@ -46,10 +46,10 @@ 
      */
     protected function handleToken($token)
     {
-        if ($token['type'] !== 'T_EXTENDS') {
+        if ($token[ 'type' ] !== 'T_EXTENDS') {
             return;
         }
         $warning = "Class extends another class - consider composition over inheritance.";
-        $this->phpcsFile->addWarning($warning, $token['line'], __CLASS__);
+        $this->phpcsFile->addWarning($warning, $token[ 'line' ], __CLASS__);
     }
 }

src/Codor/Sniffs/Classes/FinalPrivateSniff.php

Spacing +14 added lines, -14 removed lines

@@ -16,7 +16,7 @@ 
      */
     public function register(): array
     {
-        return [T_CLASS];
+        return [ T_CLASS ];
     }
 
     /**
@@ -29,13 +29,13 @@ 
      * List of protected methods found.
      * @var array
      */
-    protected $protectedMethodTokens = [];
+    protected $protectedMethodTokens = [ ];
 
     /**
      * List of protected variables found.
      * @var array
      */
-    protected $protectedVariableTokens = [];
+    protected $protectedVariableTokens = [ ];
 
     /**
      * Processes the tokens that this sniff is interested in.
@@ -49,8 +49,8 @@ 
     public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
     {
         $this->classIsMarkedFinal = false;
-        $this->protectedMethodTokens = [];
-        $this->protectedVariableTokens = [];
+        $this->protectedMethodTokens = [ ];
+        $this->protectedVariableTokens = [ ];
 
         $tokens = $phpcsFile->getTokens();
 
@@ -69,14 +69,14 @@ 
      */
     protected function handleToken($tokens, $index)
     {
-        $tokenType = $tokens[$index]['type'];
+        $tokenType = $tokens[ $index ][ 'type' ];
 
         if ($tokenType === 'T_FINAL') {
             $this->classIsMarkedFinal = true;
             return;
         }
 
-        if (! $this->classIsMarkedFinal) {
+        if (!$this->classIsMarkedFinal) {
             return;
         }
 
@@ -96,14 +96,14 @@ 
      */
     protected function handleFoundProtectedElement($tokens, $index)
     {
-        $type = $tokens[$index+2]['type'];
+        $type = $tokens[ $index + 2 ][ 'type' ];
 
         if ($type === 'T_VARIABLE') {
-            $this->protectedVariableTokens[] = $tokens[$index+2];
+            $this->protectedVariableTokens[ ] = $tokens[ $index + 2 ];
             return;
         }
 
-        $this->protectedMethodTokens[] = $tokens[$index+4];
+        $this->protectedMethodTokens[ ] = $tokens[ $index + 4 ];
     }
 
     /**
@@ -131,8 +131,8 @@ 
      */
     protected function handleProtectedMethodToken($token, $phpcsFile)
     {
-        $methodName = $token['content'];
-        $line = $token['line'];
+        $methodName = $token[ 'content' ];
+        $line = $token[ 'line' ];
         $phpcsFile->addError("Final Class contains a protected method {$methodName} - should be private.", $line, __CLASS__);
     }
 
@@ -144,8 +144,8 @@ 
      */
     protected function handleProtectedVariableToken($token, $phpcsFile)
     {
-        $variableName = $token['content'];
-        $line = $token['line'];
+        $variableName = $token[ 'content' ];
+        $line = $token[ 'line' ];
         $phpcsFile->addError("Final Class contains a protected variable {$variableName} - should be private.", $line, __CLASS__);
     }
 }

src/Codor/Sniffs/Classes/ConstructorLoopSniff.php

Spacing +8 added lines, -8 removed lines

@@ -12,7 +12,7 @@ 
      * The loop tokens we're lookin for.
      * @var array
      */
-    protected $loops = ['T_FOR', 'T_FOREACH', 'T_WHILE'];
+    protected $loops = [ 'T_FOR', 'T_FOREACH', 'T_WHILE' ];
 
     /**
      * Returns the token types that this sniff is interested in.
@@ -20,7 +20,7 @@ 
      */
     public function register(): array
     {
-        return [T_FUNCTION];
+        return [ T_FUNCTION ];
     }
 
     /**
@@ -34,20 +34,20 @@ 
     public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
     {
         $tokens            = $phpcsFile->getTokens();
-        $token             = $tokens[$stackPtr];
-        $functionNameToken = $tokens[$stackPtr + 2];
-        $functionName      = $functionNameToken['content'];
+        $token             = $tokens[ $stackPtr ];
+        $functionNameToken = $tokens[ $stackPtr + 2 ];
+        $functionName      = $functionNameToken[ 'content' ];
 
         if ($functionName !== '__construct') {
             return;
         }
         // If this is an interface we don't check it.
-        if (! isset($token['scope_opener'])) {
+        if (!isset($token[ 'scope_opener' ])) {
             return;
         }
 
-        for ($index=$token['scope_opener']; $index <= $token['scope_closer']; $index++) {
-            if (in_array($tokens[$index]['type'], $this->loops)) {
+        for ($index = $token[ 'scope_opener' ]; $index <= $token[ 'scope_closer' ]; $index++) {
+            if (in_array($tokens[ $index ][ 'type' ], $this->loops)) {
                 $phpcsFile->addError("Class constructor cannot contain a loop.", $stackPtr, __CLASS__);
                 continue;
             }