Issues in TaskController.php (master) - Issues in master - Yoshi2889/tasks - Measure and Improve Code Quality continuously with Scrutinizer

Issues (17)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/TaskController.php (9 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * Copyright 2017 NanoSector
 *
 * You should have received a copy of the MIT license with the project.
 * See the LICENSE file for more information.
 */

namespace Yoshi2889\Tasks;

use React\EventLoop\LoopInterface;

class TaskController
{
	/**
	 * @var int
	 */
	protected $loopInterval = 1;


	/**
	 * @var TaskInterface[]
	 */
	protected $tasks = [];


	/**
	 * TaskController constructor.
	 *
	 * @param LoopInterface $loop
	 */
	public function __construct(LoopInterface $loop)
	{
		$loop->addPeriodicTimer($this->loopInterval, [$this, 'runTasks']);
	}

	/**
	 * @param TaskInterface $task
	 *
	 * @return bool
	 */
	public function add(TaskInterface $task): bool

	{
		if ($this->exists($task))
// Without braces (not recommended)
if (true)
    doSomething();

// Recommended
if (true) {
    doSomething();
}
			return false;

		$this->tasks[] = $task;

		return true;
	}

	/**
	 * @param TaskInterface $task
	 *
	 * @return bool
	 */
	public function remove(TaskInterface $task): bool

	{
		if (!$this->exists($task))
// Without braces (not recommended)
if (true)
    doSomething();

// Recommended
if (true) {
    doSomething();
}
			return false;

		unset($this->tasks[array_search($task, $this->tasks)]);

		return true;
	}

    public function removeAll()
    {
        foreach ($this->tasks as $task)
        {
            $task->cancel();
            $this->remove($task);
        }
	}

	/**
	 * @param TaskInterface $task
	 *
	 * @return bool
	 */
	public function exists(TaskInterface $task): bool

	{
		return in_array($task, $this->tasks);
	}

	public function runTasks()
	{
		foreach ($this->tasks as $task)
		{
			if (time() < $task->getExpiryTime())
// Without braces (not recommended)
if (true)
    doSomething();

// Recommended
if (true) {
    doSomething();
}
				continue;

			$result = $task->run();

			// It is removed first.
			$this->remove($task);

			if ($result instanceof TaskInterface)
// Without braces (not recommended)
if (true)
    doSomething();

// Recommended
if (true) {
    doSomething();
}
				$this->add($result);
		}
	}
}

1		<?php
2
3		/**
4		* Copyright 2017 NanoSector
5		*
6		* You should have received a copy of the MIT license with the project.
7		* See the LICENSE file for more information.
8		*/
9
10		namespace Yoshi2889\Tasks;
11
12		use React\EventLoop\LoopInterface;
13
14		class TaskController
15		{
16		/**
17		* @var int
18		*/
19		protected $loopInterval = 1;
		0 ignored issues – show Coding Style introduced 2019-05-26 13:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this Protected member variable "loopInterval" must contain a leading underscore Loading history...
20
21		/**
22		* @var TaskInterface[]
23		*/
24		protected $tasks = [];
		0 ignored issues – show Coding Style introduced 2019-05-26 13:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this Protected member variable "tasks" must contain a leading underscore Loading history...
25
26		/**
27		* TaskController constructor.
28		*
29		* @param LoopInterface $loop
30		*/
31	9	public function __construct(LoopInterface $loop)
32		{
33	9	$loop->addPeriodicTimer($this->loopInterval, [$this, 'runTasks']);
34	9	}
35
36		/**
37		* @param TaskInterface $task
38		*
39		* @return bool
40		*/
41	9	public function add(TaskInterface $task): bool
		0 ignored issues – show Coding Style introduced 2019-05-26 13:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this `function add()` does not seem to conform to the naming convention (`^(?:is\|has\|should\|may\|supports)`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
42		{
43	9	if ($this->exists($task))
		0 ignored issues – show Coding Style Best Practice introduced 2019-05-26 13:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally a best practice to always use braces with control structures. Adding braces to control structures avoids accidental mistakes as your code changes: // Without braces (not recommended) if (true) doSomething(); // Recommended if (true) { doSomething(); } Loading history...
44	1	return false;
45
46	9	$this->tasks[] = $task;
47
48	9	return true;
49		}
50
51		/**
52		* @param TaskInterface $task
53		*
54		* @return bool
55		*/
56	8	public function remove(TaskInterface $task): bool
		0 ignored issues – show Coding Style introduced 2019-05-26 13:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this `function remove()` does not seem to conform to the naming convention (`^(?:is\|has\|should\|may\|supports)`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
57		{
58	8	if (!$this->exists($task))
		0 ignored issues – show Coding Style Best Practice introduced 2019-05-26 13:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally a best practice to always use braces with control structures. Adding braces to control structures avoids accidental mistakes as your code changes: // Without braces (not recommended) if (true) doSomething(); // Recommended if (true) { doSomething(); } Loading history...
59	1	return false;
60
61	8	unset($this->tasks[array_search($task, $this->tasks)]);
62
63	8	return true;
64		}
65
66	1	public function removeAll()
67		{
68	1	foreach ($this->tasks as $task)
69		{
70	1	$task->cancel();
71	1	$this->remove($task);
72		}
73	1	}
74
75		/**
76		* @param TaskInterface $task
77		*
78		* @return bool
79		*/
80	9	public function exists(TaskInterface $task): bool
		0 ignored issues – show Coding Style introduced 2019-05-26 13:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this `function exists()` does not seem to conform to the naming convention (`^(?:is\|has\|should\|may\|supports)`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
81		{
82	9	return in_array($task, $this->tasks);
83		}
84
85	6	public function runTasks()
86		{
87	6	foreach ($this->tasks as $task)
88		{
89	6	if (time() < $task->getExpiryTime())
		0 ignored issues – show Coding Style Best Practice introduced 2019-05-26 13:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally a best practice to always use braces with control structures. Adding braces to control structures avoids accidental mistakes as your code changes: // Without braces (not recommended) if (true) doSomething(); // Recommended if (true) { doSomething(); } Loading history...
90	1	continue;
91
92	6	$result = $task->run();
93
94		// It is removed first.
95	6	$this->remove($task);
96
97	6	if ($result instanceof TaskInterface)
		0 ignored issues – show Coding Style Best Practice introduced 2019-05-26 13:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally a best practice to always use braces with control structures. Adding braces to control structures avoids accidental mistakes as your code changes: // Without braces (not recommended) if (true) doSomething(); // Recommended if (true) { doSomething(); } Loading history...
98	2	$this->add($result);
99		}
100		}
101		}

Yoshi2889 / tasks

Issues (17)

Security Analysis no request data

src/TaskController.php (9 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like