Yoshi2889\Tasks\TaskController

Complexity

Total Complexity

12

Size/Duplication

Total Lines	88
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	add()	0	9	2
A	remove()	0	9	2
A	removeAll()	0	8	2
A	exists()	0	4	1
A	runTasks()	0	16	4

<?php

/**
 * Copyright 2017 NanoSector
 *
 * You should have received a copy of the MIT license with the project.
 * See the LICENSE file for more information.
 */

namespace Yoshi2889\Tasks;

use React\EventLoop\LoopInterface;

class TaskController
{
	/**
	 * @var int
	 */
	protected $loopInterval = 1;

Protected member variable "loopInterval" must contain a leading underscore

	/**
	 * @var TaskInterface[]
	 */
	protected $tasks = [];

Protected member variable "tasks" must contain a leading underscore

	/**
	 * TaskController constructor.
	 *
	 * @param LoopInterface $loop
	 */
	public function __construct(LoopInterface $loop)
	{
		$loop->addPeriodicTimer($this->loopInterval, [$this, 'runTasks']);
	}

	/**
	 * @param TaskInterface $task
	 *
	 * @return bool
	 */
	public function add(TaskInterface $task): bool

function add() does not seem to conform to the naming convention (^(?:is|has|should|may|supports)).

	{
		if ($this->exists($task))

It is generally a best practice to always use braces with control structures.

			return false;

		$this->tasks[] = $task;

		return true;
	}

	/**
	 * @param TaskInterface $task
	 *
	 * @return bool
	 */
	public function remove(TaskInterface $task): bool

function remove() does not seem to conform to the naming convention (^(?:is|has|should|may|supports)).

	{
		if (!$this->exists($task))

It is generally a best practice to always use braces with control structures.

			return false;

		unset($this->tasks[array_search($task, $this->tasks)]);

		return true;
	}

    public function removeAll()
    {
        foreach ($this->tasks as $task)
        {
            $task->cancel();
            $this->remove($task);
        }
	}

	/**
	 * @param TaskInterface $task
	 *
	 * @return bool
	 */
	public function exists(TaskInterface $task): bool

function exists() does not seem to conform to the naming convention (^(?:is|has|should|may|supports)).

	{
		return in_array($task, $this->tasks);
	}

	public function runTasks()
	{
		foreach ($this->tasks as $task)
		{
			if (time() < $task->getExpiryTime())

It is generally a best practice to always use braces with control structures.

				continue;

			$result = $task->run();

			// It is removed first.
			$this->remove($task);

			if ($result instanceof TaskInterface)

It is generally a best practice to always use braces with control structures.

				$this->add($result);
		}
	}
}