TaskController::runTasks() - Code Metrics - Yoshi2889/tasks - Measure and Improve Code Quality continuously with Scrutinizer

TaskController::runTasks() A
last analyzed 2019-05-26 13:52 UTC

↳ Parent: TaskController

Complexity

Conditions	4
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	4

Importance

Changes

Metric	Value
cc	4
nc	4
nop	0
dl	0
loc	16
ccs	9
cts	9
cp	1
crap	4
rs	9.7333
c	0
b	0
f	0

<?php

/**
 * Copyright 2017 NanoSector
 *
 * You should have received a copy of the MIT license with the project.
 * See the LICENSE file for more information.
 */

namespace Yoshi2889\Tasks;

use React\EventLoop\LoopInterface;

class TaskController
{
	/**
	 * @var int
	 */
	protected $loopInterval = 1;


	/**
	 * @var TaskInterface[]
	 */
	protected $tasks = [];


	/**
	 * TaskController constructor.
	 *
	 * @param LoopInterface $loop
	 */
	public function __construct(LoopInterface $loop)
	{
		$loop->addPeriodicTimer($this->loopInterval, [$this, 'runTasks']);
	}

	/**
	 * @param TaskInterface $task
	 *
	 * @return bool
	 */
	public function add(TaskInterface $task): bool

	{
		if ($this->exists($task))
// Without braces (not recommended)
if (true)
    doSomething();

// Recommended
if (true) {
    doSomething();
}
			return false;

		$this->tasks[] = $task;

		return true;
	}

	/**
	 * @param TaskInterface $task
	 *
	 * @return bool
	 */
	public function remove(TaskInterface $task): bool

	{
		if (!$this->exists($task))
// Without braces (not recommended)
if (true)
    doSomething();

// Recommended
if (true) {
    doSomething();
}
			return false;

		unset($this->tasks[array_search($task, $this->tasks)]);

		return true;
	}

    public function removeAll()
    {
        foreach ($this->tasks as $task)
        {
            $task->cancel();
            $this->remove($task);
        }
	}

	/**
	 * @param TaskInterface $task
	 *
	 * @return bool
	 */
	public function exists(TaskInterface $task): bool

	{
		return in_array($task, $this->tasks);
	}

	public function runTasks()
	{
		foreach ($this->tasks as $task)
		{
			if (time() < $task->getExpiryTime())
// Without braces (not recommended)
if (true)
    doSomething();

// Recommended
if (true) {
    doSomething();
}
				continue;

			$result = $task->run();

			// It is removed first.
			$this->remove($task);

			if ($result instanceof TaskInterface)
// Without braces (not recommended)
if (true)
    doSomething();

// Recommended
if (true) {
    doSomething();
}
				$this->add($result);
		}
	}
}

1		<?php
2
3		/**
4		* Copyright 2017 NanoSector
5		*
6		* You should have received a copy of the MIT license with the project.
7		* See the LICENSE file for more information.
8		*/
9
10		namespace Yoshi2889\Tasks;
11
12		use React\EventLoop\LoopInterface;
13
14		class TaskController
15		{
16		/**
17		* @var int
18		*/
19		protected $loopInterval = 1;
		0 ignored issues – show Coding Style introduced 2019-05-26 13:52 UTC by Report Bug Copy Issue Report Protected member variable "loopInterval" must contain a leading underscore Loading history...
20
21		/**
22		* @var TaskInterface[]
23		*/
24		protected $tasks = [];
		0 ignored issues – show Coding Style introduced 2019-05-26 13:52 UTC by Report Bug Copy Issue Report Protected member variable "tasks" must contain a leading underscore Loading history...
25
26		/**
27		* TaskController constructor.
28		*
29		* @param LoopInterface $loop
30		*/
31	9	public function __construct(LoopInterface $loop)
32		{
33	9	$loop->addPeriodicTimer($this->loopInterval, [$this, 'runTasks']);
34	9	}
35
36		/**
37		* @param TaskInterface $task
38		*
39		* @return bool
40		*/
41	9	public function add(TaskInterface $task): bool
		0 ignored issues – show Coding Style introduced 2019-05-26 13:52 UTC by Report Bug Copy Issue Report `function add()` does not seem to conform to the naming convention (`^(?:is\|has\|should\|may\|supports)`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
42		{
43	9	if ($this->exists($task))
		0 ignored issues – show Coding Style Best Practice introduced 2019-05-26 13:52 UTC by Report Bug Copy Issue Report It is generally a best practice to always use braces with control structures. Adding braces to control structures avoids accidental mistakes as your code changes: // Without braces (not recommended) if (true) doSomething(); // Recommended if (true) { doSomething(); } Loading history...
44	1	return false;
45
46	9	$this->tasks[] = $task;
47
48	9	return true;
49		}
50
51		/**
52		* @param TaskInterface $task
53		*
54		* @return bool
55		*/
56	8	public function remove(TaskInterface $task): bool
		0 ignored issues – show Coding Style introduced 2019-05-26 13:52 UTC by Report Bug Copy Issue Report `function remove()` does not seem to conform to the naming convention (`^(?:is\|has\|should\|may\|supports)`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
57		{
58	8	if (!$this->exists($task))
		0 ignored issues – show Coding Style Best Practice introduced 2019-05-26 13:52 UTC by Report Bug Copy Issue Report It is generally a best practice to always use braces with control structures. Adding braces to control structures avoids accidental mistakes as your code changes: // Without braces (not recommended) if (true) doSomething(); // Recommended if (true) { doSomething(); } Loading history...
59	1	return false;
60
61	8	unset($this->tasks[array_search($task, $this->tasks)]);
62
63	8	return true;
64		}
65
66	1	public function removeAll()
67		{
68	1	foreach ($this->tasks as $task)
69		{
70	1	$task->cancel();
71	1	$this->remove($task);
72		}
73	1	}
74
75		/**
76		* @param TaskInterface $task
77		*
78		* @return bool
79		*/
80	9	public function exists(TaskInterface $task): bool
		0 ignored issues – show Coding Style introduced 2019-05-26 13:52 UTC by Report Bug Copy Issue Report `function exists()` does not seem to conform to the naming convention (`^(?:is\|has\|should\|may\|supports)`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
81		{
82	9	return in_array($task, $this->tasks);
83		}
84
85	6	public function runTasks()
86		{
87	6	foreach ($this->tasks as $task)
88		{
89	6	if (time() < $task->getExpiryTime())
		0 ignored issues – show Coding Style Best Practice introduced 2019-05-26 13:52 UTC by Report Bug Copy Issue Report It is generally a best practice to always use braces with control structures. Adding braces to control structures avoids accidental mistakes as your code changes: // Without braces (not recommended) if (true) doSomething(); // Recommended if (true) { doSomething(); } Loading history...
90	1	continue;
91
92	6	$result = $task->run();
93
94		// It is removed first.
95	6	$this->remove($task);
96
97	6	if ($result instanceof TaskInterface)
		0 ignored issues – show Coding Style Best Practice introduced 2019-05-26 13:52 UTC by Report Bug Copy Issue Report It is generally a best practice to always use braces with control structures. Adding braces to control structures avoids accidental mistakes as your code changes: // Without braces (not recommended) if (true) doSomething(); // Recommended if (true) { doSomething(); } Loading history...
98	2	$this->add($result);
99		}
100		}
101		}

Yoshi2889 / tasks

TaskController::runTasks() A last analyzed 2019-05-26 13:52 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

TaskController::runTasks() A
last analyzed 2019-05-26 13:52 UTC