View GitHub Repository tiqr-server-libphp

Schedule Inspection
Subscribe
Passed
Pull Request — develop (#27)
by Michiel
06:20
created

901 +77 Covered Lines

1,750 -160 Total Lines

51.5 % +8.3% Code Coverage

PHP Classes Changes

 
 ⇢
0%
Tiqr_UserSecretStorage_Encryption_Mcrypt added
 
 ⇢
78.95%
FileTrait added
 
 ⇢
100%
UserSecretStorageTrait added
 
 ⇢
100%
Tiqr_UserSecretStorage_Encryption_Dummy added
0%
 ↗
100%
 Tiqr_UserSecretStorage_OathServiceClient improved
43.75%
 ↗
100%
 Tiqr_OcraService improved
50%
 ↗
100%
 Tiqr_UserSecretStorage improved
60%
 ↗
100%
 Tiqr_DeviceStorage improved
60%
 ↗
100%
 Tiqr_UserStorage improved
72%
 ↘
44.44%
 Tiqr_UserStorage_File got worse
87.5%
 ↘
60%
 Tiqr_UserStorage_Abstract got worse
0%
 ↗
18.18%
 Tiqr_OcraService_OathServiceClient improved
89.16%
 ↘
71.84%
 Tiqr_UserStorage_Pdo got worse
100%
 ↘
86.67%
 Tiqr_UserSecretStorage_File got worse
⋮ view more  
0%
 ↛
 
 Tiqr_UserSecretStorage_Ldap removed
0%
 ↛
 
 Tiqr_UserStorage_Encryption_Mcrypt removed
0%
 ↛
 
 Tiqr_UserStorage_Ldap removed
100%
 ↛
 
 Tiqr_UserStorage_Encryption_Dummy removed

CRAP Changes

 
 ⇢
4.0119
FileTrait::_loadUser() added
 
 ⇢
2.2559
FileTrait::_saveUser() added
 
 ⇢
2.1481
FileTrait::getPath() added
 
 ⇢
2.0078
Tiqr_UserSecretStorage_Pdo::userExists() added
 
 ⇢
2
Tiqr_UserSecretStorage_Encryption_Mcrypt::__constr... added
 
 ⇢
2
Tiqr_UserSecretStorage_Encryption_Mcrypt::decrypt(... added
 
 ⇢
2
Tiqr_UserSecretStorage_Encryption_Mcrypt::encrypt(... added
 
 ⇢
1
Tiqr_UserSecretStorage_OathServiceClient::setSecre... added
 
 ⇢
1
Tiqr_UserSecretStorage_OathServiceClient::getSecre... added
 
 ⇢
1
UserSecretStorageTrait::getSecret() added
⋮ view more  
2.0009
 ↗
2.0065
 Tiqr_Service::getEnrollmentMetadata() got worse
3.072
 ↘
3.0416
 Tiqr_UserStorage_GenericStore::getNotificationAddr... improved
7.049
 ↗
7.0846
 Tiqr_Service::authenticate() got worse
14.129
 ↘
14.0891
 Tiqr_Service::__construct() improved
2
 ↗
2.0625
 Tiqr_Service::finalizeEnrollment() got worse
2.0185
 ↗
2.0932
 Tiqr_Service::validateEnrollmentSecret() got worse
2.0625
 ↗
2.1481
 Tiqr_OcraService_Tiqr::_getProtocolSpecificOCRAWra... got worse
13.125
 ↘
13
 Tiqr_UserSecretStorage::getSecretStorage() improved
3.6511
 ↘
3.512
 Tiqr_UserStorage_Encryption::getEncryption() improved
2.0625
 ↗
2.2559
 Tiqr_Service::getAuthenticatedUser() got worse
⋮ view more  
182
 ↛
 
 Tiqr_UserStorage_Ldap::__construct() removed
42
 ↛
 
 Tiqr_UserStorage_Ldap::isBlocked() removed
30
 ↛
 
 Tiqr_UserSecretStorage_Ldap::__construct() removed
30
 ↛
 
 Tiqr_UserStorage_Ldap::getAdditionalAttributes() removed
12
 ↛
 
 Tiqr_UserStorage_Ldap::_getLDAPAttribute() removed
12
 ↛
 
 Tiqr_UserStorage_Ldap::getTemporaryBlockTimestamp(... removed
6
 ↛
 
 Tiqr_UserStorage_Ldap::getNotificationAddress() removed
6
 ↛
 
 Tiqr_UserStorage_Ldap::_saveUser() removed
6
 ↛
 
 Tiqr_UserStorage_Ldap::getDisplayName() removed
6
 ↛
 
 Tiqr_UserStorage_Ldap::getNotificationType() removed
⋮ view more