Tiqr_UserSecretStorage_File

Complexity

Total Complexity

5

Size/Duplication

Total Lines	51
Duplicated Lines	0 %

Test Coverage

Coverage

86.67%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	9	1
A	setUserSecret()	0	5	1
A	getUserSecret()	0	9	3

<?php
/**
 * This file is part of the tiqr project.
 * 
 * The tiqr project aims to provide an open implementation for 
 * authentication using mobile devices. It was initiated by 
 * SURFnet and developed by Egeniq.
 *
 * More information: http://www.tiqr.org
 *
 * @author Ivo Jansch <ivo@egeniq.com>
 * 
 * @package tiqr
 *
 * @license New BSD License - See LICENSE file for details.
 *
 * @copyright (C) 2010-2012 SURFnet BV
 */

use Psr\Log\LoggerInterface;

require_once 'Tiqr/UserStorage/FileTrait.php';
require_once 'Tiqr/UserSecretStorage/UserSecretStorageTrait.php';

/**
 * This user storage implementation implements a simple user's secret storage using json files.
 * This is mostly for demonstration and development purposes. In a production environment
 * please supply your own implementation that hosts the data in your user database OR
 * in a secure (e.g. hardware encrypted) storage.
 * @author ivo
 */
class Tiqr_UserSecretStorage_File implements Tiqr_UserSecretStorage_Interface
{
    use UserSecretStorageTrait;
    use FileTrait;

    private $userSecretStorage;

The private property $userSecretStorage is not used, and could be removed.

    private $logger;

    private $path;

    public function __construct(
        Tiqr_UserSecretStorage_Encryption_Interface $encryption,
        string $path,
        LoggerInterface $logger
    ) {
        // See UserSecretStorageTrait
        $this->encryption = $encryption;
        $this->logger = $logger;
        $this->path = $path;
    }

    /**
     * Get the user's secret
     *
     * @param String $userId
     *
     * @return String The user's secret
     */
    private function getUserSecret($userId)

The method getUserSecret() is not used, and could be removed.

    {
        if ($data = $this->_loadUser($userId)) {
            if (isset($data["secret"])) {
                return $data["secret"];
            }
        }
        $this->logger->error('Unable to retrieve the secret (user not found). In user secret storage (file)');
        return NULL;
    }

    /**
     * Store a secret for a user
     *
     * @param String $userId
     * @param String $secret
     */
    private function setUserSecret($userId, $secret)

The method setUserSecret() is not used, and could be removed.

    {
        $data = $this->_loadUser($userId, false);
        $data["secret"] = $secret;
        $this->_saveUser($userId, $data);

$data of type false is incompatible with the type array expected by parameter $data of Tiqr_UserSecretStorage_File::_saveUser().

    }
}