Failed Conditions
Pull Request — master (#1307)
by Timo
21:30
created
Classes/Domain/Search/ResultSet/SearchResultSetService.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -296,7 +296,7 @@  discard block
 block discarded – undo
296 296
      * @param Query $query The query that has been searched for.
297 297
      * @param \Apache_Solr_Response $response The search's response.
298 298
      */
299
-    protected function processResponse($rawQuery, Query $query, \Apache_Solr_Response &$response)
299
+    protected function processResponse($rawQuery, Query $query, \Apache_Solr_Response & $response)
300 300
     {
301 301
         if ($this->shouldHideResultsFromInitialSearch($rawQuery)) {
302 302
             // explicitly set number of results to 0 as we just wanted
@@ -324,7 +324,7 @@  discard block
 block discarded – undo
324 324
      *
325 325
      * @param \Apache_Solr_Response $response
326 326
      */
327
-    protected function addExpandedDocumentsFromVariants(\Apache_Solr_Response &$response)
327
+    protected function addExpandedDocumentsFromVariants(\Apache_Solr_Response & $response)
328 328
     {
329 329
         if (!is_array($response->response->docs)) {
330 330
             return;
@@ -376,7 +376,7 @@  discard block
 block discarded – undo
376 376
      * @param \Apache_Solr_Response $response
377 377
      * @throws \Apache_Solr_ParserException
378 378
      */
379
-    protected function wrapResultDocumentInResultObject(\Apache_Solr_Response &$response)
379
+    protected function wrapResultDocumentInResultObject(\Apache_Solr_Response & $response)
380 380
     {
381 381
         $documents = $response->response->docs;
382 382
 
Please login to merge, or discard this patch.
Search/ResultSet/Facets/OptionBased/Hierarchy/HierarchyFacetParser.php 2 patches
Unused Use Statements   -4 removed lines patch added patch discarded remove patch
@@ -14,12 +14,8 @@
 block discarded – undo
14 14
  * The TYPO3 project - inspiring people to share!
15 15
  */
16 16
 
17
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\AbstractFacet;
18 17
 use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\AbstractFacetParser;
19
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\FacetParserInterface;
20 18
 use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\SearchResultSet;
21
-use TYPO3\CMS\Core\Utility\GeneralUtility;
22
-use TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer;
23 19
 
24 20
 /**
25 21
  * Class OptionsFacetParser
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -86,7 +86,7 @@
 block discarded – undo
86 86
         $path = str_replace('\/', '@@@', $path);
87 87
         $path = rtrim($path, "/");
88 88
         $segments = explode('/', $path);
89
-        return array_map(function ($item) {
89
+        return array_map(function($item) {
90 90
             return str_replace('@@@', '/', $item);
91 91
         }, $segments);
92 92
     }
Please login to merge, or discard this patch.
Domain/Search/ResultSet/Facets/OptionBased/Options/OptionsFacetParser.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
      * @param SearchResultSet $resultSet
31 31
      * @param string $facetName
32 32
      * @param array $facetConfiguration
33
-     * @return OptionsFacet|null
33
+     * @return null|\ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\OptionBased\AbstractOptionsFacet
34 34
      */
35 35
     public function parse(SearchResultSet $resultSet, $facetName, array $facetConfiguration)
36 36
     {
Please login to merge, or discard this patch.
Unused Use Statements   -4 removed lines patch added patch discarded remove patch
@@ -14,12 +14,8 @@
 block discarded – undo
14 14
  * The TYPO3 project - inspiring people to share!
15 15
  */
16 16
 
17
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\AbstractFacet;
18 17
 use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\AbstractFacetParser;
19
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\FacetParserInterface;
20 18
 use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\SearchResultSet;
21
-use TYPO3\CMS\Core\Utility\GeneralUtility;
22
-use TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer;
23 19
 
24 20
 /**
25 21
  * Class OptionsFacetParser
Please login to merge, or discard this patch.
Search/ResultSet/Facets/OptionBased/QueryGroup/QueryGroupFacetParser.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@
 block discarded – undo
32 32
      * @param SearchResultSet $resultSet
33 33
      * @param string $facetName
34 34
      * @param array $facetConfiguration
35
-     * @return QueryGroupFacet|null
35
+     * @return null|\ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\OptionBased\AbstractOptionsFacet
36 36
      */
37 37
     public function parse(SearchResultSet $resultSet, $facetName, array $facetConfiguration)
38 38
     {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -13,10 +13,8 @@
 block discarded – undo
13 13
  *
14 14
  * The TYPO3 project - inspiring people to share!
15 15
  */
16
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\AbstractFacet;
17 16
 use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\AbstractFacetParser;
18 17
 use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\SearchResultSet;
19
-use TYPO3\CMS\Core\Utility\GeneralUtility;
20 18
 
21 19
 /**
22 20
  * Class QueryGroupFacetParser
Please login to merge, or discard this patch.
Domain/Search/ResultSet/Facets/RangeBased/AbstractRangeFacetParser.php 2 patches
Doc Comments   +2 added lines patch added patch discarded remove patch
@@ -30,6 +30,8 @@
 block discarded – undo
30 30
      * @param SearchResultSet $resultSet
31 31
      * @param string $facetName
32 32
      * @param array $facetConfiguration
33
+     * @param string $facetClass
34
+     * @param string $facetRangeCountClass
33 35
      * @return AbstractRangeFacet|null
34 36
      */
35 37
     protected function getParsedFacet(SearchResultSet $resultSet, $facetName, array $facetConfiguration, $facetClass, $facetItemClass, $facetRangeCountClass)
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@
 block discarded – undo
79 79
             $to = $this->parseRequestValue($rawTo);
80 80
 
81 81
             $type = isset($facetConfiguration['type']) ? $facetConfiguration['type'] : 'numericRange';
82
-            $gap = isset($facetConfiguration[$type.'.']['gap']) ? $facetConfiguration[$type.'.']['gap'] : 1;
82
+            $gap = isset($facetConfiguration[$type . '.']['gap']) ? $facetConfiguration[$type . '.']['gap'] : 1;
83 83
 
84 84
             $range = new $facetItemClass($facet, $from, $to, $fromInResponse, $toInResponse, $gap, $allCount, $rangeCounts, true);
85 85
             $facet->setRange($range);
Please login to merge, or discard this patch.
Search/ResultSet/Facets/RangeBased/NumericRange/NumericRangeFacetParser.php 1 patch
Unused Use Statements   -4 removed lines patch added patch discarded remove patch
@@ -14,12 +14,8 @@
 block discarded – undo
14 14
  * The TYPO3 project - inspiring people to share!
15 15
  */
16 16
 
17
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\AbstractFacet;
18
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\AbstractFacetParser;
19
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\FacetParserInterface;
20 17
 use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\RangeBased\AbstractRangeFacetParser;
21 18
 use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\SearchResultSet;
22
-use TYPO3\CMS\Core\Utility\GeneralUtility;
23 19
 
24 20
 /**
25 21
  * Class NumericRangeFacetParser
Please login to merge, or discard this patch.
Classes/Domain/Search/ResultSet/Sorting/Sorting.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -147,7 +147,7 @@
 block discarded – undo
147 147
     }
148 148
 
149 149
     /**
150
-     * @param $direction
150
+     * @param string $direction
151 151
      * @return string
152 152
      */
153 153
     public static function getOppositeDirectionFromDirection($direction)
Please login to merge, or discard this patch.
Classes/ViewHelpers/Debug/DocumentScoreAnalyzerViewHelper.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@
 block discarded – undo
59 59
 
60 60
     /**
61 61
      * @param array $arguments
62
-     * @param callable $renderChildrenClosure
62
+     * @param \Closure $renderChildrenClosure
63 63
      * @param RenderingContextInterface $renderingContext
64 64
      * @return string
65 65
      */
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -15,8 +15,6 @@
 block discarded – undo
15 15
  */
16 16
 
17 17
 use ApacheSolrForTypo3\Solr\Domain\Search\Score\ScoreCalculationService;
18
-use ApacheSolrForTypo3\Solr\Tests\Unit\Domain\Search\Score\ScoreCalculationServiceTest;
19
-use ApacheSolrForTypo3\Solr\Util;
20 18
 use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\SearchResultSet;
21 19
 use ApacheSolrForTypo3\Solr\ViewHelpers\AbstractViewHelper;
22 20
 use TYPO3\CMS\Core\Utility\GeneralUtility;
Please login to merge, or discard this patch.
Classes/ViewHelpers/Debug/QueryViewHelper.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@
 block discarded – undo
49 49
 
50 50
     /**
51 51
      * @param array $arguments
52
-     * @param callable $renderChildrenClosure
52
+     * @param \Closure $renderChildrenClosure
53 53
      * @param RenderingContextInterface $renderingContext
54 54
      * @return string
55 55
      */
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -15,7 +15,6 @@
 block discarded – undo
15 15
  */
16 16
 
17 17
 use ApacheSolrForTypo3\Solr\ViewHelpers\AbstractViewHelper;
18
-use TYPO3\CMS\Core\Utility\GeneralUtility;
19 18
 use TYPO3\CMS\Fluid\Core\Rendering\RenderingContextInterface;
20 19
 use TYPO3\CMS\Fluid\Core\ViewHelper\Facets\CompilableInterface;
21 20
 
Please login to merge, or discard this patch.