TYPO3-Solr / ext-solr

Classes/Domain/Search/ResultSet/SearchResultSetService.php

Spacing +3 added lines, -3 removed lines

@@ -296,7 +296,7 @@ 
      * @param Query $query The query that has been searched for.
      * @param \Apache_Solr_Response $response The search's response.
      */
-    protected function processResponse($rawQuery, Query $query, \Apache_Solr_Response &$response)
+    protected function processResponse($rawQuery, Query $query, \Apache_Solr_Response & $response)
     {
         if ($this->shouldHideResultsFromInitialSearch($rawQuery)) {
             // explicitly set number of results to 0 as we just wanted
@@ -324,7 +324,7 @@ 
      *
      * @param \Apache_Solr_Response $response
      */
-    protected function addExpandedDocumentsFromVariants(\Apache_Solr_Response &$response)
+    protected function addExpandedDocumentsFromVariants(\Apache_Solr_Response & $response)
     {
         if (!is_array($response->response->docs)) {
             return;
@@ -376,7 +376,7 @@ 
      * @param \Apache_Solr_Response $response
      * @throws \Apache_Solr_ParserException
      */
-    protected function wrapResultDocumentInResultObject(\Apache_Solr_Response &$response)
+    protected function wrapResultDocumentInResultObject(\Apache_Solr_Response & $response)
     {
         $documents = $response->response->docs;
 

Classes/Domain/Search/ResultSet/Facets/OptionBased/Hierarchy/HierarchyFacetParser.php

Unused Use Statements -4 removed lines

@@ -14,12 +14,8 @@
  * The TYPO3 project - inspiring people to share!
  */
 
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\AbstractFacet;
 use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\AbstractFacetParser;
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\FacetParserInterface;
 use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\SearchResultSet;
-use TYPO3\CMS\Core\Utility\GeneralUtility;
-use TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer;
 
 /**
  * Class OptionsFacetParser

Spacing +1 added lines, -1 removed lines

@@ -86,7 +86,7 @@
         $path = str_replace('\/', '@@@', $path);
         $path = rtrim($path, "/");
         $segments = explode('/', $path);
-        return array_map(function ($item) {
+        return array_map(function($item) {
             return str_replace('@@@', '/', $item);
         }, $segments);
     }

Classes/Domain/Search/ResultSet/Facets/OptionBased/Options/OptionsFacetParser.php

Doc Comments +1 added lines, -1 removed lines

@@ -30,7 +30,7 @@
      * @param SearchResultSet $resultSet
      * @param string $facetName
      * @param array $facetConfiguration
-     * @return OptionsFacet|null
+     * @return null|\ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\OptionBased\AbstractOptionsFacet
      */
     public function parse(SearchResultSet $resultSet, $facetName, array $facetConfiguration)
     {

Unused Use Statements -4 removed lines

@@ -14,12 +14,8 @@
  * The TYPO3 project - inspiring people to share!
  */
 
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\AbstractFacet;
 use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\AbstractFacetParser;
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\FacetParserInterface;
 use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\SearchResultSet;
-use TYPO3\CMS\Core\Utility\GeneralUtility;
-use TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer;
 
 /**
  * Class OptionsFacetParser

Classes/Domain/Search/ResultSet/Facets/OptionBased/QueryGroup/QueryGroupFacetParser.php

Doc Comments +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
      * @param SearchResultSet $resultSet
      * @param string $facetName
      * @param array $facetConfiguration
-     * @return QueryGroupFacet|null
+     * @return null|\ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\OptionBased\AbstractOptionsFacet
      */
     public function parse(SearchResultSet $resultSet, $facetName, array $facetConfiguration)
     {

Unused Use Statements -2 removed lines

@@ -13,10 +13,8 @@
  *
  * The TYPO3 project - inspiring people to share!
  */
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\AbstractFacet;
 use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\AbstractFacetParser;
 use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\SearchResultSet;
-use TYPO3\CMS\Core\Utility\GeneralUtility;
 
 /**
  * Class QueryGroupFacetParser

Classes/Domain/Search/ResultSet/Facets/RangeBased/AbstractRangeFacetParser.php

Doc Comments +2 added lines

@@ -30,6 +30,8 @@
      * @param SearchResultSet $resultSet
      * @param string $facetName
      * @param array $facetConfiguration
+     * @param string $facetClass
+     * @param string $facetRangeCountClass
      * @return AbstractRangeFacet|null
      */
     protected function getParsedFacet(SearchResultSet $resultSet, $facetName, array $facetConfiguration, $facetClass, $facetItemClass, $facetRangeCountClass)

Spacing +1 added lines, -1 removed lines

@@ -79,7 +79,7 @@
             $to = $this->parseRequestValue($rawTo);
 
             $type = isset($facetConfiguration['type']) ? $facetConfiguration['type'] : 'numericRange';
-            $gap = isset($facetConfiguration[$type.'.']['gap']) ? $facetConfiguration[$type.'.']['gap'] : 1;
+            $gap = isset($facetConfiguration[$type . '.']['gap']) ? $facetConfiguration[$type . '.']['gap'] : 1;
 
             $range = new $facetItemClass($facet, $from, $to, $fromInResponse, $toInResponse, $gap, $allCount, $rangeCounts, true);
             $facet->setRange($range);

Classes/Domain/Search/ResultSet/Facets/RangeBased/NumericRange/NumericRangeFacetParser.php

Unused Use Statements -4 removed lines

@@ -14,12 +14,8 @@
  * The TYPO3 project - inspiring people to share!
  */
 
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\AbstractFacet;
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\AbstractFacetParser;
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\FacetParserInterface;
 use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\RangeBased\AbstractRangeFacetParser;
 use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\SearchResultSet;
-use TYPO3\CMS\Core\Utility\GeneralUtility;
 
 /**
  * Class NumericRangeFacetParser

Classes/Domain/Search/ResultSet/Sorting/Sorting.php

Doc Comments +1 added lines, -1 removed lines

@@ -147,7 +147,7 @@
     }
 
     /**
-     * @param $direction
+     * @param string $direction
      * @return string
      */
     public static function getOppositeDirectionFromDirection($direction)

Classes/ViewHelpers/Debug/DocumentScoreAnalyzerViewHelper.php

Doc Comments +1 added lines, -1 removed lines

@@ -59,7 +59,7 @@
 
     /**
      * @param array $arguments
-     * @param callable $renderChildrenClosure
+     * @param \Closure $renderChildrenClosure
      * @param RenderingContextInterface $renderingContext
      * @return string
      */

Unused Use Statements -2 removed lines

@@ -15,8 +15,6 @@
  */
 
 use ApacheSolrForTypo3\Solr\Domain\Search\Score\ScoreCalculationService;
-use ApacheSolrForTypo3\Solr\Tests\Unit\Domain\Search\Score\ScoreCalculationServiceTest;
-use ApacheSolrForTypo3\Solr\Util;
 use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\SearchResultSet;
 use ApacheSolrForTypo3\Solr\ViewHelpers\AbstractViewHelper;
 use TYPO3\CMS\Core\Utility\GeneralUtility;

Classes/ViewHelpers/Debug/QueryViewHelper.php

Doc Comments +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
 
     /**
      * @param array $arguments
-     * @param callable $renderChildrenClosure
+     * @param \Closure $renderChildrenClosure
      * @param RenderingContextInterface $renderingContext
      * @return string
      */

Unused Use Statements -1 removed lines

@@ -15,7 +15,6 @@
  */
 
 use ApacheSolrForTypo3\Solr\ViewHelpers\AbstractViewHelper;
-use TYPO3\CMS\Core\Utility\GeneralUtility;
 use TYPO3\CMS\Fluid\Core\Rendering\RenderingContextInterface;
 use TYPO3\CMS\Fluid\Core\ViewHelper\Facets\CompilableInterface;