View GitHub Repository ext-solr

Schedule Inspection
Subscribe
Failed Conditions
Pull Request — master (#1307)
by Timo
21:30
created
Status
Category
Toggle Patches
Classes/ViewHelpers/Document/RelevanceViewHelper.php 3 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -55,7 +55,7 @@
 
 block discarded – undo
55 55
56 56 
     /**
57 57 
      * @param array $arguments
58 
-     * @param callable $renderChildrenClosure
58 
+     * @param \Closure $renderChildrenClosure
59 59 
      * @param RenderingContextInterface $renderingContext
60 60 
      * @return string
61 61 
      */
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch 
@@ -14,7 +14,6 @@
 
 block discarded – undo
14 14 
  * The TYPO3 project - inspiring people to share!
15 15 
  */
16 16
17 
-use ApacheSolrForTypo3\Solr\Search;
18 17 
 use ApacheSolrForTypo3\Solr\ViewHelpers\AbstractViewHelper;
19 18 
 use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\SearchResultSet;
20 19 
 use TYPO3\CMS\Fluid\Core\Rendering\RenderingContextInterface;
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -67,7 +67,7 @@
 
 block discarded – undo
67 67 
             /** @var $resultSet SearchResultSet */
68 68 
         $resultSet = $arguments['resultSet'];
69 69
70 
-        $maximumScore = $document->__solr_grouping_groupMaximumScore ? : $resultSet->getUsedSearch()->getMaximumResultScore();
70 
+        $maximumScore = $document->__solr_grouping_groupMaximumScore ?: $resultSet->getUsedSearch()->getMaximumResultScore();
71 71 
         $content = 0;
72 72
73 73 
         if ($maximumScore <= 0) {
Please login to merge, or discard this patch.
Classes/ViewHelpers/Facet/Area/GroupViewHelper.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -52,7 +52,7 @@
 
 block discarded – undo
52 52
53 53 
     /**
54 54 
      * @param array $arguments
55 
-     * @param callable $renderChildrenClosure
55 
+     * @param \Closure $renderChildrenClosure
56 56 
      * @param RenderingContextInterface $renderingContext
57 57 
      * @return string
58 58 
      */
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -60,7 +60,7 @@
 
 block discarded – undo
60 60 
     {
61 61 
         /** @var  $facets FacetCollection */
62 62 
         $facets = $arguments['facets'];
63 
-        $requiredGroup = isset($arguments['groupName']) ? $arguments['groupName'] :  'main';
63 
+        $requiredGroup = isset($arguments['groupName']) ? $arguments['groupName'] : 'main';
64 64 
         $filtered = $facets->getByGroupName($requiredGroup);
65 65
66 66 
         $templateVariableProvider = $renderingContext->getVariableProvider();
Please login to merge, or discard this patch.
Classes/ViewHelpers/PageBrowserRangeViewHelper.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -50,7 +50,7 @@
 
 block discarded – undo
50 50
51 51 
     /**
52 52 
      * @param array $arguments
53 
-     * @param callable $renderChildrenClosure
53 
+     * @param \Closure $renderChildrenClosure
54 54 
      * @param RenderingContextInterface $renderingContext
55 55 
      * @return string
56 56 
      */
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch 
@@ -14,7 +14,6 @@
 
 block discarded – undo
14 14 
  * The TYPO3 project - inspiring people to share!
15 15 
  */
16 16
17 
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\SearchResultSet;
18 17 
 use TYPO3\CMS\Fluid\Core\Rendering\RenderingContextInterface;
19 18 
 use TYPO3\CMS\Fluid\Core\ViewHelper\Facets\CompilableInterface;
20 19
Please login to merge, or discard this patch.
Classes/ViewHelpers/Uri/Facet/RemoveAllFacetsViewHelper.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -49,7 +49,7 @@
 
 block discarded – undo
49 49 
     }
50 50 
     /**
51 51 
      * @param array $arguments
52 
-     * @param callable $renderChildrenClosure
52 
+     * @param \Closure $renderChildrenClosure
53 53 
      * @param RenderingContextInterface $renderingContext
54 54 
      * @return string
55 55 
      * @throws \InvalidArgumentException
Please login to merge, or discard this patch.
Unused Use Statements   -9 removed lines patch added patch discarded remove patch 
@@ -14,16 +14,7 @@
 
 block discarded – undo
14 14 
  * The TYPO3 project - inspiring people to share!
15 15 
  */
16 16
17 
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\SearchResultSet;
18 
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\AbstractFacet;
19 
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\OptionsFacet\Option;
20 
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\OptionsFacet\OptionsFacet;
21 
-use ApacheSolrForTypo3\Solr\Domain\Search\Uri\SearchUriBuilder;
22 
-use ApacheSolrForTypo3\Solr\Mvc\Controller\SolrControllerContext;
23 
-use ApacheSolrForTypo3\Solr\ViewHelpers\AbstractTagBasedViewHelper;
24 17 
 use ApacheSolrForTypo3\Solr\ViewHelpers\Uri\AbstractUriViewHelper;
25 
-use TYPO3\CMS\Core\Utility\GeneralUtility;
26 
-use TYPO3\CMS\Extbase\Mvc\Web\Routing\UriBuilder;
27 18 
 use TYPO3\CMS\Fluid\Core\Rendering\RenderingContextInterface;
28 19 
 use TYPO3\CMS\Fluid\Core\ViewHelper\Facets\CompilableInterface;
29 20
Please login to merge, or discard this patch.
Classes/ViewHelpers/Uri/Facet/RemoveFacetViewHelper.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -44,7 +44,7 @@
 
 block discarded – undo
44 44
45 45 
     /**
46 46 
      * @param array $arguments
47 
-     * @param callable $renderChildrenClosure
47 
+     * @param \Closure $renderChildrenClosure
48 48 
      * @param RenderingContextInterface $renderingContext
49 49 
      * @return string
50 50 
      * @throws \InvalidArgumentException
Please login to merge, or discard this patch.
Classes/ViewHelpers/Uri/Paginate/ResultPageViewHelper.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -48,7 +48,7 @@
 
 block discarded – undo
48 48
49 49 
     /**
50 50 
      * @param array $arguments
51 
-     * @param callable $renderChildrenClosure
51 
+     * @param \Closure $renderChildrenClosure
52 52 
      * @param RenderingContextInterface $renderingContext
53 53 
      * @return string
54 54 
      */
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch 
@@ -14,10 +14,7 @@
 
 block discarded – undo
14 14 
  * The TYPO3 project - inspiring people to share!
15 15 
  */
16 16
17 
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\SearchResultSet;
18 17 
 use ApacheSolrForTypo3\Solr\ViewHelpers\Uri\AbstractUriViewHelper;
19 
-use TYPO3\CMS\Core\Utility\GeneralUtility;
20 
-use TYPO3\CMS\Extbase\Mvc\Web\Routing\UriBuilder;
21 18 
 use TYPO3\CMS\Fluid\Core\Rendering\RenderingContextInterface;
22 19 
 use TYPO3\CMS\Fluid\Core\ViewHelper\Facets\CompilableInterface;
23 20
Please login to merge, or discard this patch.
Classes/ViewHelpers/Uri/Search/CurrentSearchViewHelper.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -45,7 +45,7 @@
 
 block discarded – undo
45 45
46 46 
     /**
47 47 
      * @param array $arguments
48 
-     * @param callable $renderChildrenClosure
48 
+     * @param \Closure $renderChildrenClosure
49 49 
      * @param RenderingContextInterface $renderingContext
50 50 
      * @return string
51 51 
      */
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch 
@@ -14,10 +14,7 @@
 
 block discarded – undo
14 14 
  * The TYPO3 project - inspiring people to share!
15 15 
  */
16 16
17 
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\SearchResultSet;
18 17 
 use ApacheSolrForTypo3\Solr\ViewHelpers\Uri\AbstractUriViewHelper;
19 
-use TYPO3\CMS\Core\Utility\GeneralUtility;
20 
-use TYPO3\CMS\Extbase\Mvc\Web\Routing\UriBuilder;
21 18 
 use TYPO3\CMS\Fluid\Core\Rendering\RenderingContextInterface;
22 19 
 use TYPO3\CMS\Fluid\Core\ViewHelper\Facets\CompilableInterface;
23 20
Please login to merge, or discard this patch.
Classes/ViewHelpers/Uri/Search/StartNewSearchViewHelper.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -54,7 +54,7 @@
 
 block discarded – undo
54 54
55 55 
     /**
56 56 
      * @param array $arguments
57 
-     * @param callable|\Closure $renderChildrenClosure
57 
+     * @param \Closure $renderChildrenClosure
58 58 
      * @param RenderingContextInterface $renderingContext
59 59 
      * @return string
60 60 
      */
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch 
@@ -14,10 +14,7 @@
 
 block discarded – undo
14 14 
  * The TYPO3 project - inspiring people to share!
15 15 
  */
16 16
17 
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\SearchResultSet;
18 17 
 use ApacheSolrForTypo3\Solr\ViewHelpers\Uri\AbstractUriViewHelper;
19 
-use TYPO3\CMS\Core\Utility\GeneralUtility;
20 
-use TYPO3\CMS\Extbase\Mvc\Web\Routing\UriBuilder;
21 18 
 use TYPO3\CMS\Fluid\Core\Rendering\RenderingContextInterface;
22 19 
 use TYPO3\CMS\Fluid\Core\ViewHelper\Facets\CompilableInterface;
23 20
Please login to merge, or discard this patch.
Classes/ViewHelpers/Uri/Sorting/RemoveSortingViewHelper.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -45,7 +45,7 @@
 
 block discarded – undo
45 45
46 46 
     /**
47 47 
      * @param array $arguments
48 
-     * @param callable $renderChildrenClosure
48 
+     * @param \Closure $renderChildrenClosure
49 49 
      * @param RenderingContextInterface $renderingContext
50 50 
      * @return string
51 51 
      */
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch 
@@ -14,10 +14,7 @@
 
 block discarded – undo
14 14 
  * The TYPO3 project - inspiring people to share!
15 15 
  */
16 16
17 
-use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\SearchResultSet;
18 17 
 use ApacheSolrForTypo3\Solr\ViewHelpers\Uri\AbstractUriViewHelper;
19 
-use TYPO3\CMS\Core\Utility\GeneralUtility;
20 
-use TYPO3\CMS\Extbase\Mvc\Web\Routing\UriBuilder;
21 18 
 use TYPO3\CMS\Fluid\Core\Rendering\RenderingContextInterface;
22 19 
 use TYPO3\CMS\Fluid\Core\ViewHelper\Facets\CompilableInterface;
23 20
Please login to merge, or discard this patch.