Failed Conditions
Pull Request — experimental/sf (#3225)
by Kentaro
58:20 queued 49:13
created

11,863 -157 Covered Lines

17,177 +76 Total Lines

69.1 % -1.2% Code Coverage

PHP Classes Changes

 
0%
CustomerAddressType added
 
0%
PaymentDispatcher added
 
87.5%
PriceChangeValidator added
 
100%
CartItemRepository added
 
100%
CartRepository added
100%
20%
PaymentResult got worse
67.51%
23.98%
PluginService got worse
44.44%
3.7%
PluginEventHandlerRepository got worse
66.67%
33.33%
PluginRepository got worse
75%
100%
Cash improved
85.71%
65%
SecurityListener got worse
100%
80%
CartController got worse
84.83%
92.75%
ProductController improved
34.31%
27.31%
NonMemberShoppingController got worse
94.44%
88.89%
ConfigManager got worse
view more  

CRAP Changes

 
12
CustomerAddressType::buildForm() added
 
6
CartService::mergeFromPersistedCart() added
 
5.0488
PriceChangeValidator::process() added
 
5
CartService::mergeCartItems() added
 
4.0119
EccubeExtension::getExtensionIcon() added
 
4
CartService::createCartKey() added
 
3
CartService::getUser() added
 
2.032
ShoppingController::doCheckoutOrder() added
 
2
CreditCard::setOrder() added
 
2
EccubePaymentCreditCard::verify() added
view more  
5.0133
5.0113
FileController::index() improved
7.0145
7.0119
ShoppingController::index() improved
3
3.0175
ConfigManager::writePluginConfigCache() got worse
9.3752
9.3546
ProductController::index() improved
2
2.032
ConfigManager::removePluginConfigCache() got worse
8.1393
8.1756
EntryController::index() got worse
11.0284
11.0775
NonMemberShoppingController::index() got worse
7.0222
7.0753
ConfigManager::parsePluginConfigs() got worse
4.25
4.3035
FileController::download() got worse
2
2.1481
PluginService::checkSamePlugin() got worse
view more  
30
 
CartService::loadItems() removed
5
 
CartService::mergeCartitems() removed
3
 
CartService::mergeFromOrders() removed
2.0625
 
ShippingMultipleController::getCustomerAddressId() removed
2
 
ShippingMultipleController::getCustomerAddress() removed
2
 
Cash::setApplication() removed
2
 
EccubePaymentCreditCard::setApplication() removed
2
 
EccubePaymentCreditCard::setRequest() removed
1
 
CartService::unlock() removed
1
 
CartService::lock() removed
view more