Summary - Inspection of "[WIP] PaymentMethod の改良" - EC-CUBE/ec-cube - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — experimental/sf (#3225)

by Kentaro

created 2018-06-22 07:52 UTC

Configuration has changed

The configuration has changed since Scrutinizer has last run. This page might contain changes that are not related to code modifications.

Changes

3 failure conditions met `issues.label("coding-style").new.count > 5` File Path Number of issues html/template/default/assets/js/script.js 1 html/template/admin/assets/js/file_manager.js 17 codeception/_support/Page/Admin/FileManagePage.php 4 codeception/acceptance/EF03OrderCest.php 3 codeception/acceptance/EF05MypageCest.php 1 src/Eccube/Form/Type/AddCartType.php 1 src/Eccube/Form/Type/ShippingMultipleItemType.php 1 `issues.severity(>= MAJOR).new.exists` File Path Number of issues html/template/default/assets/js/script.js 1 html/template/admin/assets/js/file_manager.js 18 codeception/_support/Page/Admin/FileManagePage.php 4 codeception/acceptance/EF03OrderCest.php 3 codeception/acceptance/EF05MypageCest.php 1 src/Eccube/Form/Type/AddCartType.php 1 src/Eccube/Form/Type/ShippingMultipleItemType.php 1 src/Eccube/Command/DeleteCartsCommand.php 1 Eccube/Controller/Admin/Content/FileController.php 1 html/template/default/js/eccube.js 2 `elements.rating(<= D).new.exists` Name ShoppingController::confirm()
	106 issues (5 major, 10 minor, 28 informational, 63 unknown) were introduced. 50 issues were fixed.
	Test Coverage has decreased to 69% (-1%).
	47 added classes/operations
		B	EF03OrderCest::order_購入確認画面からカートに戻る() added
		B	EF03OrderCest::order_購入確認画面からカートに戻るWithお届け先初期化() added
		A	FileManagePage::一覧_削除_accept() added
		A	EF03OrderCest::order_ログイン後に複数カートになればカートに戻す() added
		A	EF05MypageCest::mypage_お届け先編集作成変更() added
		A	DeleteCartsCommand::__construct() added
		A	DeleteCartsCommand::configure() added
		B	DeleteCartsCommand::interact() added
		A	DeleteCartsCommand::initialize() added
		A	DeleteCartsCommand::execute() added
C	↗	B	FileController::create() improved
A	↘	C	CartService::restoreCarts() got worse
C	↘	D	ShoppingController::confirm() got worse
D	↗	C	ProductController::addCart() improved
A	↘	B	SecurityListener::onInteractiveLogin() got worse
B	↗	A	PluginService::install() improved
B	↗	A	ShoppingService::getNonMember() improved
C	↗	B	ShippingMultipleController improved
view all

7.46

▲ + 0.03

Test Coverage

69%

▼ -1% – Changes

Head	Kentaro Ohkouchi 2018-06-22 07:52 GMT+0000 Merge 9c28725ed5e2fb9b574c9541f3f581e4f1bcf55c into 849ab78884655ec59948a5eaad6878e92f76b005
⋮	192 more commits
Base	Kentaro Ohkouchi 2018-06-08 02:06 UTC Merge 85ddaeeb9cb881545dbafe3b29e84f1ecb76c4b8 into b2a47ba7eb30d43fe4c0194cef8b2d34aeef7b54

EC-CUBE / ec-cube

Pull Request — experimental/sf (#3225)

Configuration has changed

Changes

3 failure conditions met