EC-CUBE / ec-cube

src/Eccube/Service/CsvExportService.php

Doc Comments -1 removed lines

@@ -326,7 +326,6 @@
 
     /**
      * @param $row
-     * @param null $callback
      */
     public function fputcsv($row)
     {

Unused Use Statements +3 added lines, -3 removed lines

@@ -16,7 +16,10 @@ 
 use Doctrine\Common\Collections\ArrayCollection;
 use Doctrine\Common\Util\ClassUtils;
 use Doctrine\ORM\EntityManagerInterface;
+use Doctrine\ORM\QueryBuilder;
 use Eccube\Common\EccubeConfig;
+use Eccube\Entity\Csv;
+use Eccube\Entity\Master\CsvType;
 use Eccube\Form\Type\Admin\SearchProductType;
 use Eccube\Form\Type\Admin\SearchShippingType;
 use Eccube\Repository\CsvRepository;
@@ -29,9 +32,6 @@ 
 use Eccube\Util\FormUtil;
 use Symfony\Component\Form\FormFactoryInterface;
 use Symfony\Component\HttpFoundation\Request;
-use Doctrine\ORM\QueryBuilder;
-use Eccube\Entity\Master\CsvType;
-use Eccube\Entity\Csv;
 
 class CsvExportService
 {

src/Eccube/Doctrine/ORM/Tools/Pagination/Paginator.php

Doc Comments +1 added lines, -1 removed lines

@@ -57,7 +57,7 @@
     /**
      * Constructor.
      *
-     * @param Query|QueryBuilder $query               A Doctrine ORM query or query builder.
+     * @param Query $query               A Doctrine ORM query or query builder.
      * @param boolean            $fetchJoinCollection Whether the query joins a collection (true by default).
      */
     public function __construct($query, $fetchJoinCollection = true)

Unused Use Statements +1 added lines, -1 removed lines

@@ -15,9 +15,9 @@
 
 use Doctrine\ORM\NoResultException;
 use Doctrine\ORM\Query;
+use Doctrine\ORM\QueryBuilder;
 use Doctrine\ORM\Query\Parser;
 use Doctrine\ORM\Query\ResultSetMapping;
-use Doctrine\ORM\QueryBuilder;
 
 /**
  * The paginator can handle various complex scenarios with DQL.

src/Eccube/Doctrine/Query/WhereClause.php

Doc Comments +3 added lines

@@ -53,6 +53,9 @@
         $this->params = $params;
     }
 
+    /**
+     * @param Expr\Comparison $expr
+     */
     private static function newWhereClause($expr, $x, $y)
     {
         if ($y) {

Unused Use Statements +1 added lines, -1 removed lines

@@ -13,8 +13,8 @@
 
 namespace Eccube\Doctrine\Query;
 
-use Doctrine\ORM\Query\Expr;
 use Doctrine\ORM\QueryBuilder;
+use Doctrine\ORM\Query\Expr;
 
 /**
  * WHERE句を組み立てるクラス。

src/Eccube/Controller/ShoppingController.php

Spacing +1 added lines, -1 removed lines

@@ -817,7 +817,7 @@
                 if ($dispatcher instanceof Response
                     && ($dispatcher->isRedirection() || $dispatcher->getContent())
                 ) { // $paymentMethod->apply() が Response を返した場合は画面遷移
-                    return $dispatcher;                // 画面遷移したいパターンが複数ある場合はどうする？ 引数で制御？
+                    return $dispatcher; // 画面遷移したいパターンが複数ある場合はどうする？ 引数で制御？
                 }
                 $PaymentResult = $paymentService->doCheckout($paymentMethod); // 決済実行
                 if (!$PaymentResult->isSuccess()) {

Indentation +6 added lines, -6 removed lines

@@ -689,12 +689,12 @@
         $builder = $this->formFactory->createBuilder(OrderType::class, $Order);
 
         $event = new EventArgs(
-             [
-                 'builder' => $builder,
-                 'Order' => $Order,
-             ],
-             $request
-         );
+                [
+                    'builder' => $builder,
+                    'Order' => $Order,
+                ],
+                $request
+            );
         $this->eventDispatcher->dispatch(EccubeEvents::FRONT_SHOPPING_INDEX_INITIALIZE, $event);
 
         $form = $builder->getForm();

src/Eccube/ServiceProvider/QueriesServiceProvider.php

Doc Comments -1 removed lines

@@ -16,7 +16,6 @@
      * This method should only be used to configure services and parameters.
      * It should not get services.
      *
-     * @param Container $pimple A container instance
      */
     public function register(Container $app)
     {

src/Eccube/Service/PluginService.php

Unused Use Statements -1 removed lines

@@ -33,7 +33,6 @@
 use Eccube\Entity\Plugin;
 use Eccube\Entity\PluginEventHandler;
 use Eccube\Exception\PluginException;
-use Eccube\Plugin\ConfigManager;
 use Eccube\Plugin\ConfigManager as PluginConfigManager;
 use Eccube\Repository\PluginEventHandlerRepository;
 use Eccube\Repository\PluginRepository;

Doc Comments +13 added lines, -7 removed lines

@@ -147,7 +147,7 @@ 
      * @param string $path   path to tar.gz/zip plugin file
      * @param int    $source
      *
-     * @return mixed
+     * @return boolean
      *
      * @throws PluginException
      * @throws \Exception
@@ -274,8 +274,8 @@ 
     }
 
     /**
-     * @param $archive
-     * @param $dir
+     * @param string $archive
+     * @param string $dir
      *
      * @throws PluginException
      */
@@ -344,6 +344,9 @@ 
         }
     }
 
+    /**
+     * @param string $yml
+     */
     public function readYml($yml)
     {
         if (file_exists($yml)) {
@@ -361,6 +364,9 @@ 
         // ディレクトリ名などに使われれるので厳しめ
     }
 
+    /**
+     * @param string $path
+     */
     public function deleteFile($path)
     {
         $f = new Filesystem();
@@ -381,7 +387,7 @@ 
     }
 
     /**
-     * @param $d
+     * @param string $d
      *
      * @throws PluginException
      */
@@ -456,7 +462,7 @@ 
 
     /**
      * @param $meta
-     * @param $method
+     * @param string $method
      */
     public function callPluginManagerMethod($meta, $method)
     {
@@ -997,7 +1003,7 @@ 
      * [プラグインコード]/Resource/assets
      * 配下に置かれているファイルが所定の位置へコピーされる
      *
-     * @param $pluginBaseDir
+     * @param string $pluginBaseDir
      * @param $pluginCode
      */
     public function copyAssets($pluginBaseDir, $pluginCode)
@@ -1033,7 +1039,7 @@ 
      * @param string $pluginVersion
      * @param string $remoteVersion
      *
-     * @return mixed
+     * @return boolean
      */
     public function isUpdate($pluginVersion, $remoteVersion)
     {

app/Acme/Controller/RoutingTestController.php

Doc Comments +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
      *
      * @param Application $app
      *
-     * @return \Symfony\Component\HttpFoundation\Response
+     * @return string
      */
     public function testAdmin(Application $app)
     {

codeception/_support/Interactions/DragAndDropBy.php

Doc Comments +3 added lines

@@ -12,6 +12,9 @@
 
 class DragAndDropBy extends WebDriverActions
 {
+    /**
+     * @param \Facebook\WebDriver\Remote\RemoteWebElement $source
+     */
     public function __construct(WebDriver $driver, $source, $x_offset, $y_offset)
     {
         parent::__construct($driver);

codeception/_support/Interactions/WaitAction.php

Doc Comments +3 added lines

@@ -14,6 +14,9 @@
      */
     private $timeout_in_second;
 
+    /**
+     * @param integer $timeout_in_second
+     */
     function __construct($timeout_in_second)
     {
         $this->timeout_in_second = $timeout_in_second;