EC-CUBE / ec-cube

codeception/acceptance/EA06ContentsManagementCest.php

Unused Use Statements +2 added lines, -2 removed lines

@@ -6,10 +6,10 @@
 use Page\Admin\FileManagePage;
 use Page\Admin\LayoutEditPage;
 use Page\Admin\LayoutManagePage;
-use Page\Admin\NewsManagePage;
 use Page\Admin\NewsEditPage;
-use Page\Admin\PageManagePage;
+use Page\Admin\NewsManagePage;
 use Page\Admin\PageEditPage;
+use Page\Admin\PageManagePage;
 
 /**
  * @group admin

codeception/acceptance/EF03OrderCest.php

Unused Use Statements +2 added lines, -2 removed lines

@@ -2,14 +2,14 @@
 
 use Codeception\Util\Fixtures;
 use Page\Front\CartPage;
+use Page\Front\CustomerAddressAddPage;
+use Page\Front\MultipleShippingPage;
 use Page\Front\ProductDetailPage;
 use Page\Front\ShippingEditPage;
 use Page\Front\ShoppingCompletePage;
 use Page\Front\ShoppingConfirmPage;
 use Page\Front\ShoppingLoginPage;
 use Page\Front\ShoppingPage;
-use Page\Front\MultipleShippingPage;
-use Page\Front\CustomerAddressAddPage;
 
 /**
  * @group front

Spacing +6 added lines, -6 removed lines

@@ -461,11 +461,11 @@ 
 
         // 名前を比較してお届け先が上下どちらに表示されるか判断
         $compared = strnatcmp($customer->getName01(), $nameSei);
-        if($compared === 0) {
+        if ($compared === 0) {
             $compared = strnatcmp($customer->getName02(), $nameMei);
         }
         // 上下それぞれで名前、商品個数を設定
-        if($compared < 0) {
+        if ($compared < 0) {
             $quantity1 = $shipping1_quantity;
             $quantity2 = $shipping2_quantity;
             $name1 = $customer->getName01();
@@ -666,11 +666,11 @@ 
 
         // 名前を比較してお届け先が上下どちらに表示されるか判断
         $compared = strnatcmp($customer->getName01(), $nameSei);
-        if($compared === 0) {
+        if ($compared === 0) {
             $compared = strnatcmp($customer->getName02(), $nameMei);
         }
         // 上下それぞれで名前、商品個数を設定
-        if($compared < 0) {
+        if ($compared < 0) {
             $quantity1 = $shipping1_quantity;
             $quantity2 = $shipping2_quantity;
             $name1 = $customer->getName01();
@@ -826,11 +826,11 @@ 
 
         // 名前を比較してお届け先が上下どちらに表示されるか判断
         $compared = strnatcmp($customer->getName01(), $nameSei);
-        if($compared === 0) {
+        if ($compared === 0) {
             $compared = strnatcmp($customer->getName02(), $nameMei);
         }
         // 上下それぞれで名前、商品個数を設定
-        if($compared < 0) {
+        if ($compared < 0) {
             $quantity1 = $shipping1_quantity;
             $quantity2 = $shipping2_quantity;
             $name1 = $customer->getName01();

src/Eccube/Controller/Admin/Content/FileController.php

Unused Use Statements +4 added lines, -4 removed lines

@@ -14,22 +14,22 @@
 namespace Eccube\Controller\Admin\Content;
 
 use Eccube\Controller\AbstractController;
+use Eccube\Util\FilesystemUtil;
+use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
-use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
+use Symfony\Component\Filesystem\Exception\IOException;
 use Symfony\Component\Filesystem\Filesystem;
 use Symfony\Component\Finder\Finder;
 use Symfony\Component\Form\Extension\Core\Type\FileType;
 use Symfony\Component\Form\Extension\Core\Type\FormType;
 use Symfony\Component\Form\Extension\Core\Type\TextType;
 use Symfony\Component\HttpFoundation\BinaryFileResponse;
+use Symfony\Component\HttpFoundation\File\Exception\FileException;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\ResponseHeaderBag;
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
-use Symfony\Component\HttpFoundation\File\Exception\FileException;
 use Symfony\Component\Validator\Constraints as Assert;
-use Eccube\Util\FilesystemUtil;
-use Symfony\Component\Filesystem\Exception\IOException;
 
 class FileController extends AbstractController
 {

src/Eccube/Controller/Admin/Product/ProductController.php

Unused Use Statements +9 added lines, -9 removed lines

@@ -17,7 +17,14 @@ 
 use Eccube\Common\Constant;
 use Eccube\Controller\AbstractController;
 use Eccube\Entity\BaseInfo;
+use Eccube\Entity\ExportCsvRow;
 use Eccube\Entity\Master\CsvType;
+use Eccube\Entity\Master\ProductStatus;
+use Eccube\Entity\Product;
+use Eccube\Entity\ProductCategory;
+use Eccube\Entity\ProductClass;
+use Eccube\Entity\ProductImage;
+use Eccube\Entity\ProductStock;
 use Eccube\Entity\ProductTag;
 use Eccube\Event\EccubeEvents;
 use Eccube\Event\EventArgs;
@@ -32,28 +39,21 @@ 
 use Eccube\Repository\TagRepository;
 use Eccube\Repository\TaxRuleRepository;
 use Eccube\Service\CsvExportService;
+use Eccube\Util\FormUtil;
 use Knp\Component\Pager\Paginator;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\ParamConverter;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
-use Eccube\Util\FormUtil;
 use Symfony\Component\Filesystem\Filesystem;
 use Symfony\Component\HttpFoundation\File\File;
 use Symfony\Component\HttpFoundation\JsonResponse;
+use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\StreamedResponse;
 use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 use Symfony\Component\HttpKernel\Exception\UnsupportedMediaTypeHttpException;
-use Eccube\Entity\Product;
-use Eccube\Entity\ProductClass;
-use Eccube\Entity\Master\ProductStatus;
-use Eccube\Entity\ProductStock;
-use Eccube\Entity\ProductImage;
-use Eccube\Entity\ProductCategory;
-use Eccube\Entity\ExportCsvRow;
-use Symfony\Component\HttpFoundation\RedirectResponse;
 
 class ProductController extends AbstractController
 {

src/Eccube/Controller/ShippingMultipleController.php

Unused Use Statements +2 added lines, -2 removed lines

@@ -26,11 +26,11 @@
 use Eccube\Repository\Master\OrderItemTypeRepository;
 use Eccube\Repository\Master\PrefRepository;
 use Eccube\Repository\OrderRepository;
+use Eccube\Service\CartService;
+use Eccube\Service\OrderHelper;
 use Eccube\Service\PurchaseFlow\PurchaseContext;
 use Eccube\Service\PurchaseFlow\PurchaseFlow;
 use Eccube\Service\ShoppingService;
-use Eccube\Service\CartService;
-use Eccube\Service\OrderHelper;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
 use Symfony\Component\Form\Extension\Core\Type\CollectionType;

src/Eccube/Service/CartService.php

Doc Comments +3 added lines

@@ -438,6 +438,9 @@
         return $user;
     }
 
+    /**
+     * @param string $allocatedId
+     */
     protected function createCartKey($allocatedId, Customer $Customer = null)
     {
         if ($Customer instanceof Customer) {

Unused Use Statements +2 added lines, -2 removed lines

@@ -13,6 +13,7 @@ 
 
 namespace Eccube\Service;
 
+use Doctrine\ORM\EntityManagerInterface;
 use Doctrine\ORM\UnitOfWork;
 use Eccube\Entity\Cart;
 use Eccube\Entity\CartItem;
@@ -20,15 +21,14 @@ 
 use Eccube\Entity\ItemHolderInterface;
 use Eccube\Entity\ProductClass;
 use Eccube\Repository\CartRepository;
-use Eccube\Repository\ProductClassRepository;
 use Eccube\Repository\OrderRepository;
+use Eccube\Repository\ProductClassRepository;
 use Eccube\Service\Cart\CartItemAllocator;
 use Eccube\Service\Cart\CartItemComparator;
 use Eccube\Util\StringUtil;
 use Symfony\Component\HttpFoundation\Session\SessionInterface;
 use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
 use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;
-use Doctrine\ORM\EntityManagerInterface;
 
 class CartService
 {

src/Eccube/Service/CsvExportService.php

Unused Use Statements +3 added lines, -3 removed lines

@@ -16,7 +16,10 @@ 
 use Doctrine\Common\Collections\ArrayCollection;
 use Doctrine\Common\Util\ClassUtils;
 use Doctrine\ORM\EntityManagerInterface;
+use Doctrine\ORM\QueryBuilder;
 use Eccube\Common\EccubeConfig;
+use Eccube\Entity\Csv;
+use Eccube\Entity\Master\CsvType;
 use Eccube\Form\Type\Admin\SearchProductType;
 use Eccube\Form\Type\Admin\SearchShippingType;
 use Eccube\Repository\CsvRepository;
@@ -29,9 +32,6 @@ 
 use Eccube\Util\FormUtil;
 use Symfony\Component\Form\FormFactoryInterface;
 use Symfony\Component\HttpFoundation\Request;
-use Doctrine\ORM\QueryBuilder;
-use Eccube\Entity\Master\CsvType;
-use Eccube\Entity\Csv;
 
 class CsvExportService
 {

src/Eccube/Service/PluginService.php

Doc Comments +13 added lines, -7 removed lines

@@ -147,7 +147,7 @@ 
      * @param string $path   path to tar.gz/zip plugin file
      * @param int    $source
      *
-     * @return mixed
+     * @return boolean
      *
      * @throws PluginException
      * @throws \Exception
@@ -274,8 +274,8 @@ 
     }
 
     /**
-     * @param $archive
-     * @param $dir
+     * @param string $archive
+     * @param string $dir
      *
      * @throws PluginException
      */
@@ -344,6 +344,9 @@ 
         }
     }
 
+    /**
+     * @param string $yml
+     */
     public function readYml($yml)
     {
         if (file_exists($yml)) {
@@ -361,6 +364,9 @@ 
         // ディレクトリ名などに使われれるので厳しめ
     }
 
+    /**
+     * @param string $path
+     */
     public function deleteFile($path)
     {
         $f = new Filesystem();
@@ -381,7 +387,7 @@ 
     }
 
     /**
-     * @param $d
+     * @param string $d
      *
      * @throws PluginException
      */
@@ -456,7 +462,7 @@ 
 
     /**
      * @param $meta
-     * @param $method
+     * @param string $method
      */
     public function callPluginManagerMethod($meta, $method)
     {
@@ -997,7 +1003,7 @@ 
      * [プラグインコード]/Resource/assets
      * 配下に置かれているファイルが所定の位置へコピーされる
      *
-     * @param $pluginBaseDir
+     * @param string $pluginBaseDir
      * @param $pluginCode
      */
     public function copyAssets($pluginBaseDir, $pluginCode)
@@ -1033,7 +1039,7 @@ 
      * @param string $pluginVersion
      * @param string $remoteVersion
      *
-     * @return mixed
+     * @return boolean
      */
     public function isUpdate($pluginVersion, $remoteVersion)
     {