EC-CUBE / ec-cube

src/Eccube/Service/CartService.php

Doc Comments +3 added lines

@@ -438,6 +438,9 @@
         return $user;
     }
 
+    /**
+     * @param string $allocatedId
+     */
     protected function createCartKey($allocatedId, Customer $Customer = null)
     {
         if ($Customer instanceof Customer) {

src/Eccube/Service/PluginService.php

Doc Comments +13 added lines, -7 removed lines

@@ -147,7 +147,7 @@ 
      * @param string $path   path to tar.gz/zip plugin file
      * @param int    $source
      *
-     * @return mixed
+     * @return boolean
      *
      * @throws PluginException
      * @throws \Exception
@@ -274,8 +274,8 @@ 
     }
 
     /**
-     * @param $archive
-     * @param $dir
+     * @param string $archive
+     * @param string $dir
      *
      * @throws PluginException
      */
@@ -344,6 +344,9 @@ 
         }
     }
 
+    /**
+     * @param string $yml
+     */
     public function readYml($yml)
     {
         if (file_exists($yml)) {
@@ -361,6 +364,9 @@ 
         // ディレクトリ名などに使われれるので厳しめ
     }
 
+    /**
+     * @param string $path
+     */
     public function deleteFile($path)
     {
         $f = new Filesystem();
@@ -381,7 +387,7 @@ 
     }
 
     /**
-     * @param $d
+     * @param string $d
      *
      * @throws PluginException
      */
@@ -456,7 +462,7 @@ 
 
     /**
      * @param $meta
-     * @param $method
+     * @param string $method
      */
     public function callPluginManagerMethod($meta, $method)
     {
@@ -997,7 +1003,7 @@ 
      * [プラグインコード]/Resource/assets
      * 配下に置かれているファイルが所定の位置へコピーされる
      *
-     * @param $pluginBaseDir
+     * @param string $pluginBaseDir
      * @param $pluginCode
      */
     public function copyAssets($pluginBaseDir, $pluginCode)
@@ -1033,7 +1039,7 @@ 
      * @param string $pluginVersion
      * @param string $remoteVersion
      *
-     * @return mixed
+     * @return boolean
      */
     public function isUpdate($pluginVersion, $remoteVersion)
     {

codeception/acceptance/EF03OrderCest.php

Spacing +6 added lines, -6 removed lines

@@ -461,11 +461,11 @@ 
 
         // 名前を比較してお届け先が上下どちらに表示されるか判断
         $compared = strnatcmp($customer->getName01(), $nameSei);
-        if($compared === 0) {
+        if ($compared === 0) {
             $compared = strnatcmp($customer->getName02(), $nameMei);
         }
         // 上下それぞれで名前、商品個数を設定
-        if($compared < 0) {
+        if ($compared < 0) {
             $quantity1 = $shipping1_quantity;
             $quantity2 = $shipping2_quantity;
             $name1 = $customer->getName01();
@@ -666,11 +666,11 @@ 
 
         // 名前を比較してお届け先が上下どちらに表示されるか判断
         $compared = strnatcmp($customer->getName01(), $nameSei);
-        if($compared === 0) {
+        if ($compared === 0) {
             $compared = strnatcmp($customer->getName02(), $nameMei);
         }
         // 上下それぞれで名前、商品個数を設定
-        if($compared < 0) {
+        if ($compared < 0) {
             $quantity1 = $shipping1_quantity;
             $quantity2 = $shipping2_quantity;
             $name1 = $customer->getName01();
@@ -826,11 +826,11 @@ 
 
         // 名前を比較してお届け先が上下どちらに表示されるか判断
         $compared = strnatcmp($customer->getName01(), $nameSei);
-        if($compared === 0) {
+        if ($compared === 0) {
             $compared = strnatcmp($customer->getName02(), $nameMei);
         }
         // 上下それぞれで名前、商品個数を設定
-        if($compared < 0) {
+        if ($compared < 0) {
             $quantity1 = $shipping1_quantity;
             $quantity2 = $shipping2_quantity;
             $name1 = $customer->getName01();