Codeception / Codeception

src/Codeception/Module/Db.php

Doc Comments +11 added lines

@@ -402,6 +402,9 @@ 
         return $lastInsertId;
     }
     
+    /**
+     * @param string $table
+     */
     public function _insertInDatabase($table, array $data)
     {
         $query = $this->driver->insert($table, $data);
@@ -420,6 +423,10 @@ 
         return $lastInsertId;
     }
 
+    /**
+     * @param string $table
+     * @param integer $id
+     */
     private function addInsertedRow($table, array $row, $id)
     {
         $primaryKey = $this->driver->getPrimaryKey($table);
@@ -510,6 +517,10 @@ 
         return (int) $this->proceedSeeInDatabase($table, 'count(*)', $criteria);
     }
 
+    /**
+     * @param string $table
+     * @param string $column
+     */
     protected function proceedSeeInDatabase($table, $column, $criteria)
     {
         $query = $this->driver->select($column, $table, $criteria);

ext/RunFailed.php

Spacing +3 added lines, -3 removed lines

@@ -45,12 +45,12 @@ 
             $this->group = $this->config['fail-group'];
         }
         $logPath = str_replace($this->getRootDir(), '', $this->getLogDir()); // get local path to logs
-        $this->_reconfigure(['groups' => [$this->group => $logPath . $this->group]]);
+        $this->_reconfigure(['groups' => [$this->group => $logPath.$this->group]]);
     }
 
     public function saveFailed(PrintResultEvent $e)
     {
-        $file = $this->getLogDir() . $this->group;
+        $file = $this->getLogDir().$this->group;
         $result = $e->getResult();
         if ($result->wasSuccessful()) {
             if (is_file($file)) {
@@ -71,7 +71,7 @@ 
 
     protected function localizePath($path)
     {
-        $root = realpath($this->getRootDir()) . DIRECTORY_SEPARATOR;
+        $root = realpath($this->getRootDir()).DIRECTORY_SEPARATOR;
         if (substr($path, 0, strlen($root)) == $root) {
             return substr($path, strlen($root));
         }

src/Codeception/Lib/Driver/Db.php

Spacing +10 added lines, -10 removed lines

@@ -118,7 +118,7 @@ 
                 continue;
             }
 
-            $query .= "\n" . rtrim($sqlLine);
+            $query .= "\n".rtrim($sqlLine);
 
             if (substr($query, -1 * $delimiterLength, $delimiterLength) == $delimiter) {
                 $this->sqlQuery(substr($query, 0, -1 * $delimiterLength));
@@ -177,7 +177,7 @@ 
         $params = [];
         foreach ($criteria as $k => $v) {
             if ($v === null) {
-                $params[] = $this->getQuotedName($k) . " IS NULL ";
+                $params[] = $this->getQuotedName($k)." IS NULL ";
                 unset($criteria[$k]);
                 continue;
             }
@@ -192,16 +192,16 @@ 
                 $hasOperand = true;
                 $k = str_ireplace(" $operand", '', $k);
                 $operand = strtoupper($operand);
-                $params[] = $this->getQuotedName($k) . " $operand ? ";
+                $params[] = $this->getQuotedName($k)." $operand ? ";
                 break;
             }
 
             if (!$hasOperand) {
-                $params[] = $this->getQuotedName($k) . " = ? ";
+                $params[] = $this->getQuotedName($k)." = ? ";
             }
         }
 
-        return 'WHERE ' . implode('AND ', $params);
+        return 'WHERE '.implode('AND ', $params);
     }
     
     /**
@@ -209,7 +209,7 @@ 
      */
     public function deleteQuery($table, $id, $primaryKey = 'id')
     {
-        $query = 'DELETE FROM ' . $this->getQuotedName($table) . ' WHERE ' . $this->getQuotedName($primaryKey) . ' = ?';
+        $query = 'DELETE FROM '.$this->getQuotedName($table).' WHERE '.$this->getQuotedName($primaryKey).' = ?';
         $this->executeQuery($query, [$id]);
     }
 
@@ -217,7 +217,7 @@ 
     {
         $where = $this->generateWhereClause($criteria);
 
-        $query = 'DELETE FROM ' . $this->getQuotedName($table) . ' ' . $where;
+        $query = 'DELETE FROM '.$this->getQuotedName($table).' '.$where;
         $this->executeQuery($query, array_values($criteria));
     }
 
@@ -228,7 +228,7 @@ 
 
     public function getQuotedName($name)
     {
-        return '"' . str_replace('.', '"."', $name) . '"';
+        return '"'.str_replace('.', '"."', $name).'"';
     }
 
     protected function sqlLine($sql)
@@ -248,7 +248,7 @@ 
         } catch (\PDOException $e) {
             throw new ModuleException(
                 'Codeception\Module\Db',
-                $e->getMessage() . "\nSQL query being executed: " . $query
+                $e->getMessage()."\nSQL query being executed: ".$query
             );
         }
     }
@@ -328,7 +328,7 @@ 
 
         $set = [];
         foreach ($data as $column => $value) {
-            $set[] = $this->getQuotedName($column) . " = ?";
+            $set[] = $this->getQuotedName($column)." = ?";
         }
 
         $where = $this->generateWhereClause($criteria);

Doc Comments +6 added lines

@@ -33,6 +33,9 @@ 
      */
     protected $primaryKeys = [];
 
+    /**
+     * @param string $dsn
+     */
     public static function connect($dsn, $user, $password, $options = null)
     {
         $dbh = new \PDO($dsn, $user, $password, $options);
@@ -339,6 +342,9 @@ 
         return empty($this->primaryKeys);
     }
 
+    /**
+     * @param string $table
+     */
     public function update($table, array $data, array $criteria)
     {
         if (empty($data)) {

src/Codeception/Lib/Driver/PostgreSql.php

Doc Comments +3 added lines

@@ -85,6 +85,9 @@
         return true;
     }
 
+    /**
+     * @param string $query
+     */
     public function sqlQuery($query)
     {
         if (strpos(trim($query), 'COPY ') === 0) {

Spacing +8 added lines, -8 removed lines

@@ -48,7 +48,7 @@ 
                 $this->searchPath = $match[0];
             }
 
-            $query .= "\n" . rtrim($sqlLine);
+            $query .= "\n".rtrim($sqlLine);
 
             if (!$dollarsOpen && substr($query, -1 * $delimiterLength, $delimiterLength) == $delimiter) {
                 $this->sqlQuery(substr($query, 0, -1 * $delimiterLength));
@@ -75,11 +75,11 @@ 
 
         if ($sql == '\.') {
             $this->putline = false;
-            pg_put_line($this->connection, $sql . "\n");
+            pg_put_line($this->connection, $sql."\n");
             pg_end_copy($this->connection);
             pg_close($this->connection);
         } else {
-            pg_put_line($this->connection, $sql . "\n");
+            pg_put_line($this->connection, $sql."\n");
         }
 
         return true;
@@ -101,8 +101,8 @@ 
                 );
             }
             $constring = str_replace(';', ' ', substr($this->dsn, 6));
-            $constring .= ' user=' . $this->user;
-            $constring .= ' password=' . $this->password;
+            $constring .= ' user='.$this->user;
+            $constring .= ' password='.$this->password;
             $this->connection = pg_connect($constring);
 
             if ($this->searchPath !== null) {
@@ -126,7 +126,7 @@ 
          * is based on how postgres names sequences for SERIAL columns
          */
 
-        $sequenceName = $this->getQuotedName($table . '_id_seq');
+        $sequenceName = $this->getQuotedName($table.'_id_seq');
         $lastSequence = null;
 
         try {
@@ -140,7 +140,7 @@ 
         if (!$lastSequence) {
             $primaryKeys = $this->getPrimaryKey($table);
             $pkName = array_shift($primaryKeys);
-            $lastSequence = $this->getDbh()->lastInsertId($this->getQuotedName($table . '_' . $pkName . '_seq'));
+            $lastSequence = $this->getDbh()->lastInsertId($this->getQuotedName($table.'_'.$pkName.'_seq'));
         }
 
         return $lastSequence;
@@ -167,7 +167,7 @@ 
             $stmt = $this->executeQuery($query, []);
             $columns = $stmt->fetchAll(\PDO::FETCH_ASSOC);
             foreach ($columns as $column) {
-                $primaryKey []= $column['attname'];
+                $primaryKey [] = $column['attname'];
             }
             $this->primaryKeys[$tableName] = $primaryKey;
         }

src/Codeception/Lib/Driver/SqlSrv.php

Spacing +5 added lines, -5 removed lines

@@ -58,18 +58,18 @@ 
         foreach ($criteria as $k => $v) {
             if (strpos(strtolower($k), ' like') > 0) {
                 $k = str_replace(' like', '', strtolower($k));
-                $params[] = $this->getQuotedName($k) . " LIKE ? ";
+                $params[] = $this->getQuotedName($k)." LIKE ? ";
             } else {
-                $params[] = $this->getQuotedName($k) . " = ? ";
+                $params[] = $this->getQuotedName($k)." = ? ";
             }
         }
 
-        return 'WHERE ' . implode('AND ', $params);
+        return 'WHERE '.implode('AND ', $params);
     }
 
     public function getQuotedName($name)
     {
-        return '[' . str_replace('.', '].[', $name) . ']';
+        return '['.str_replace('.', '].[', $name).']';
     }
 
     /**
@@ -93,7 +93,7 @@ 
             $columns = $stmt->fetchAll(\PDO::FETCH_ASSOC);
 
             foreach ($columns as $column) {
-                $primaryKey []= $column['Column_Name'];
+                $primaryKey [] = $column['Column_Name'];
             }
             $this->primaryKeys[$tableName] = $primaryKey;
         }

src/Codeception/Coverage/Subscriber/RemoteServer.php

Spacing +6 added lines, -6 removed lines

@@ -42,10 +42,10 @@ 
 
     protected function retrieveAndPrintHtml($suite)
     {
-        $tempFile = tempnam(sys_get_temp_dir(), 'C3') . '.tar';
+        $tempFile = tempnam(sys_get_temp_dir(), 'C3').'.tar';
         file_put_contents($tempFile, $this->c3Request('html'));
 
-        $destDir = Configuration::outputDir() . $suite . '.remote.coverage';
+        $destDir = Configuration::outputDir().$suite.'.remote.coverage';
         if (is_dir($destDir)) {
             FileSystem::doEmptyDir($destDir);
         } else {
@@ -60,22 +60,22 @@ 
 
     protected function retrieveAndPrintXml($suite)
     {
-        $destFile = Configuration::outputDir() . $suite . '.remote.coverage.xml';
+        $destFile = Configuration::outputDir().$suite.'.remote.coverage.xml';
         file_put_contents($destFile, $this->c3Request('clover'));
     }
 
     protected function retrieveAndPrintCrap4j($suite)
     {
-        $destFile = Configuration::outputDir() . $suite . '.remote.crap4j.xml';
+        $destFile = Configuration::outputDir().$suite.'.remote.crap4j.xml';
         file_put_contents($destFile, $this->c3Request('crap4j'));
     }
 
     protected function retrieveAndPrintPHPUnit($suite)
     {
-        $tempFile = tempnam(sys_get_temp_dir(), 'C3') . '.tar';
+        $tempFile = tempnam(sys_get_temp_dir(), 'C3').'.tar';
         file_put_contents($tempFile, $this->c3Request('phpunit'));
 
-        $destDir = Configuration::outputDir() . $suite . '.remote.coverage-phpunit';
+        $destDir = Configuration::outputDir().$suite.'.remote.coverage-phpunit';
         if (is_dir($destDir)) {
             FileSystem::doEmptyDir($destDir);
         } else {

src/Codeception/Module/Symfony.php

Unused Use Statements -1 removed lines

@@ -9,7 +9,6 @@
 use Codeception\Lib\Interfaces\PartedModule;
 use Symfony\Component\Finder\Finder;
 use Symfony\Component\DependencyInjection\ContainerInterface;
-use Symfony\Component\Finder\SplFileInfo;
 use Symfony\Component\VarDumper\Cloner\Data;
 
 /**

Spacing +13 added lines, -13 removed lines

@@ -172,16 +172,16 @@ 
      */
     private function initializeSymfonyCache()
     {
-        $cache = Configuration::projectDir() . $this->config['var_path'] . DIRECTORY_SEPARATOR . 'bootstrap.php.cache';
+        $cache = Configuration::projectDir().$this->config['var_path'].DIRECTORY_SEPARATOR.'bootstrap.php.cache';
         if (PHP_VERSION_ID < 70000 && !file_exists($cache)) {
             throw new ModuleRequireException(
                 __CLASS__,
-                "Symfony bootstrap file not found in $cache\n \n" .
-                "Please specify path to bootstrap file using `var_path` config option\n \n" .
-                "If you are trying to load bootstrap from a Bundle provide path like:\n \n" .
-                "modules:\n    enabled:\n" .
-                "    - Symfony:\n" .
-                "        var_path: '../../app'\n" .
+                "Symfony bootstrap file not found in $cache\n \n".
+                "Please specify path to bootstrap file using `var_path` config option\n \n".
+                "If you are trying to load bootstrap from a Bundle provide path like:\n \n".
+                "modules:\n    enabled:\n".
+                "    - Symfony:\n".
+                "        var_path: '../../app'\n".
                 "        app_path: '../../app'"
             );
         }
@@ -256,8 +256,8 @@ 
      */
     protected function getKernelClass()
     {
-        $path = codecept_root_dir() . $this->config['app_path'];
-        if (!file_exists(codecept_root_dir() . $this->config['app_path'])) {
+        $path = codecept_root_dir().$this->config['app_path'];
+        if (!file_exists(codecept_root_dir().$this->config['app_path'])) {
             throw new ModuleRequireException(
                 __CLASS__,
                 "Can't load Kernel from $path.\n"
@@ -277,9 +277,9 @@ 
         }
         $file = current($results);
 
-        if (file_exists(codecept_root_dir() . 'vendor' . DIRECTORY_SEPARATOR . 'autoload.php')) {
+        if (file_exists(codecept_root_dir().'vendor'.DIRECTORY_SEPARATOR.'autoload.php')) {
             // ensure autoloader from this dir is loaded
-            require_once codecept_root_dir() . 'vendor' . DIRECTORY_SEPARATOR . 'autoload.php';
+            require_once codecept_root_dir().'vendor'.DIRECTORY_SEPARATOR.'autoload.php';
         }
 
         require_once $file;
@@ -531,7 +531,7 @@ 
                     $this->debugSection(
                         'User',
                         $profile->getCollector('security')->getUser()
-                        . ' [' . implode(',', $roles) . ']'
+                        . ' ['.implode(',', $roles).']'
                     );
                 } else {
                     $this->debugSection('User', 'Anonymous');
@@ -540,7 +540,7 @@ 
             if ($profile->hasCollector('swiftmailer')) {
                 $messages = $profile->getCollector('swiftmailer')->getMessageCount();
                 if ($messages) {
-                    $this->debugSection('Emails', $messages . ' sent');
+                    $this->debugSection('Emails', $messages.' sent');
                 }
             }
             if ($profile->hasCollector('timer')) {

src/Codeception/Test/Metadata.php

Doc Comments +7 added lines, -7 removed lines

@@ -47,7 +47,7 @@ 
     }
 
     /**
-     * @return mixed
+     * @return string
      */
     public function getSkip()
     {
@@ -63,7 +63,7 @@ 
     }
 
     /**
-     * @return mixed
+     * @return string
      */
     public function getIncomplete()
     {
@@ -80,7 +80,7 @@ 
 
     /**
      * @param string|null $key
-     * @return mixed
+     * @return string
      */
     public function getCurrent($key = null)
     {
@@ -164,7 +164,7 @@ 
     }
 
     /**
-     * @param $service
+     * @param string $service
      * @return array
      * @throws InjectionException
      */
@@ -194,8 +194,8 @@ 
     }
 
     /**
-     * @param $type
-     * @param $report
+     * @param string $type
+     * @param string $report
      */
     public function addReport($type, $report)
     {
@@ -206,7 +206,7 @@ 
      * Returns test params like: env, group, skip, incomplete, etc
      * Can return by annotation or return all if no key passed
      *
-     * @param null $key
+     * @param string $key
      * @return array|mixed|null
      */
     public function getParam($key = null)

src/Codeception/Lib/Generator/Actions.php

Spacing +6 added lines, -6 removed lines

@@ -82,7 +82,7 @@ 
         }
 
         return (new Template($this->template))
-            ->place('namespace', $namespace ? $namespace . '\\' : '')
+            ->place('namespace', $namespace ? $namespace.'\\' : '')
             ->place('hash', self::genHash($this->modules, $this->settings))
             ->place('name', $this->name)
             ->place('methods', implode("\n\n ", $code))
@@ -103,7 +103,7 @@ 
             $doc = "*";
         }
 
-        $conditionalDoc = $doc . "\n     * Conditional Assertion: Test won't be stopped on fail";
+        $conditionalDoc = $doc."\n     * Conditional Assertion: Test won't be stopped on fail";
 
         $methodTemplate = (new Template($this->methodTemplate))
             ->place('module', $module)
@@ -115,7 +115,7 @@ 
             $type = 'Assertion';
             $body .= $methodTemplate
                 ->place('doc', $conditionalDoc)
-                ->place('action', 'can' . ucfirst($refMethod->name))
+                ->place('action', 'can'.ucfirst($refMethod->name))
                 ->place('step', 'ConditionalAssertion')
                 ->produce();
 
@@ -151,9 +151,9 @@ 
         $params = [];
         foreach ($refMethod->getParameters() as $param) {
             if ($param->isOptional()) {
-                $params[] = '$' . $param->name . ' = null';
+                $params[] = '$'.$param->name.' = null';
             } else {
-                $params[] = '$' . $param->name;
+                $params[] = '$'.$param->name;
             };
         }
         return implode(', ', $params);
@@ -197,7 +197,7 @@ 
             $actions[$moduleName] = get_class_methods(get_class($module));
         }
 
-        return md5(Codecept::VERSION . serialize($actions) . serialize($settings['modules']));
+        return md5(Codecept::VERSION.serialize($actions).serialize($settings['modules']));
     }
 
     public function getNumMethods()