Codeception / Codeception

src/Codeception/Lib/Generator/Actor.php

Doc Comments +1 added lines, -1 removed lines

@@ -149,7 +149,7 @@
 
     /**
      * @param \ReflectionMethod $refMethod
-     * @return array
+     * @return string
      */
     protected function getParamsString(\ReflectionMethod $refMethod)
     {

Spacing +4 added lines, -4 removed lines

@@ -99,9 +99,9 @@ 
         $params = [];
         foreach ($refMethod->getParameters() as $param) {
             if ($param->isOptional()) {
-                $params[] = '$' . $param->name . ' = '.$this->getDefaultValue($param);
+                $params[] = '$'.$param->name.' = '.$this->getDefaultValue($param);
             } else {
-                $params[] = '$' . $param->name;
+                $params[] = '$'.$param->name;
             };
         }
         return implode(', ', $params);
@@ -174,7 +174,7 @@ 
      */
     private function phpEncodeArray(array $array)
     {
-        $isPlainArray = function (array $value) {
+        $isPlainArray = function(array $value) {
             return ((count($value) === 0)
                 || (
                     (array_keys($value) === range(0, count($value) - 1))
@@ -186,7 +186,7 @@ 
             return '['.implode(', ', array_map([$this, 'phpEncodeValue'], $array)).']';
         }
 
-        return '['.implode(', ', array_map(function ($key) use ($array) {
+        return '['.implode(', ', array_map(function($key) use ($array) {
             return $this->phpEncodeValue($key).' => '.$this->phpEncodeValue($array[$key]);
         }, array_keys($array))).']';
     }

src/Codeception/Module/Doctrine2.php

Doc Comments +1 added lines, -1 removed lines

@@ -311,7 +311,7 @@
      *
      * @param $qb
      * @param $assoc
-     * @param $alias
+     * @param string $alias
      * @param $params
      */
     protected function buildAssociationQuery($qb, $assoc, $alias, $params)

Spacing +3 added lines, -3 removed lines

@@ -362,7 +362,7 @@ 
         $this->debug($qb->getDQL());
         $res = $qb->getQuery()->getArrayResult();
 
-        return ['True', (count($res) > 0), "$entity with " . json_encode($params)];
+        return ['True', (count($res) > 0), "$entity with ".json_encode($params)];
     }
 
     /**
@@ -390,7 +390,7 @@ 
         $this->em->flush();
         $data = $this->em->getClassMetadata($entity);
         $qb = $this->em->getRepository($entity)->createQueryBuilder('s');
-        $qb->select('s.' . $field);
+        $qb->select('s.'.$field);
         $this->buildAssociationQuery($qb, $entity, 's', $params);
         $this->debug($qb->getDQL());
         return $qb->getQuery()->getSingleScalarResult();
@@ -417,7 +417,7 @@ 
                                 $this->buildAssociationQuery($qb, $map['targetEntity'], $column, $v);
                                 continue;
                             }
-                            $paramname = "_$key" . '__' . $column;
+                            $paramname = "_$key".'__'.$column;
                             $qb->andWhere("_$key.$column = :$paramname");
                             $qb->setParameter($paramname, $v);
                         }

src/Codeception/Subscriber/BeforeAfterTest.php

Doc Comments +3 added lines

@@ -32,6 +32,9 @@
         $this->runHooks('afterClass');
     }
 
+    /**
+     * @param string $hookName
+     */
     protected function runHooks($hookName)
     {
         foreach ($this->hooks as $className => $hook) {

src/Codeception/Command/GenerateScenarios.php

Doc Comments +3 added lines

@@ -113,6 +113,9 @@
         }
     }
 
+    /**
+     * @param \Codeception\SuiteManager $suiteManager
+     */
     protected function getTests($suiteManager)
     {
         $suiteManager->loadTests();

Spacing +7 added lines, -7 removed lines

@@ -48,7 +48,7 @@ 
 
         $path = $input->getOption('path')
             ? $input->getOption('path')
-            : Configuration::dataDir() . 'scenarios';
+            : Configuration::dataDir().'scenarios';
 
         $format = $input->getOption('format');
 
@@ -60,7 +60,7 @@ 
             );
         }
 
-        $path = $path . DIRECTORY_SEPARATOR . $suite;
+        $path = $path.DIRECTORY_SEPARATOR.$suite;
         if (!$input->getOption('single-file')) {
             @mkdir($path);
         }
@@ -68,8 +68,8 @@ 
         $suiteManager = new \Codeception\SuiteManager(new EventDispatcher(), $suite, $suiteConf);
 
         if ($suiteConf['bootstrap']) {
-            if (file_exists($suiteConf['path'] . $suiteConf['bootstrap'])) {
-                require_once $suiteConf['path'] . $suiteConf['bootstrap'];
+            if (file_exists($suiteConf['path'].$suiteConf['bootstrap'])) {
+                require_once $suiteConf['path'].$suiteConf['bootstrap'];
             }
         }
 
@@ -86,7 +86,7 @@ 
 
             // create separate file for each test in Cest
             if ($test instanceof Cest && !$input->getOption('single-file')) {
-                $name .= '.' . $this->underscore($test->getTestMethod());
+                $name .= '.'.$this->underscore($test->getTestMethod());
             }
 
             if ($input->getOption('single-file')) {
@@ -94,13 +94,13 @@ 
                 $output->writeln("* $name rendered");
             } else {
                 $feature = $this->decorate($feature, $format);
-                $this->createFile($path . DIRECTORY_SEPARATOR . $name . $this->formatExtension($format), $feature, true);
+                $this->createFile($path.DIRECTORY_SEPARATOR.$name.$this->formatExtension($format), $feature, true);
                 $output->writeln("* $name generated");
             }
         }
 
         if ($input->getOption('single-file')) {
-            $this->createFile($path . $this->formatExtension($format), $this->decorate($scenarios, $format), true);
+            $this->createFile($path.$this->formatExtension($format), $this->decorate($scenarios, $format), true);
         }
     }
 

src/Codeception/Lib/Connector/Guzzle.php

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use GuzzleHttp\Post\PostFile;
 use Symfony\Component\BrowserKit\Client;
 use Symfony\Component\BrowserKit\Response as BrowserKitResponse;
-use GuzzleHttp\Url;
 use Symfony\Component\BrowserKit\Request as BrowserKitRequest;
 
 class Guzzle extends Client

Spacing +1 added lines, -1 removed lines

@@ -106,7 +106,7 @@
         if (strpos($contentType, 'charset=') === false) {
             $body = $response->getBody(true);
             if (preg_match('/\<meta[^\>]+charset *= *["\']?([a-zA-Z\-0-9]+)/i', $body, $matches)) {
-                $contentType .= ';charset=' . $matches[1];
+                $contentType .= ';charset='.$matches[1];
             }
             $response->setHeader('Content-Type', $contentType);
         }

Doc Comments +4 added lines, -1 removed lines

@@ -91,7 +91,7 @@ 
     /**
      * Taken from Mink\BrowserKitDriver
      *
-     * @param Response $response
+     * @param \Psr\Http\Message\ResponseInterface|null $response
      *
      * @return \Symfony\Component\BrowserKit\Response
      */
@@ -151,6 +151,9 @@ 
         return new BrowserKitResponse($response->getBody(), $status, $headers);
     }
 
+    /**
+     * @param string $uri
+     */
     public function getAbsoluteUri($uri)
     {
         $baseUri = $this->baseUri;

src/Codeception/Lib/Driver/Facebook.php

Doc Comments +13 added lines

@@ -85,6 +85,9 @@ 
         $this->executeFacebookRequest('DELETE', '/' . $testUserID);
     }
 
+    /**
+     * @param string $testUserAccessToken
+     */
     public function getTestUserInfo($testUserAccessToken)
     {
         $response = $this->executeFacebookRequest(
@@ -97,6 +100,9 @@ 
         return $response->getDecodedBody();
     }
 
+    /**
+     * @param string $testUserAccessToken
+     */
     public function getLastPostsForTestUser($testUserAccessToken)
     {
         $response = $this->executeFacebookRequest(
@@ -109,6 +115,10 @@ 
         return $response->getDecodedBody();
     }
 
+    /**
+     * @param string $placeId
+     * @param string $testUserAccessToken
+     */
     public function getVisitedPlaceTagForTestUser($placeId, $testUserAccessToken)
     {
         $response = $this->executeFacebookRequest(
@@ -121,6 +131,9 @@ 
         return $response->getDecodedBody();
     }
 
+    /**
+     * @param string $testUserAccessToken
+     */
     public function sendPostToFacebook($testUserAccessToken, array $parameters)
     {
         $response = $this->executeFacebookRequest(

Spacing +4 added lines, -4 removed lines

@@ -56,7 +56,7 @@ 
 
         $this->appId     = $config['app_id'];
         $this->appSecret = $config['secret'];
-        $this->appToken  = $this->appId . '|' . $this->appSecret;
+        $this->appToken  = $this->appId.'|'.$this->appSecret;
     }
 
     /**
@@ -69,7 +69,7 @@ 
     {
         $response = $this->executeFacebookRequest(
             'POST',
-            $this->appId . '/accounts/test-users',
+            $this->appId.'/accounts/test-users',
             [
                 'name'        => $name,
                 'installed'   => true,
@@ -82,7 +82,7 @@ 
 
     public function deleteTestUser($testUserID)
     {
-        $this->executeFacebookRequest('DELETE', '/' . $testUserID);
+        $this->executeFacebookRequest('DELETE', '/'.$testUserID);
     }
 
     public function getTestUserInfo($testUserAccessToken)
@@ -163,7 +163,7 @@ 
                 $response = $this->fb->delete($endpoint, $parameters, $token);
                 break;
             default:
-                throw new \Exception("Facebook driver exception, please add support for method: " . $method);
+                throw new \Exception("Facebook driver exception, please add support for method: ".$method);
                 break;
         }
 

src/Codeception/Lib/Generator/Actions.php

Doc Comments +1 added lines, -1 removed lines

@@ -149,7 +149,7 @@
 
     /**
      * @param \ReflectionMethod $refMethod
-     * @return array
+     * @return string
      */
     protected function getParamsString(\ReflectionMethod $refMethod)
     {

Spacing +6 added lines, -6 removed lines

@@ -82,7 +82,7 @@ 
         }
 
         return (new Template($this->template))
-            ->place('namespace', $namespace ? $namespace . '\\' : '')
+            ->place('namespace', $namespace ? $namespace.'\\' : '')
             ->place('hash', self::genHash($this->modules, $this->settings))
             ->place('name', $this->name)
             ->place('methods', implode("\n\n ", $code))
@@ -103,7 +103,7 @@ 
             $doc = "*";
         }
 
-        $conditionalDoc = $doc . "\n     * Conditional Assertion: Test won't be stopped on fail";
+        $conditionalDoc = $doc."\n     * Conditional Assertion: Test won't be stopped on fail";
 
         $methodTemplate = (new Template($this->methodTemplate))
             ->place('module', $module)
@@ -115,7 +115,7 @@ 
             $type = 'Assertion';
             $body .= $methodTemplate
                 ->place('doc', $conditionalDoc)
-                ->place('action', 'can' . ucfirst($refMethod->name))
+                ->place('action', 'can'.ucfirst($refMethod->name))
                 ->place('step', 'ConditionalAssertion')
                 ->produce();
 
@@ -151,9 +151,9 @@ 
         $params = [];
         foreach ($refMethod->getParameters() as $param) {
             if ($param->isOptional()) {
-                $params[] = '$' . $param->name . ' = null';
+                $params[] = '$'.$param->name.' = null';
             } else {
-                $params[] = '$' . $param->name;
+                $params[] = '$'.$param->name;
             };
         }
         return implode(', ', $params);
@@ -197,7 +197,7 @@ 
             $actions[$moduleName] = get_class_methods(get_class($module));
         }
 
-        return md5(Codecept::VERSION . serialize($actions) . serialize($settings['modules']));
+        return md5(Codecept::VERSION.serialize($actions).serialize($settings['modules']));
     }
 
     public function getNumMethods()

src/Codeception/Module/Laravel5.php

Doc Comments +4 added lines, -4 removed lines

@@ -114,7 +114,7 @@ 
     }
 
     /**
-     * @return array
+     * @return string[]
      */
     public function _parts()
     {
@@ -553,7 +553,7 @@ 
      * ?>
      * ```
      *
-     * @return bool
+     * @return boolean|null
      */
     public function seeFormHasErrors()
     {
@@ -572,7 +572,7 @@ 
      * ?>
      * ```
      *
-     * @return bool
+     * @return boolean|null
      */
     public function dontSeeFormErrors()
     {
@@ -953,7 +953,7 @@ 
      * Returns a list of recognized domain names.
      * This elements of this list are regular expressions.
      *
-     * @return array
+     * @return string[]
      */
     protected function getInternalDomains()
     {

Indentation -1 removed lines

@@ -402,7 +402,6 @@
      * $I->callArtisan('command:name', ['parameter' => 'value']);
      * ?>
      * ```
-
      * @param string $command
      * @param array $parameters
      */

Spacing +30 added lines, -30 removed lines

@@ -128,7 +128,7 @@ 
                 'run_database_seeder' => false,
                 'database_seeder_class' => '',
                 'environment_file' => '.env',
-                'bootstrap' => 'bootstrap' . DIRECTORY_SEPARATOR . 'app.php',
+                'bootstrap' => 'bootstrap'.DIRECTORY_SEPARATOR.'app.php',
                 'root' => '',
                 'packages' => 'workbench',
                 'vendor_dir' => 'vendor',
@@ -144,7 +144,7 @@ 
         $projectDir .= $this->config['root'];
 
         $this->config['project_dir'] = $projectDir;
-        $this->config['bootstrap_file'] = $projectDir . $this->config['bootstrap'];
+        $this->config['bootstrap_file'] = $projectDir.$this->config['bootstrap'];
 
         parent::__construct($container);
     }
@@ -226,7 +226,7 @@ 
      */
     private function applicationUsesDatabase()
     {
-        return ! empty($this->app['config']['database.default']);
+        return !empty($this->app['config']['database.default']);
     }
 
     /**
@@ -252,7 +252,7 @@ 
      */
     protected function registerAutoloaders()
     {
-        require $this->config['project_dir'] . $this->config['vendor_dir'] . DIRECTORY_SEPARATOR . 'autoload.php';
+        require $this->config['project_dir'].$this->config['vendor_dir'].DIRECTORY_SEPARATOR.'autoload.php';
     }
 
     /**
@@ -561,7 +561,7 @@ 
         $rootNamespace = $this->getRootControllerNamespace();
 
         if ($rootNamespace && !(strpos($action, '\\') === 0)) {
-            return $rootNamespace . '\\' . $action;
+            return $rootNamespace.'\\'.$action;
         }
 
         return trim($action, '\\');
@@ -604,11 +604,11 @@ 
             return;
         }
 
-        if (! $this->app['session']->has($key)) {
+        if (!$this->app['session']->has($key)) {
             $this->fail("No session variable with key '$key'");
         }
 
-        if (! is_null($value)) {
+        if (!is_null($value)) {
             $this->assertEquals($value, $this->app['session']->get($key));
         }
     }
@@ -671,7 +671,7 @@ 
     {
         $viewErrorBag = $this->app->make('view')->shared('errors');
         if (count($viewErrorBag) > 0) {
-            $this->fail("Found the following form errors: \n\n" . $viewErrorBag->toJson(JSON_PRETTY_PRINT));
+            $this->fail("Found the following form errors: \n\n".$viewErrorBag->toJson(JSON_PRETTY_PRINT));
         }
     }
 
@@ -723,7 +723,7 @@ 
             $this->fail("No form error message for key '$key'\n");
         }
 
-        if (! is_null($expectedErrorMessage)) {
+        if (!is_null($expectedErrorMessage)) {
             $this->assertContains($expectedErrorMessage, $viewErrorBag->first($key));
         }
     }
@@ -765,8 +765,8 @@ 
             return;
         }
 
-        if (! $guard->attempt($user)) {
-            $this->fail("Failed to login with credentials " . json_encode($user));
+        if (!$guard->attempt($user)) {
+            $this->fail("Failed to login with credentials ".json_encode($user));
         }
     }
 
@@ -791,7 +791,7 @@ 
             $auth = $auth->guard($guard);
         }
 
-        if (! $auth->check()) {
+        if (!$auth->check()) {
             $this->fail("There is no authenticated user");
         }
     }
@@ -864,7 +864,7 @@ 
         if (class_exists($table)) {
             $model = new $table;
 
-            if (! $model instanceof EloquentModel) {
+            if (!$model instanceof EloquentModel) {
                 throw new \RuntimeException("Class $table is not an Eloquent model");
             }
 
@@ -876,7 +876,7 @@ 
         try {
             return $this->app['db']->table($table)->insertGetId($attributes);
         } catch (\Exception $e) {
-            $this->fail("Could not insert record into table '$table':\n\n" . $e->getMessage());
+            $this->fail("Could not insert record into table '$table':\n\n".$e->getMessage());
         }
     }
 
@@ -898,10 +898,10 @@ 
     public function seeRecord($table, $attributes = [])
     {
         if (class_exists($table)) {
-            if (! $this->findModel($table, $attributes)) {
-                $this->fail("Could not find $table with " . json_encode($attributes));
+            if (!$this->findModel($table, $attributes)) {
+                $this->fail("Could not find $table with ".json_encode($attributes));
             }
-        } elseif (! $this->findRecord($table, $attributes)) {
+        } elseif (!$this->findRecord($table, $attributes)) {
             $this->fail("Could not find matching record in table '$table'");
         }
     }
@@ -925,7 +925,7 @@ 
     {
         if (class_exists($table)) {
             if ($this->findModel($table, $attributes)) {
-                $this->fail("Unexpectedly found matching $table with " . json_encode($attributes));
+                $this->fail("Unexpectedly found matching $table with ".json_encode($attributes));
             }
         } elseif ($this->findRecord($table, $attributes)) {
             $this->fail("Unexpectedly found matching record in table '$table'");
@@ -952,14 +952,14 @@ 
     public function grabRecord($table, $attributes = [])
     {
         if (class_exists($table)) {
-            if (! $model = $this->findModel($table, $attributes)) {
-                $this->fail("Could not find $table with " . json_encode($attributes));
+            if (!$model = $this->findModel($table, $attributes)) {
+                $this->fail("Could not find $table with ".json_encode($attributes));
             }
 
             return $model;
         }
 
-        if (! $record = $this->findRecord($table, $attributes)) {
+        if (!$record = $this->findRecord($table, $attributes)) {
             $this->fail("Could not find matching record in table '$table'");
         }
 
@@ -987,12 +987,12 @@ 
         if (class_exists($table)) {
             $currentNum = $this->countModels($table, $attributes);
             if ($currentNum != $expectedNum) {
-                $this->fail("The number of found $table ($currentNum) does not match expected number $expectedNum with " . json_encode($attributes));
+                $this->fail("The number of found $table ($currentNum) does not match expected number $expectedNum with ".json_encode($attributes));
             }
         } else {
             $currentNum = $this->countRecords($table, $attributes);
             if ($currentNum != $expectedNum) {
-                $this->fail("The number of found records ($currentNum) does not match expected number $expectedNum in table $table with " . json_encode($attributes));
+                $this->fail("The number of found records ($currentNum) does not match expected number $expectedNum in table $table with ".json_encode($attributes));
             }
         }
     }
@@ -1015,7 +1015,7 @@ 
      */
     public function grabNumRecords($table, $attributes = [])
     {
-        return class_exists($table)? $this->countModels($table, $attributes) : $this->countRecords($table, $attributes);
+        return class_exists($table) ? $this->countModels($table, $attributes) : $this->countRecords($table, $attributes);
     }
 
     /**
@@ -1046,7 +1046,7 @@ 
             $query->where($key, $value);
         }
 
-        return (array) $query->first();
+        return (array)$query->first();
     }
 
     /**
@@ -1136,7 +1136,7 @@ 
 
             return $result;
         } catch (\Exception $e) {
-            $this->fail("Could not create model: \n\n" . get_class($e) . "\n\n" . $e->getMessage());
+            $this->fail("Could not create model: \n\n".get_class($e)."\n\n".$e->getMessage());
         }
     }
 
@@ -1165,7 +1165,7 @@ 
         try {
             return $this->modelFactory($model, $name, $times)->create($attributes);
         } catch (\Exception $e) {
-            $this->fail("Could not create model: \n\n" . get_class($e) . "\n\n" . $e->getMessage());
+            $this->fail("Could not create model: \n\n".get_class($e)."\n\n".$e->getMessage());
         }
     }
 
@@ -1178,8 +1178,8 @@ 
      */
     protected function modelFactory($model, $name, $times = 1)
     {
-        if (! function_exists('factory')) {
-            throw new ModuleException($this, 'The factory() method does not exist. ' .
+        if (!function_exists('factory')) {
+            throw new ModuleException($this, 'The factory() method does not exist. '.
                 'This functionality relies on Laravel model factories, which were introduced in Laravel 5.1.');
         }
 
@@ -1213,7 +1213,7 @@ 
         $server = ReflectionHelper::readPrivateProperty($this->client, 'server');
         $domain = $server['HTTP_HOST'];
 
-        return '/^' . str_replace('.', '\.', $domain) . '$/';
+        return '/^'.str_replace('.', '\.', $domain).'$/';
     }
 
     /**

src/Codeception/Module/PhpBrowser.php

Doc Comments +1 added lines, -1 removed lines

@@ -236,7 +236,7 @@
      * It is not recommended to use this command on a regular basis.
      * If Codeception lacks important Guzzle Client methods, implement them and submit patches.
      *
-     * @param callable $function
+     * @param \Closure $function
      */
     public function executeInGuzzle(\Closure $function)
     {