Passed
Push — master ( 99159c...091505 )
by zyt
05:08
created
src/GoogleFontsOptimizerUtils.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
             }
125 125
 
126 126
             // Store back
127
-            $data[$key] = $parts;
127
+            $data[ $key ] = $parts;
128 128
         }
129 129
 
130 130
         return $data;
@@ -160,16 +160,16 @@  discard block
 block discarded – undo
160 160
      */
161 161
     public static function buildFontsMarkupScript(Collection $collection)
162 162
     {
163
-        $families_array = [];
163
+        $families_array = [ ];
164 164
 
165 165
         list($names, $mapping) = $collection->getScriptData();
166 166
 
167 167
         foreach ($names as $name => $sizes) {
168 168
             $family = $name . ':' . implode(',', $sizes);
169
-            if (isset($mapping[$name])) {
170
-                $family .= ':' . implode(',', $mapping[$name]);
169
+            if (isset($mapping[ $name ])) {
170
+                $family .= ':' . implode(',', $mapping[ $name ]);
171 171
             }
172
-            $families_array[] = $family;
172
+            $families_array[ ] = $family;
173 173
         }
174 174
         $families = "'" . implode("', '", $families_array) . "'";
175 175
 
@@ -233,28 +233,28 @@  discard block
 block discarded – undo
233 233
      *
234 234
      * @return null|string
235 235
      */
236
-    public static function buildGoogleFontsUrl(array $fonts, $subsets = [])
236
+    public static function buildGoogleFontsUrl(array $fonts, $subsets = [ ])
237 237
     {
238 238
         $base_url  = 'https://fonts.googleapis.com/css';
239
-        $font_args = [];
240
-        $family    = [];
239
+        $font_args = [ ];
240
+        $family    = [ ];
241 241
 
242 242
         foreach ($fonts as $font_name => $font_weight) {
243 243
             if (is_array($font_weight)) {
244 244
                 $font_weight = implode(',', $font_weight);
245 245
             }
246 246
             // Trimming end colon handles edge case of being given an empty $font_weight
247
-            $family[] = trim(trim($font_name) . ':' . trim($font_weight), ':');
247
+            $family[ ] = trim(trim($font_name) . ':' . trim($font_weight), ':');
248 248
         }
249 249
 
250
-        $font_args['family'] = implode('|', $family);
250
+        $font_args[ 'family' ] = implode('|', $family);
251 251
 
252
-        if (! empty($subsets)) {
252
+        if (!empty($subsets)) {
253 253
             if (is_array($subsets)) {
254 254
                 $subsets = array_unique($subsets);
255 255
                 $subsets = implode(',', $subsets);
256 256
             }
257
-            $font_args['subset'] = trim($subsets);
257
+            $font_args[ 'subset' ] = trim($subsets);
258 258
         }
259 259
 
260 260
         $url = $base_url . '?' . http_build_query($font_args);
@@ -271,15 +271,15 @@  discard block
 block discarded – undo
271 271
      */
272 272
     public static function arrayFlattenIterative(array $arr)
273 273
     {
274
-        $flat  = [];
274
+        $flat  = [ ];
275 275
         $stack = array_values($arr);
276 276
 
277
-        while (! empty($stack)) {
277
+        while (!empty($stack)) {
278 278
             $value = array_shift($stack);
279 279
             if (is_array($value)) {
280 280
                 $stack = array_merge(array_values($value), $stack);
281 281
             } else {
282
-                $flat[] = $value;
282
+                $flat[ ] = $value;
283 283
             }
284 284
         }
285 285
 
Please login to merge, or discard this patch.
src/GoogleFontsCollection.php 1 patch
Spacing   +46 added lines, -46 removed lines patch added patch discarded remove patch
@@ -7,21 +7,21 @@  discard block
 block discarded – undo
7 7
 class GoogleFontsCollection
8 8
 {
9 9
 
10
-    protected $links = [];
10
+    protected $links = [ ];
11 11
 
12
-    protected $texts = [];
12
+    protected $texts = [ ];
13 13
 
14
-    protected $complete = [];
14
+    protected $complete = [ ];
15 15
 
16
-    protected $fonts = [];
16
+    protected $fonts = [ ];
17 17
 
18
-    protected $subsetsMap = [];
18
+    protected $subsetsMap = [ ];
19 19
 
20
-    protected $namedSizes = [];
20
+    protected $namedSizes = [ ];
21 21
 
22
-    public function __construct(array $urls = [])
22
+    public function __construct(array $urls = [ ])
23 23
     {
24
-        if (! empty($urls)) {
24
+        if (!empty($urls)) {
25 25
             foreach ($urls as $url) {
26 26
                 $this->add($url);
27 27
             }
@@ -32,17 +32,17 @@  discard block
 block discarded – undo
32 32
     {
33 33
         $this->addLink($url);
34 34
 
35
-        $params = [];
35
+        $params = [ ];
36 36
         parse_str(parse_url($url, PHP_URL_QUERY), $params);
37 37
 
38
-        $bucket = isset($params['text']) ? 'text' : 'complete';
38
+        $bucket = isset($params[ 'text' ]) ? 'text' : 'complete';
39 39
 
40 40
         $fontstrings = $this->buildFontStringsFromQueryParams($params);
41 41
         foreach ($fontstrings as $font) {
42 42
             $this->addFontFromString($font, $bucket);
43 43
             if ('text' === $bucket) {
44 44
                 $font_family = explode(':', $font);
45
-                $this->addTextFont($font_family[0], Utils::httpsify($url));
45
+                $this->addTextFont($font_family[ 0 ], Utils::httpsify($url));
46 46
             } else {
47 47
                 $this->addComplete($font);
48 48
             }
@@ -69,19 +69,19 @@  discard block
 block discarded – undo
69 69
         $subsets = $font->getSubsetsString();
70 70
 
71 71
         // Add to bucket list
72
-        $this->fonts[$bucket][] = $font;
72
+        $this->fonts[ $bucket ][ ] = $font;
73 73
 
74 74
         // Keeping a separate map of names => subsets for webfontloader purposes
75
-        if (! array_key_exists($name, $this->subsetsMap)) {
75
+        if (!array_key_exists($name, $this->subsetsMap)) {
76 76
             // Nothing found yet, create a new key
77
-            $this->subsetsMap[$name] = $subsets;
77
+            $this->subsetsMap[ $name ] = $subsets;
78 78
         } else {
79 79
             // Something is in there already, append to that.
80 80
             // Existing subsetsMap[$name] might not be an array
81
-            if (! is_array($this->subsetsMap[$name])) {
82
-                $this->subsetsMap[$name] = (array) $this->subsetsMap[$name];
81
+            if (!is_array($this->subsetsMap[ $name ])) {
82
+                $this->subsetsMap[ $name ] = (array) $this->subsetsMap[ $name ];
83 83
             }
84
-            $this->subsetsMap[$name] = array_merge($this->subsetsMap[$name], (array) $subsets);
84
+            $this->subsetsMap[ $name ] = array_merge($this->subsetsMap[ $name ], (array) $subsets);
85 85
         }
86 86
 
87 87
         // Deduplicate values and don't sort the subsets map
@@ -101,18 +101,18 @@  discard block
 block discarded – undo
101 101
 
102 102
     protected function addTextFont($name, $url)
103 103
     {
104
-        $this->texts['name'][] = $name;
105
-        $this->texts['url'][]  = $url;
104
+        $this->texts[ 'name' ][ ] = $name;
105
+        $this->texts[ 'url' ][ ]  = $url;
106 106
     }
107 107
 
108 108
     protected function addComplete($fontstring)
109 109
     {
110
-        $this->complete[] = $fontstring;
110
+        $this->complete[ ] = $fontstring;
111 111
     }
112 112
 
113 113
     protected function addLink($url)
114 114
     {
115
-        $this->links[] = $url;
115
+        $this->links[ ] = $url;
116 116
     }
117 117
 
118 118
     public function getOriginalLinks()
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
 
123 123
     public function hasText()
124 124
     {
125
-        return (! empty($this->texts));
125
+        return (!empty($this->texts));
126 126
     }
127 127
 
128 128
     /**
@@ -130,10 +130,10 @@  discard block
 block discarded – undo
130 130
      */
131 131
     public function getTextUrls()
132 132
     {
133
-        $urls = [];
133
+        $urls = [ ];
134 134
 
135 135
         if ($this->hasText()) {
136
-            $urls = $this->texts['url'];
136
+            $urls = $this->texts[ 'url' ];
137 137
         }
138 138
 
139 139
         return $urls;
@@ -144,17 +144,17 @@  discard block
 block discarded – undo
144 144
      */
145 145
     public function getTextNames()
146 146
     {
147
-        return $this->texts['name'];
147
+        return $this->texts[ 'name' ];
148 148
     }
149 149
 
150 150
     public function getFonts()
151 151
     {
152
-        return $this->fonts['complete'];
152
+        return $this->fonts[ 'complete' ];
153 153
     }
154 154
 
155 155
     public function getFontsText()
156 156
     {
157
-        return $this->fonts['text'];
157
+        return $this->fonts[ 'text' ];
158 158
     }
159 159
 
160 160
     public function getCombinedUrl()
@@ -169,11 +169,11 @@  discard block
 block discarded – undo
169 169
 
170 170
     public function getSubsets()
171 171
     {
172
-        $subsets = [];
172
+        $subsets = [ ];
173 173
 
174 174
         $fonts = $this->getFonts();
175 175
         foreach ($fonts as $font) {
176
-            $subsets[] = $font->getSubsets();
176
+            $subsets[ ] = $font->getSubsets();
177 177
         }
178 178
 
179 179
         $subsets = Utils::arrayFlattenIterative($subsets);
@@ -186,14 +186,14 @@  discard block
 block discarded – undo
186 186
      */
187 187
     protected function buildNamedsizesMap()
188 188
     {
189
-        $fonts = [];
189
+        $fonts = [ ];
190 190
 
191 191
         foreach ($this->getFonts() as $font) {
192 192
             $name = $font->getName();
193
-            if (! array_key_exists($name, $fonts)) {
194
-                $fonts[$name] = $font->getSizes();
193
+            if (!array_key_exists($name, $fonts)) {
194
+                $fonts[ $name ] = $font->getSizes();
195 195
             } else {
196
-                $fonts[$name] = array_merge($fonts[$name], $font->getSizes());
196
+                $fonts[ $name ] = array_merge($fonts[ $name ], $font->getSizes());
197 197
             }
198 198
         }
199 199
 
@@ -217,12 +217,12 @@  discard block
 block discarded – undo
217 217
      */
218 218
     protected function buildFontStringsFromQueryParams(array $params)
219 219
     {
220
-        $fonts = [];
220
+        $fonts = [ ];
221 221
 
222
-        foreach (explode('|', $params['family']) as $family) {
222
+        foreach (explode('|', $params[ 'family' ]) as $family) {
223 223
             $font = $this->parseFontStringName($family, $params);
224
-            if (! empty($font)) {
225
-                $fonts[] = $font;
224
+            if (!empty($font)) {
225
+                $fonts[ ] = $font;
226 226
             }
227 227
         }
228 228
 
@@ -240,12 +240,12 @@  discard block
 block discarded – undo
240 240
         $subset = false;
241 241
         $family = explode(':', $family);
242 242
 
243
-        if (isset($params['subset'])) {
243
+        if (isset($params[ 'subset' ])) {
244 244
             // Use the found subset query parameter
245
-            $subset = $params['subset'];
246
-        } elseif (isset($family[2])) {
245
+            $subset = $params[ 'subset' ];
246
+        } elseif (isset($family[ 2 ])) {
247 247
             // Use the subset in the family string if present
248
-            $subset = $family[2];
248
+            $subset = $family[ 2 ];
249 249
         }
250 250
 
251 251
         // $family can have a lot of thing specified with separators etc.
@@ -265,19 +265,19 @@  discard block
 block discarded – undo
265 265
      */
266 266
     protected function validateFontStringParts(array $family, $subset = false)
267 267
     {
268
-        $parts = [];
268
+        $parts = [ ];
269 269
 
270 270
         // First part is the font name, which should always be present
271
-        $parts[] = $family[0];
271
+        $parts[ ] = $family[ 0 ];
272 272
 
273 273
         // Check if sizes are specified
274
-        if (isset($family[1]) && strlen($family[1]) > 0) {
275
-            $parts[] = $family[1];
274
+        if (isset($family[ 1 ]) && strlen($family[ 1 ]) > 0) {
275
+            $parts[ ] = $family[ 1 ];
276 276
         }
277 277
 
278 278
         // Add the subset if specified
279 279
         if ($subset) {
280
-            $parts[] = $subset;
280
+            $parts[ ] = $subset;
281 281
         }
282 282
 
283 283
         return $parts;
Please login to merge, or discard this patch.