Zing\QueryBuilder\Filters\BetweenFilter::withPropertyConstraint()

Complexity

Conditions	3
Paths	2

Size

Total Lines	7
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	3

Importance

Changes

0

<?php
    protected function withPropertyConstraint(Builder $query, $value, $property): Builder
    {
        if (! is_array($value) || count($value) !== 2) {
            throw ParameterException::tooFewElementsForBetweenExpression();
        }

        return $query->whereBetween($property, $value);

The expression return $query->whereBetween($property, $value) could return the type Illuminate\Database\Query\Builder which is incompatible with the type-hinted return Illuminate\Database\Eloquent\Builder. Consider adding an additional type-check to rule them out.

    }