Zing\QueryBuilder\Filters\BetweenFilter

Complexity

Total Complexity

3

Size/Duplication

Total Lines	13
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	withPropertyConstraint()	0	7	3

<?php

declare(strict_types=1);

namespace Zing\QueryBuilder\Filters;

use Illuminate\Database\Eloquent\Builder;
use Zing\QueryBuilder\Exceptions\ParameterException;

class BetweenFilter extends ExactFilter
{
    /**
     * @param mixed $value
     * @param \Illuminate\Database\Query\Expression|string $property
     */
    protected function withPropertyConstraint(Builder $query, $value, $property): Builder
    {
        if (! is_array($value) || count($value) !== 2) {
            throw ParameterException::tooFewElementsForBetweenExpression();
        }

        return $query->whereBetween($property, $value);

The expression return $query->whereBetween($property, $value) could return the type Illuminate\Database\Query\Builder which is incompatible with the type-hinted return Illuminate\Database\Eloquent\Builder. Consider adding an additional type-check to rule them out.

    }
}