zicht / itertools

src/Zicht/Itertools/lib/SliceIterator.php

Doc Comments +4 added lines

@@ -60,6 +60,10 @@
     private $start;
     private $end;
 
+    /**
+     * @param integer $start
+     * @param integer $end
+     */
     public function __construct(\Iterator $iterable, $start, $end = null)
     {
         if ($start < 0 || $end < 0) {

Spacing +1 added lines, -1 removed lines

@@ -67,7 +67,7 @@
         }
 
         $this->index = 0;
-        $this->start = $start < 0 ? $length + $start: $start;
+        $this->start = $start < 0 ? $length + $start : $start;
         $this->end = $end === null ? null : ($end < 0 ? $length + $end : $end);
         parent::__construct($iterable);
     }

src/Zicht/Itertools/lib/Traits/ChainTrait.php

Doc Comments -2 removed lines

@@ -26,8 +26,6 @@
      * > iter\iterable('ABC', 'DEF')->chain()
      * A B C D E F
      *
-     * @param array|string|\Iterator $iterable
-     * @param array|string|\Iterator $iterable2
      * @return iter\lib\ChainIterator
      */
     public function chain(/* $iterable, $iterable2, ... */)

src/Zicht/Itertools/lib/Traits/MapTrait.php

Doc Comments -1 removed lines

@@ -34,7 +34,6 @@
      * 2.5 3.5 4.5
      *
      * @param null|string|\Closure $strategy
-     * @param array|string|\Iterator $iterable2
      * @return iter\lib\MapIterator
      */
     public function map($strategy /*, $iterable2, ... */)

src/Zicht/Itertools/lib/Traits/ReduceTrait.php

Doc Comments -1 removed lines

@@ -25,7 +25,6 @@
      * > iter\iterable([])->reduce('min', 1)
      * 1
      *
-     * @param array|string|\Iterator $iterable
      * @param string|\Closure $closure
      * @param mixed $initializer
      * @return mixed

src/Zicht/Itertools/lib/Traits/ZipTrait.php

Doc Comments -1 removed lines

@@ -22,7 +22,6 @@
      * > zip([1, 2, 3], ['a', 'b', 'c'])
      * [1, 'a'] [2, 'b'] [3, 'c']
      *
-     * @param array|string|\Iterator $iterable2
      * @return iter\lib\ZipIterator
      */
     public function zip(/* $iterable2, ... */)

src/Zicht/Itertools/lib/SortedIterator.php

Spacing +3 added lines, -3 removed lines

@@ -57,13 +57,13 @@ 
     public function __construct(\Closure $func, \Iterator $iterable, $reverse = false)
     {
         if ($reverse) {
-            $cmp = function ($a, $b) use ($func) {
+            $cmp = function($a, $b) use ($func) {
                 $orderA = $a['order'];
                 $orderB = $b['order'];
                 return $orderA == $orderB ? 0 : ($orderA < $orderB ? 1 : -1);
             };
         } else {
-            $cmp = function ($a, $b) use ($func) {
+            $cmp = function($a, $b) use ($func) {
                 $orderA = $a['order'];
                 $orderB = $b['order'];
                 return $orderA == $orderB ? 0 : ($orderA < $orderB ? -1 : 1);
@@ -72,7 +72,7 @@ 
 
         $data = [];
         foreach ($iterable as $key => $value) {
-            $data []= array('key' => $key, 'value' => $value, 'order' => call_user_func($func, $value, $key));
+            $data [] = array('key' => $key, 'value' => $value, 'order' => call_user_func($func, $value, $key));
         }
 
         $this->mergesort($data, $cmp);

Braces +10 added lines, -6 removed lines

@@ -114,8 +114,9 @@ 
     protected function mergesort(array &$array, \Closure $cmp_function)
     {
         // Arrays of size < 2 require no action.
-        if (count($array) < 2)
-            return;
+        if (count($array) < 2) {
+                    return;
+        }
 
         // Split the array in half
         $halfway = count($array) / 2;
@@ -138,15 +139,18 @@ 
         while ($ptr1 < count($array1) && $ptr2 < count($array2)) {
             if (call_user_func($cmp_function, $array1[$ptr1], $array2[$ptr2]) < 1) {
                 $array[] = $array1[$ptr1++];
-            }
-            else {
+            } else {
                 $array[] = $array2[$ptr2++];
             }
         }
 
         // Merge the remainder
-        while ($ptr1 < count($array1)) $array[] = $array1[$ptr1++];
-        while ($ptr2 < count($array2)) $array[] = $array2[$ptr2++];
+        while ($ptr1 < count($array1)) {
+            $array[] = $array1[$ptr1++];
+        }
+        while ($ptr2 < count($array2)) {
+            $array[] = $array2[$ptr2++];
+        }
         return;
     }
 }

src/Zicht/Itertools/lib/GroupbyIterator.php

Spacing +1 added lines, -1 removed lines

@@ -160,7 +160,7 @@
         $array = iterator_to_array($this);
         array_walk(
             $array,
-            function (&$value) {
+            function(&$value) {
                 /** @var GroupedIterator $value */
                 $value = $value->toArray();
             }

src/Zicht/Itertools/util/Mappings.php

Spacing +4 added lines, -4 removed lines

@@ -16,7 +16,7 @@ 
      */
     public static function lstrip($chars = " \t\n\r\0\x0B")
     {
-        return function ($value) use ($chars) {
+        return function($value) use ($chars) {
             return ltrim($value, $chars);
         };
     }
@@ -26,7 +26,7 @@ 
      */
     public static function rstrip($chars = " \t\n\r\0\x0B")
     {
-        return function ($value) use ($chars) {
+        return function($value) use ($chars) {
             return rtrim($value, $chars);
         };
     }
@@ -36,7 +36,7 @@ 
      */
     public static function strip($chars = " \t\n\r\0\x0B")
     {
-        return function ($value) use ($chars) {
+        return function($value) use ($chars) {
             return trim($value, $chars);
         };
     }
@@ -46,7 +46,7 @@ 
      */
     public static function length()
     {
-        return function ($value) {
+        return function($value) {
             return sizeof($value);
         };
     }

src/Zicht/Itertools/reductions.php

Spacing +7 added lines, -7 removed lines

@@ -15,7 +15,7 @@ 
  */
 function add()
 {
-    return function ($a, $b) {
+    return function($a, $b) {
         if (!is_numeric($a)) {
             throw new \InvalidArgumentException('Argument $A must be numeric to perform addition');
         }
@@ -33,7 +33,7 @@ 
  */
 function sub()
 {
-    return function ($a, $b) {
+    return function($a, $b) {
         if (!is_numeric($a)) {
             throw new \InvalidArgumentException('Argument $A must be numeric to perform subtraction');
         }
@@ -51,7 +51,7 @@ 
  */
 function mul()
 {
-    return function ($a, $b) {
+    return function($a, $b) {
         if (!is_numeric($a)) {
             throw new \InvalidArgumentException('Argument $A must be numeric to perform multiplication');
         }
@@ -69,7 +69,7 @@ 
  */
 function min()
 {
-    return function ($a, $b) {
+    return function($a, $b) {
         if (!is_numeric($a)) {
             throw new \InvalidArgumentException('Argument $A must be numeric to determine minimum');
         }
@@ -87,7 +87,7 @@ 
  */
 function max()
 {
-    return function ($a, $b) {
+    return function($a, $b) {
         if (!is_numeric($a)) {
             throw new \InvalidArgumentException('Argument $A must be numeric to determine maximum');
         }
@@ -109,7 +109,7 @@ 
     if (!is_string($glue)) {
         throw new \InvalidArgumentException('Argument $GLUE must be a string to join');
     }
-    return function ($a, $b) use ($glue) {
+    return function($a, $b) use ($glue) {
         if (!is_string($a)) {
             throw new \InvalidArgumentException('Argument $A must be a string to join');
         }
@@ -131,7 +131,7 @@ 
  */
 function chain()
 {
-    return function ($chainIterator, $b) {
+    return function($chainIterator, $b) {
         if (!($chainIterator instanceof ChainIterator)) {
             throw new \InvalidArgumentException('Argument $A must be a ChainIterator.  Did your call "reduce" with "new ChainIterator()" as the initial parameter?');
         }

Doc Comments +1 added lines

@@ -176,6 +176,7 @@
 
 /**
  * @deprecated please use the reduction functions directly, will be removed in version 3.0
+ * @param string $name
  */
 function getReduction($name)
 {