CollapseIterator::__construct() - Code Metrics - Inspection of "[OPERA-343] Added collapse iterator" - zicht/itertools - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Pull Request — master (#49)

unknown

created 2019-04-29 11:42 UTC

CollapseIterator::__construct() A

↳ Parent: CollapseIterator

Complexity

Conditions	5
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	5
nc	4
nop	1
dl	0
loc	12
rs	9.5555
c	0
b	0
f	0

<?php
/**
 * @copyright Zicht Online <http://zicht.nl>
 */

namespace Zicht\Itertools\lib;

use Zicht\Itertools\lib\Interfaces\FiniteIterableInterface;
use Zicht\Itertools\lib\Traits\FiniteIterableTrait;

class CollapseIterator extends \IteratorIterator implements FiniteIterableInterface
{
    use FiniteIterableTrait;

    /**
     * @param \Iterator $iterable
     */
    public function __construct(\Iterator $iterable)
    {
        $data = [];
        foreach ($iterable as $subIterable) {
            if (is_array($subIterable) || $subIterable instanceof \Traversable) {
                foreach ($subIterable as $key => $value) {
                    $data [] = [$key, $value];
                }
            }
        }
        parent::__construct(new \ArrayIterator($data));
    }

    /**
     * {@inheritdoc}
     */
    public function key()
    {
        list($key, $value) = parent::current();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        return $key;
    }

    /**
     * {@inheritdoc}
     */
    public function current()
    {
        list($key, $value) = parent::current();
<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;
        return $value;
    }
}


1			<?php
2			/**
3			* @copyright Zicht Online <http://zicht.nl>
4			*/
5
6			namespace Zicht\Itertools\lib;
7
8			use Zicht\Itertools\lib\Interfaces\FiniteIterableInterface;
9			use Zicht\Itertools\lib\Traits\FiniteIterableTrait;
10
11			class CollapseIterator extends \IteratorIterator implements FiniteIterableInterface
12			{
13			use FiniteIterableTrait;
14
15			/**
16			* @param \Iterator $iterable
17			*/
18			public function __construct(\Iterator $iterable)
19			{
20			$data = [];
21			foreach ($iterable as $subIterable) {
22			if (is_array($subIterable) \|\| $subIterable instanceof \Traversable) {
23			foreach ($subIterable as $key => $value) {
24			$data [] = [$key, $value];
25			}
26			}
27			}
28			parent::__construct(new \ArrayIterator($data));
29			}
30
31			/**
32			* {@inheritdoc}
33			*/
34			public function key()
35			{
36			list($key, $value) = parent::current();
			0 ignored issues – show Comprehensibility Bug introduced 2019-04-29 11:49 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`current()` instead of `key()`). Are you sure this is correct? If so, you might want to change this to `$this->current()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history... Unused Code introduced 2019-04-29 11:49 UTC by Report Bug Copy Issue Report The assignment to `$value` is unused. Consider omitting it like so `list($first,,$third)`. This checks looks for assignemnts to variables using the `list(...)` function, where not all assigned variables are subsequently used. Consider the following code example. <?php function returnThreeValues() { return array('a', 'b', 'c'); } list($a, $b, $c) = returnThreeValues(); print $a . " - " . $c; Only the variables `$a` and `$c` are used. There was no need to assign `$b`. Instead, the list call could have been. list($a,, $c) = returnThreeValues(); Loading history...
37			return $key;
38			}
39
40			/**
41			* {@inheritdoc}
42			*/
43			public function current()
44			{
45			list($key, $value) = parent::current();
			0 ignored issues – show Unused Code introduced 2019-04-29 11:49 UTC by Report Bug Copy Issue Report The assignment to `$key` is unused. Consider omitting it like so `list($first,,$third)`. This checks looks for assignemnts to variables using the `list(...)` function, where not all assigned variables are subsequently used. Consider the following code example. <?php function returnThreeValues() { return array('a', 'b', 'c'); } list($a, $b, $c) = returnThreeValues(); print $a . " - " . $c; Only the variables `$a` and `$c` are used. There was no need to assign `$b`. Instead, the list call could have been. list($a,, $c) = returnThreeValues(); Loading history...
46			return $value;
47			}
48			}
49

zicht / itertools

Pull Request — master (#49)

CollapseIterator::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like