Zicht\Itertools\lib\CollapseIterator

Complexity

Total Complexity

7

Size/Duplication

Total Lines	38
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	12	5
A	key()	0	5	1
A	current()	0	5	1

<?php
/**
 * @copyright Zicht Online <http://zicht.nl>
 */

namespace Zicht\Itertools\lib;

use Zicht\Itertools\lib\Interfaces\FiniteIterableInterface;
use Zicht\Itertools\lib\Traits\FiniteIterableTrait;

class CollapseIterator extends \IteratorIterator implements FiniteIterableInterface
{
    use FiniteIterableTrait;

    /**
     * @param \Iterator $iterable
     */
    public function __construct(\Iterator $iterable)
    {
        $data = [];
        foreach ($iterable as $subIterable) {
            if (is_array($subIterable) || $subIterable instanceof \Traversable) {
                foreach ($subIterable as $key => $value) {
                    $data [] = [$key, $value];
                }
            }
        }
        parent::__construct(new \ArrayIterator($data));
    }

    /**
     * {@inheritdoc}
     */
    public function key()
    {
        list($key, $value) = parent::current();

It seems like you call parent on a different method (current() instead of key()). Are you sure this is correct? If so, you might want to change this to $this->current().

The assignment to $value is unused. Consider omitting it like so list($first,,$third).

        return $key;
    }

    /**
     * {@inheritdoc}
     */
    public function current()
    {
        list($key, $value) = parent::current();

The assignment to $key is unused. Consider omitting it like so list($first,,$third).

        return $value;
    }
}