Completed
Pull Request — master (#80)
by
unknown
08:10
created
Zewa/SessionHandler.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -162,6 +162,9 @@
 block discarded – undo
162 162
 
163 163
     }
164 164
 
165
+    /**
166
+     * @param string $sessionId
167
+     */
165 168
     public function destroy($sessionId)
166 169
     {
167 170
         $success = false;
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
         ini_set('session.cookie_domain', $domain);
33 33
 
34 34
         if ($session_lifetime != '' && is_integer($session_lifetime)) {
35
-            ini_set('session.gc_maxlifetime', (int) $session_lifetime);
35
+            ini_set('session.gc_maxlifetime', (int)$session_lifetime);
36 36
         }
37 37
 
38 38
         if ($gc_probability != '' && is_integer($gc_probability)) {
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
 
79 79
         if ($interface !== 'file') {
80 80
             try {
81
-                $database = new Database();//App::getService('database')->fetchConnection();
81
+                $database = new Database(); //App::getService('database')->fetchConnection();
82 82
                 $this->dbh = $database->fetchConnection('default');
83 83
 
84 84
                 session_set_save_handler(
@@ -165,7 +165,7 @@  discard block
 block discarded – undo
165 165
     public function destroy($sessionId)
166 166
     {
167 167
         $success = false;
168
-        $query = "DELETE FROM ". $this->tableName
168
+        $query = "DELETE FROM " . $this->tableName
169 169
             . " WHERE id = ?";
170 170
 
171 171
         $success = $this->dbh->prepare($query)
@@ -181,7 +181,7 @@  discard block
 block discarded – undo
181 181
     public function gc()
182 182
     {
183 183
 
184
-        $query = "DELETE FROM ". $this->tableName
184
+        $query = "DELETE FROM " . $this->tableName
185 185
             . " WHERE session_expire < ?";
186 186
 
187 187
         return $this->dbh->prepare($query)
Please login to merge, or discard this patch.
Zewa/Router.php 3 patches
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -335,10 +335,10 @@  discard block
 block discarded – undo
335 335
     {
336 336
         if (trim($_SERVER['REQUEST_URI']) === '/') {
337 337
             $url = $this->baseURL()
338
-                   . (!empty($_SERVER['QUERY_STRING']) ? '?' . $_SERVER['QUERY_STRING'] : '');
338
+                    . (!empty($_SERVER['QUERY_STRING']) ? '?' . $_SERVER['QUERY_STRING'] : '');
339 339
         } else {
340 340
             $url = $this->baseURL($this->uri)
341
-                   . (!empty($_SERVER['QUERY_STRING']) ? '?' . $_SERVER['QUERY_STRING'] : '');
341
+                    . (!empty($_SERVER['QUERY_STRING']) ? '?' . $_SERVER['QUERY_STRING'] : '');
342 342
         }
343 343
 
344 344
         if (!empty($params)) {
@@ -362,7 +362,7 @@  discard block
 block discarded – undo
362 362
         if (is_null($this->baseURL)) {
363 363
             $self = $_SERVER['PHP_SELF'];
364 364
             $server = $_SERVER['HTTP_HOST']
365
-                      . rtrim(str_replace(strstr($self, 'index.php'), '', $self), '/');
365
+                        . rtrim(str_replace(strstr($self, 'index.php'), '', $self), '/');
366 366
 
367 367
             if ((!empty($_SERVER['HTTPS']) && $_SERVER['HTTPS'] != 'off')
368 368
                 || !empty($_SERVER['HTTP_X_FORWARDED_PROTO'])
Please login to merge, or discard this patch.
Doc Comments   +22 added lines, -1 removed lines patch added patch discarded remove patch
@@ -129,11 +129,18 @@  discard block
 block discarded – undo
129 129
     }
130 130
 
131 131
 
132
+    /**
133
+     * @param string $uri
134
+     */
132 135
     private function isURIClean($uri, $uriChunks)
133 136
     {
134 137
         if (!preg_match("/^[a-z0-9:_\/\.\[\]-]+$/i", $uri)
135 138
             || array_filter(
136 139
                 $uriChunks,
140
+
141
+                /**
142
+                 * @param string $uriChunk
143
+                 */
137 144
                 function ($uriChunk) {
138 145
                     if (strpos($uriChunk, '__') !== false) {
139 146
                         return true;
@@ -148,6 +155,10 @@  discard block
 block discarded – undo
148 155
     }
149 156
 
150 157
     //@TODO add Security class.
158
+
159
+    /**
160
+     * @param string $data
161
+     */
151 162
     private function normalize($data)
152 163
     {
153 164
         if (is_numeric($data)) {
@@ -225,6 +236,9 @@  discard block
 block discarded – undo
225 236
         return $normalizedURI;
226 237
     }
227 238
 
239
+    /**
240
+     * @param string $uri
241
+     */
228 242
     private function discoverRoute($uri)
229 243
     {
230 244
         $routes = $this->configuration->routes;
@@ -259,6 +273,7 @@  discard block
 block discarded – undo
259 273
      * Normalize the $_SERVER vars for formatting the URI.
260 274
      *
261 275
      * @access public
276
+     * @param string $uri
262 277
      * @return string formatted/u/r/l
263 278
      */
264 279
     private function uri($uri)
@@ -312,6 +327,9 @@  discard block
 block discarded – undo
312 327
         return array_merge($return, array_values($uriChunks));
313 328
     }
314 329
 
330
+    /**
331
+     * @param string $url
332
+     */
315 333
     private function addQueryString($url, $key, $value)
316 334
     {
317 335
         $url = preg_replace('/(.*)(\?|&)' . $key . '=[^&]+?(&)(.*)/i', '$1$2$4', $url . '&');
@@ -323,6 +341,9 @@  discard block
 block discarded – undo
323 341
         }
324 342
     }
325 343
 
344
+    /**
345
+     * @param string $url
346
+     */
326 347
     private function removeQueryString($url, $key)
327 348
     {
328 349
         $url = preg_replace('/(.*)(\?|&)' . $key . '=[^&]+?(&)(.*)/i', '$1$2$4', $url . '&');
@@ -394,7 +415,7 @@  discard block
 block discarded – undo
394 415
      * Set optional status header, and redirect to provided URL
395 416
      *
396 417
      * @access public
397
-     * @return bool
418
+     * @return false|null
398 419
      */
399 420
     public function redirect($url = '/', $status = null)
400 421
     {
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
         if (!preg_match("/^[a-z0-9:_\/\.\[\]-]+$/i", $uri)
143 143
             || array_filter(
144 144
                 $uriChunks,
145
-                function ($uriChunk) {
145
+                function($uriChunk) {
146 146
                     if (strpos($uriChunk, '__') !== false) {
147 147
                         return true;
148 148
                     }
@@ -225,7 +225,7 @@  discard block
 block discarded – undo
225 225
 
226 226
         $normalizedURI = ltrim(preg_replace('/\?.*/', '', $normalizedURI), '/');
227 227
 
228
-        if (! empty($this->routes)) {
228
+        if (!empty($this->routes)) {
229 229
             $normalizedURI = $this->discoverRoute($normalizedURI);
230 230
         }
231 231
 
@@ -244,11 +244,11 @@  discard block
 block discarded – undo
244 244
 
245 245
                 $uri = $reroute;
246 246
 
247
-                if (! empty($params)) {
247
+                if (!empty($params)) {
248 248
                     $pat = '/(\$\d+)/';
249 249
                     $uri = preg_replace_callback(
250 250
                         $pat,
251
-                        function () use (&$params) {
251
+                        function() use (&$params) {
252 252
                             $first = $params[0];
253 253
                             array_shift($params);
254 254
                             return $first;
Please login to merge, or discard this patch.
Zewa/ServiceManager.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -16,15 +16,15 @@  discard block
 block discarded – undo
16 16
      */
17 17
     public function __construct()
18 18
     {
19
-        $database = function () {
19
+        $database = function() {
20 20
             return new Database();
21 21
         };
22 22
 
23
-        $router = function () {
23
+        $router = function() {
24 24
             return new Router();
25 25
         };
26 26
 
27
-        $request = function () {
27
+        $request = function() {
28 28
             return new Request();
29 29
         };
30 30
 
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
 
36 36
     public function __get($property)
37 37
     {
38
-        if (! empty($this->services[$property])) {
38
+        if (!empty($this->services[$property])) {
39 39
             return $this->services[$property];
40 40
         }
41 41
         throw new Exception\LookupException('The service: ' . $property . ' hasn\'t been registered.');
Please login to merge, or discard this patch.
Zewa/Database.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@
 block discarded – undo
31 31
     public function establishConnection($name = 'default')
32 32
     {
33 33
         if ($this->configuration !== false) {
34
-            if (! empty($this->configuration->$name)) {
34
+            if (!empty($this->configuration->$name)) {
35 35
                 $dbConfig = $this->configuration->$name;
36 36
                 self::$dbh[$name] = new \PDO($dbConfig->dsn, $dbConfig->user, $dbConfig->pass);
37 37
                 self::$dbh[$name]->setAttribute(\PDO::ATTR_ERRMODE, \PDO::ERRMODE_EXCEPTION);
Please login to merge, or discard this patch.
Zewa/App.php 3 patches
Doc Comments   +7 added lines, -1 removed lines patch added patch discarded remove patch
@@ -214,6 +214,9 @@  discard block
 block discarded – undo
214 214
         }
215 215
     }
216 216
 
217
+    /**
218
+     * @param string $service
219
+     */
217 220
     public function setService($service, $class)
218 221
     {
219 222
         if($this->services === null) {
@@ -225,6 +228,7 @@  discard block
 block discarded – undo
225 228
 
226 229
     /**
227 230
      * @param mixed string with reference to config
231
+     * @param string $config
228 232
      * @return mixed bool or config values
229 233
      */
230 234
     public function getConfiguration($config = null)
@@ -342,7 +346,6 @@  discard block
 block discarded – undo
342 346
      * Attach (or remove) multiple callbacks to an event and trigger those callbacks when that event is called.
343 347
      *
344 348
      * @param string $event    name
345
-     * @param mixed  $value    the optional value to pass to each callback
346 349
      * @param mixed  $callback the method or function to call - FALSE to remove all callbacks for event
347 350
      */
348 351
 
@@ -356,6 +359,9 @@  discard block
 block discarded – undo
356 359
         }
357 360
     }
358 361
 
362
+    /**
363
+     * @param string $event
364
+     */
359 365
     public function callEvent($event, $method = false, $arguments = [])
360 366
     {
361 367
         if (isset(self::$events[$event])) {
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -231,9 +231,9 @@
 block discarded – undo
231 231
     public function getConfiguration($config = null)
232 232
     {
233 233
         if ($config !== null) {
234
-            if (! empty($this->configuration->$config)) {
234
+            if (!empty($this->configuration->$config)) {
235 235
                 return $this->configuration->$config;
236
-            } elseif (! empty($this->files{$config})) {
236
+            } elseif (!empty($this->files{$config})) {
237 237
                 $vars = include $this->files{$config};
238 238
 
239 239
                 if ($vars === false) {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -2,8 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace Zewa;
4 4
 
5
-use Zewa\Exception\LookupException;
6
-
7 5
 /**
8 6
  * This class is the starting point for application
9 7
  *
Please login to merge, or discard this patch.
Zewa/View.php 2 patches
Doc Comments   +7 added lines patch added patch discarded remove patch
@@ -170,6 +170,9 @@  discard block
 block discarded – undo
170 170
         return false;
171 171
     }
172 172
 
173
+    /**
174
+     * @param boolean|string $layout
175
+     */
173 176
     public function setLayout($layout)
174 177
     {
175 178
 
@@ -211,6 +214,10 @@  discard block
 block discarded – undo
211 214
      * @return string processed content
212 215
      */
213 216
     //@TODO: come back and clean up this and the way the view receives stuff
217
+
218
+    /**
219
+     * @param string|boolean $file
220
+     */
214 221
     private function process($file)
215 222
     {
216 223
         ob_start();
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
                 $this->view = $this->process($this->view);
115 115
             }
116 116
 
117
-            if (! is_null($this->layout)) {
117
+            if (!is_null($this->layout)) {
118 118
                 return $this->process($this->layout);
119 119
             } else {
120 120
                 return $this->view;
@@ -247,7 +247,7 @@  discard block
 block discarded – undo
247 247
         }
248 248
 
249 249
         foreach ($sheets as $sheet) {
250
-            $string .= '<link rel="stylesheet" href="' . $sheet .'">' . "\r\n";
250
+            $string .= '<link rel="stylesheet" href="' . $sheet . '">' . "\r\n";
251 251
         }
252 252
 
253 253
         return $string;
Please login to merge, or discard this patch.
Zewa/Request.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -172,7 +172,7 @@  discard block
 block discarded – undo
172 172
                 // iterate through all the entries
173 173
                 foreach ($this->flashdata as $variable => $data) {
174 174
                     // increment counter representing server requests
175
-                    $this->flashdata[$variable]['inc'] ++;
175
+                    $this->flashdata[$variable]['inc']++;
176 176
 
177 177
                     // if we're past the first server request
178 178
                     if ($this->flashdata[$variable]['inc'] > 1) {
@@ -348,7 +348,7 @@  discard block
 block discarded – undo
348 348
                 //@TODO this will not accept all float values, this validates /against/ syntax
349 349
 
350 350
                 if (($int === (int)trim($data, '-')) && strlen((string)(int)$data) === strlen($data)) {
351
-                    $data = (int) $data;
351
+                    $data = (int)$data;
352 352
                 } elseif ($int !== $float && preg_match($re, $data) === 1) {
353 353
                     $data = floatval($data);
354 354
                 }
@@ -368,12 +368,12 @@  discard block
 block discarded – undo
368 368
             $container = $name . 'Container';
369 369
             $container = $this->$container;
370 370
 
371
-            $argument = ! empty($arguments[0]) ? $arguments[0] : false;
371
+            $argument = !empty($arguments[0]) ? $arguments[0] : false;
372 372
 
373 373
             if ($argument === false && !empty($container)) {
374 374
                 return $container;
375 375
             }
376
-            if (! empty($container[$argument])) {
376
+            if (!empty($container[$argument])) {
377 377
                 if (!is_array($container[$argument])
378 378
                     && !is_object($container[$argument])
379 379
                     && strlen($container[$argument]) > 0
@@ -384,7 +384,7 @@  discard block
 block discarded – undo
384 384
                 }
385 385
             }
386 386
 
387
-            return ! empty($arguments[1]) ? $arguments[1] : false;
387
+            return !empty($arguments[1]) ? $arguments[1] : false;
388 388
         }
389 389
 
390 390
         throw new Exception\FunctionException('Method ' . $name . ' does not exist.');
Please login to merge, or discard this patch.